Total Complexity | 57 |
Total Lines | 491 |
Duplicated Lines | 0 % |
Changes | 5 | ||
Bugs | 0 | Features | 0 |
Complex classes like ProcessCacheInvalidationEventsCommand often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ProcessCacheInvalidationEventsCommand, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
11 | class ProcessCacheInvalidationEventsCommand extends Command |
||
12 | { |
||
13 | /** |
||
14 | * The name and signature of the console command. |
||
15 | * |
||
16 | * @var string |
||
17 | */ |
||
18 | protected $signature = 'supercache:process-invalidation |
||
19 | {--shard= : The shard number to process} |
||
20 | {--priority= : The priority level} |
||
21 | {--limit= : The maximum number of events to fetch per batch} |
||
22 | {--tag-batch-size= : The number of identifiers to process per invalidation batch} |
||
23 | {--connection_name= : The Redis connection name}'; |
||
24 | |||
25 | /** |
||
26 | * The console command description. |
||
27 | * |
||
28 | * @var string |
||
29 | */ |
||
30 | protected $description = 'Process cache invalidation events for a given shard and priority'; |
||
31 | |||
32 | /** |
||
33 | * Cache invalidation helper instance. |
||
34 | */ |
||
35 | protected SuperCacheInvalidationHelper $helper; |
||
36 | |||
37 | /** |
||
38 | * Create a new command instance. |
||
39 | */ |
||
40 | public function __construct(SuperCacheInvalidationHelper $helper) |
||
44 | } |
||
45 | |||
46 | private function getStoreFromConnectionName(string $connection_name): ?string |
||
60 | } |
||
61 | |||
62 | |||
63 | |||
64 | /** |
||
65 | * Process cache invalidation events. |
||
66 | * |
||
67 | * @param int $shardId The shard number to process |
||
68 | * @param int $priority The priority level |
||
69 | * @param int $limit Maximum number of events to fetch per batch |
||
70 | * @param int $tagBatchSize Number of identifiers to process per batch |
||
71 | * |
||
72 | * @throws \Exception |
||
73 | * @throws \Throwable |
||
74 | */ |
||
75 | protected function processEvents(int $shardId, int $priority, int $limit, int $tagBatchSize, string $connection_name): void |
||
76 | { |
||
77 | $processingStartTime = now(); |
||
78 | $invalidationWindow = config('super_cache_invalidate.invalidation_window'); |
||
79 | |||
80 | // Fetch a batch of unprocessed events |
||
81 | $partitionCache_invalidation_events = $this->helper->getCacheInvalidationEventsPartitionName($shardId, $priority); |
||
82 | |||
83 | $events = DB::table(DB::raw("`cache_invalidation_events` PARTITION ({$partitionCache_invalidation_events})")) |
||
84 | //->from(DB::raw("`{$this->from}` PARTITION ({$partitionsString})")) |
||
85 | ->where('processed', '=', 0) |
||
86 | ->where('shard', '=', $shardId) |
||
87 | ->where('priority', '=', $priority) |
||
88 | ->where('event_time', '<', $processingStartTime) |
||
89 | // Cerco tutte le chiavi/tag da invalidare per questo database redis |
||
90 | ->where('connection_name', '=', $connection_name) |
||
91 | ->orderBy('event_time') |
||
92 | ->limit($limit) |
||
93 | ->get() |
||
94 | ; |
||
95 | |||
96 | //ds($partitionCache_invalidation_events . ' -> Shard (' . $shardId . ') Priority (' . $priority . ') Record = ' . $events->count()); |
||
97 | if ($events->isEmpty()) { |
||
98 | // No more events to process |
||
99 | return; |
||
100 | } |
||
101 | |||
102 | // Group events by type and identifier |
||
103 | $eventsByIdentifier = $events->groupBy(function ($event) { |
||
104 | return $event->type . ':' . $event->identifier; |
||
105 | }); |
||
106 | |||
107 | $batchIdentifiers = []; |
||
108 | $eventsToUpdate = []; |
||
109 | $counter = 0; |
||
110 | |||
111 | // Fetch associated identifiers for the events |
||
112 | // TODO JB 31/12/2024: per adesso commentato, da riattivare quando tutto funziona alla perfezione usando la partizione |
||
113 | $associations = collect(); |
||
114 | /* |
||
115 | $eventIds = $events->pluck('id')->all(); |
||
116 | |||
117 | //retrive associated identifiers related to fetched event id |
||
118 | // Per le chiavi/tag associati non filtro per connection_name, potrebbero esserci associazioni anche in altri database |
||
119 | $associations = DB::table('cache_invalidation_event_associations') |
||
120 | ->whereIn('event_id', $eventIds) |
||
121 | ->get() |
||
122 | ->groupBy('event_id') |
||
123 | ; |
||
124 | */ |
||
125 | |||
126 | // Prepare list of all identifiers to fetch last invalidation times |
||
127 | $allIdentifiers = []; |
||
128 | foreach ($eventsByIdentifier as $key => $eventsGroup) { |
||
129 | $allIdentifiers[] = $key; |
||
130 | foreach ($eventsGroup as $event) { |
||
131 | $eventAssociations = $associations->where('event_id', '=', $event->id); |
||
132 | foreach ($eventAssociations as $assoc) { |
||
133 | $assocKey = $assoc->associated_type . ':' . $assoc->associated_identifier; |
||
134 | $allIdentifiers[] = $assocKey; |
||
135 | } |
||
136 | } |
||
137 | } |
||
138 | // Fetch last invalidation times in bulk |
||
139 | $lastInvalidationTimes = $this->getLastInvalidationTimes(array_unique($allIdentifiers)); |
||
140 | |||
141 | foreach ($eventsByIdentifier as $key => $eventsGroup) { |
||
142 | // Extract type and identifier |
||
143 | [$type, $identifier] = explode(':', $key, 2); |
||
144 | |||
145 | // Get associated identifiers for the events |
||
146 | $associatedIdentifiers = []; |
||
147 | foreach ($eventsGroup as $event) { |
||
148 | $eventAssociations = $associations->where('event_id', '=', $event->id); |
||
149 | foreach ($eventAssociations as $assoc) { |
||
150 | $assocKey = $assoc->associated_type . ':' . $assoc->associated_identifier; |
||
151 | $associatedIdentifiers[$assocKey] = [ |
||
152 | 'type' => $assoc->associated_type, |
||
153 | 'identifier' => $assoc->associated_identifier, |
||
154 | 'connection_name' => $assoc->connection_name, |
||
155 | ]; |
||
156 | } |
||
157 | } |
||
158 | |||
159 | // Build a list of all identifiers to check |
||
160 | $identifiersToCheck = [$key]; |
||
161 | $identifiersToCheck = array_merge($identifiersToCheck, array_keys($associatedIdentifiers)); |
||
162 | $lastInvalidationTimesSubset = array_intersect_key($lastInvalidationTimes, array_flip($identifiersToCheck)); |
||
163 | |||
164 | $shouldInvalidate = $this->shouldInvalidateMultiple($identifiersToCheck, $lastInvalidationTimesSubset, $invalidationWindow); |
||
165 | |||
166 | if ($shouldInvalidate) { |
||
167 | // Proceed to invalidate |
||
168 | $latestEvent = $eventsGroup->last(); |
||
169 | |||
170 | // Accumulate identifiers and events |
||
171 | $batchIdentifiers[] = [ |
||
172 | 'type' => $type, |
||
173 | 'identifier' => $identifier, |
||
174 | 'event' => $latestEvent, |
||
175 | 'connection_name' => $connection_name, |
||
176 | 'associated' => array_values($associatedIdentifiers), |
||
177 | ]; |
||
178 | |||
179 | // Update last invalidation times for all identifiers |
||
180 | $this->updateLastInvalidationTimes($identifiersToCheck); |
||
181 | |||
182 | // Mark all events in the group as processed |
||
183 | foreach ($eventsGroup as $event) { |
||
184 | $eventsToUpdate[] = $event->id; |
||
185 | } |
||
186 | } else { |
||
187 | // Within the invalidation window, skip invalidation |
||
188 | // Mark all events except the last one as processed |
||
189 | $eventsToProcess = $eventsGroup->slice(0, -1); |
||
190 | foreach ($eventsToProcess as $event) { |
||
191 | $eventsToUpdate[] = $event->id; |
||
192 | } |
||
193 | // The last event remains unprocessed |
||
194 | } |
||
195 | |||
196 | $counter++; |
||
197 | |||
198 | // When we reach the batch size, process the accumulated identifiers |
||
199 | if ($counter % $tagBatchSize === 0) { |
||
200 | $this->processBatch($batchIdentifiers, $eventsToUpdate, $shardId, $priority); |
||
201 | |||
202 | // Reset the accumulators |
||
203 | $batchIdentifiers = []; |
||
204 | $eventsToUpdate = []; |
||
205 | } |
||
206 | } |
||
207 | |||
208 | if (empty($batchIdentifiers)) { |
||
209 | return; |
||
210 | } |
||
211 | |||
212 | // Process any remaining identifiers in the batch |
||
213 | $this->processBatch($batchIdentifiers, $eventsToUpdate, $shardId, $priority); |
||
214 | } |
||
215 | |||
216 | /** |
||
217 | * Fetch last invalidation times for identifiers in bulk. |
||
218 | * |
||
219 | * @param array $identifiers Array of 'type:identifier' strings |
||
220 | * @return array Associative array of last invalidation times |
||
221 | */ |
||
222 | protected function getLastInvalidationTimes(array $identifiers): array |
||
243 | } |
||
244 | |||
245 | /** |
||
246 | * Execute Query to get records from DB |
||
247 | */ |
||
248 | protected function getRecordsFromDb(array $tuples): array |
||
249 | { |
||
250 | // Prepare placeholders and parameters |
||
251 | $placeholders = implode(',', array_fill(0, count($tuples), '(?, ?)')); |
||
252 | $params = []; |
||
253 | foreach ($tuples as [$type, $identifier]) { |
||
254 | $params[] = $type; |
||
255 | $params[] = $identifier; |
||
256 | } |
||
257 | |||
258 | $sql = "SELECT identifier_type, |
||
259 | identifier, |
||
260 | last_invalidated |
||
261 | FROM cache_invalidation_timestamps |
||
262 | WHERE (identifier_type, identifier) IN ($placeholders) |
||
263 | "; |
||
264 | |||
265 | return DB::select($sql, $params); |
||
266 | } |
||
267 | |||
268 | /** |
||
269 | * Determine whether to invalidate based on last invalidation times for multiple identifiers. |
||
270 | * |
||
271 | * @param array $identifiers Array of 'type:identifier' strings |
||
272 | * @param array $lastInvalidationTimes Associative array of last invalidation times |
||
273 | * @param int $invalidationWindow Invalidation window in seconds |
||
274 | * @return bool True if should invalidate, false otherwise |
||
275 | */ |
||
276 | protected function shouldInvalidateMultiple(array $identifiers, array $lastInvalidationTimes, int $invalidationWindow): bool |
||
293 | } |
||
294 | |||
295 | /** |
||
296 | * Update the last invalidation times for multiple identifiers. |
||
297 | * |
||
298 | * @param array $identifiers Array of 'type:identifier' strings |
||
299 | */ |
||
300 | protected function updateLastInvalidationTimes(array $identifiers): void |
||
310 | ) |
||
311 | ; |
||
312 | } |
||
313 | } |
||
314 | |||
315 | /** |
||
316 | * Process a batch of identifiers and update events. |
||
317 | * |
||
318 | * @param array $batchIdentifiers Array of identifiers to invalidate |
||
319 | * @param array $eventsToUpdate Array of event IDs to mark as processed |
||
320 | * |
||
321 | * @throws \Throwable |
||
322 | */ |
||
323 | protected function processBatch(array $batchIdentifiers, array $eventsToUpdate, int $shard, int $priority): void |
||
324 | { |
||
325 | $maxAttempts = 5; |
||
326 | $attempts = 0; |
||
327 | $updatedOk = false; |
||
328 | |||
329 | // Separate keys and tags |
||
330 | $keys = []; |
||
331 | $tags = []; |
||
332 | |||
333 | foreach ($batchIdentifiers as $item) { |
||
334 | switch ($item['type']) { |
||
335 | case 'key': |
||
336 | $keys[] = $item['identifier'] . '§' . $item['connection_name']; |
||
337 | break; |
||
338 | case 'tag': |
||
339 | $tags[] = $item['identifier'] . '§' . $item['connection_name']; |
||
340 | break; |
||
341 | } |
||
342 | |||
343 | if (empty($item['associated'])) { |
||
344 | continue; |
||
345 | } |
||
346 | |||
347 | // Include associated identifiers |
||
348 | foreach ($item['associated'] as $assoc) { |
||
349 | switch ($assoc['type']) { |
||
350 | case 'key': |
||
351 | $keys[] = $assoc['identifier'] . '§' . $assoc['connection_name']; |
||
352 | break; |
||
353 | case 'tag': |
||
354 | $tags[] = $assoc['identifier'] . '§' . $assoc['connection_name']; |
||
355 | break; |
||
356 | } |
||
357 | } |
||
358 | } |
||
359 | |||
360 | // Remove duplicates |
||
361 | $keys = array_unique($keys); |
||
362 | $tags = array_unique($tags); |
||
363 | |||
364 | // Invalidate cache for keys |
||
365 | if (!empty($keys)) { |
||
366 | $this->invalidateKeys($keys); |
||
367 | } |
||
368 | |||
369 | // Invalidate cache for tags |
||
370 | if (!empty($tags)) { |
||
371 | $this->invalidateTags($tags); |
||
372 | } |
||
373 | |||
374 | while ($attempts < $maxAttempts && !$updatedOk) { |
||
375 | // Begin transaction for the batch |
||
376 | DB::beginTransaction(); |
||
377 | |||
378 | try { |
||
379 | // Mark events as processed |
||
380 | $partitionCache_invalidation_events = $this->helper->getCacheInvalidationEventsPartitionName($shard, $priority); |
||
381 | DB::table(DB::raw("`cache_invalidation_events` PARTITION ({$partitionCache_invalidation_events})")) |
||
382 | ->whereIn('id', $eventsToUpdate) |
||
383 | ->update(['processed' => 1]) |
||
384 | ; |
||
385 | |||
386 | // Commit transaction |
||
387 | DB::commit(); |
||
388 | $updatedOk = true; |
||
389 | } catch (\Throwable $e) { |
||
390 | // Rollback transaction on error |
||
391 | DB::rollBack(); |
||
392 | $attempts++; |
||
393 | $this->warn(now()->toDateTimeString() . ": Tentativo $attempts di $maxAttempts: " . $e->getMessage()); |
||
394 | // Logica per gestire i tentativi falliti |
||
395 | if ($attempts >= $maxAttempts) { |
||
396 | // Salta il record dopo il numero massimo di tentativi |
||
397 | throw $e; |
||
398 | } |
||
399 | } |
||
400 | } |
||
401 | } |
||
402 | |||
403 | /** |
||
404 | * Invalidate cache keys. |
||
405 | * |
||
406 | * @param array $keys Array of cache keys to invalidate |
||
407 | */ |
||
408 | protected function invalidateKeys(array $keys): void |
||
409 | { |
||
410 | $callback = config('super_cache_invalidate.key_invalidation_callback'); |
||
411 | |||
412 | |||
413 | // Anche in questo caso va fatto un loop perchè le chiavi potrebbero stare in database diversi |
||
414 | foreach ($keys as $keyAndConnectionName) { |
||
415 | [$key, $connection_name] = explode('§', $keyAndConnectionName); |
||
416 | |||
417 | // Metodo del progetto |
||
418 | if (is_callable($callback)) { |
||
419 | $callback($key, $connection_name); |
||
420 | |||
421 | return; |
||
422 | } |
||
423 | |||
424 | // oppure di default uso Laravel |
||
425 | $storeName = $this->getStoreFromConnectionName($connection_name); |
||
426 | |||
427 | if ($storeName === null) { |
||
428 | return; |
||
429 | } |
||
430 | Cache::store($storeName)->forget($key); |
||
431 | } |
||
432 | } |
||
433 | |||
434 | /** |
||
435 | * Invalidate cache tags. |
||
436 | * |
||
437 | * @param array $tags Array of cache tags to invalidate |
||
438 | */ |
||
439 | protected function invalidateTags(array $tags): void |
||
440 | { |
||
441 | $callback = config('super_cache_invalidate.tag_invalidation_callback'); |
||
442 | |||
443 | $groupByConnection = []; |
||
444 | |||
445 | // Anche in questo caso va fatto un loop perchè i tags potrebbero stare in database diversi, |
||
446 | // ma per ottimizzare possiamo raggruppare le operazioni per connessione |
||
447 | foreach ($tags as $tagAndConnectionName) { |
||
448 | // chiave e connessione |
||
449 | [$key, $connection] = explode('§', $tagAndConnectionName); |
||
450 | |||
451 | // Aggiungo la chiave alla connessione appropriata |
||
452 | $groupByConnection[$connection][] = $key; |
||
453 | } |
||
454 | if (is_callable($callback)) { |
||
455 | foreach ($groupByConnection as $connection_name => $arrTags) { |
||
456 | $callback($arrTags, $connection_name); |
||
457 | } |
||
458 | |||
459 | return; |
||
460 | } |
||
461 | foreach ($groupByConnection as $connection_name => $arrTags) { |
||
462 | $storeName = $this->getStoreFromConnectionName($connection_name); |
||
463 | if ($storeName === null) { |
||
464 | return; |
||
465 | } |
||
466 | Cache::store($storeName)->tags($arrTags)->flush(); |
||
467 | } |
||
468 | } |
||
469 | |||
470 | /** |
||
471 | * Execute the console command. |
||
472 | */ |
||
473 | public function handle(): void |
||
502 | } |
||
503 | } |
||
504 | } |
||
505 |