Notifier - Code Metrics - Inspection of "Fixato Notifier rivedendo la logica dei messaggi..." - padosoft/laravel-notifier - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff3871...123d0d )

unknown

created 2021-03-08 17:21 UTC

Notifier C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	237
Duplicated Lines	18.57 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	54
lcom	1
cbo	0
dl	44
loc	237
rs	6.4799
c	0
b	0
f	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	3
A	render()	0	13	3
A	add()	6	26	5
B	addForNextRequest()	6	33	6
B	info()	8	8	8
B	error()	8	8	8
B	warning()	8	8	8
B	success()	7	7	8
A	clear()	0	4	1
A	clearFlashed()	0	8	2
A	clearAll()	0	9	2

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Notifier often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Notifier, and based on these observations, apply Extract Interface, too.

<?php

namespace Padosoft\Laravel\Notification\Notifier;

use Illuminate\Session\SessionManager;

class Notifier
{

    /**
     * Added notifications
     *
     * @var array
     */
    protected $notifications = [];

    /**
     * Flashable added notifications
     *
     * @var array
     */
    protected $flashedNotifications = [];

    /**
     * Added notifications
     *
     * @var array
     */
    protected $options = [];

    /**
     * Illuminate Session
     *
     * @var \Illuminate\Session\SessionManager
     */
    protected $session;

    /**
     * Constructor
     *
     * @param \Illuminate\Session\SessionManager $session
     *
     * @internal param \Illuminate\Session\SessionManager $session
     */
    public function __construct(SessionManager $session)
    {
        $this->session = $session;
        $flashedNotifications = null;

        if ($this->session->has('laravel::flash-notifications')) {
            $flashedNotifications = $this->session->get('laravel::flash-notifications');
        }
        if ($flashedNotifications !== null) {
            $this->flashedNotifications = $flashedNotifications;
        } else {
            $this->flashedNotifications = [];
        }
    }

    /**
     * Render all the notifications' script to insert into script tag
     *
     * @return string
     *
     */
    public function render(): string
    {
        $output = [];
        foreach ($this->notifications as $notification) {

            $output[] = $notification;
        }
        foreach ($this->flashedNotifications as $flNotification) {
            $output[] = $flNotification;
        }

        return "window.notifications = " . json_encode($output) . ";";
    }

    /**
     * Add a notification
     *
     * @param string $type Could be error, info, success, or warning.
     * @param string $text The notification's message
     * @param string $title The notification's title
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array $options
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param bool $onlyNextRequest if true(default), se the notification in session only for the next request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     */
    public function add($theme, $timeout, $type, $layout, $text, $sounds = null, $soundsVolume = null)
    {
        if ($type == '') {
            $type = 'info';
        }

        if ($timeout === null) {
            $timeout = false;
        }

        $notification = [
            'theme' => $theme,
            'timeout' => $timeout,
            'type' => $type,
            'layout' => $layout,
            'text' => $text,
        ];
        if ($sounds !== null) {

            $notification['sources'] = [
                'sounds' => [$sounds],
                'soundsVolume' => $soundsVolume !== null ? $soundsVolume : 0.5,
            ];
        }

        $this->notifications[] = $notification;
    }

    public function addForNextRequest($theme, $timeout, $type, $layout, $text, $sounds = null, $soundsVolume = null)
    {
        if ($type == '') {
            $type = 'info';
        }

        if ($timeout === null) {
            $timeout = false;
        }

        $notification = [
            'theme' => $theme,
            'timeout' => $timeout,
            'type' => $type,
            'layout' => $layout,
            'text' => $text,
        ];
        if ($sounds !== null) {

            $notification['sources'] = [
                'sounds' => [$sounds],
                'soundsVolume' => $soundsVolume !== null ? $soundsVolume : 0.5,
            ];
        }

        if ($this->session->has('laravel::flash-notifications')) {
            $flashNotifications = $this->session->get('laravel::flash-notifications');
        } else {
            $flashNotifications = [];
        }
        $this->session->forget('laravel::flash-notifications');
        $flashNotifications[] = $notification;
        $this->session->flash('laravel::flash-notifications', $flashNotifications);
    }

    /**
     * Shortcut for adding an info notification
     *
     * @param string $message The notification's message
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $title The notification's title
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array $options
     */
    public function info($text, $onlyNextRequest = true, array $options = [])

    {
        $theme = (isset($options['theme']) && $options['theme'] != '') ? $options['theme'] : 'metroui';
        $timeout = (isset($options['timeout']) && $options['timeout'] != '' && is_int($options['timeout'])) ? $options['timeout'] : false;
        $layout = (isset($options['layout']) && $options['layout'] != '') ? $options['layout'] : 'topRight';

        $this->add($theme, $timeout, 'info', $layout, $text, null, null, $onlyNextRequest);

    }

    /**
     * Shortcut for adding an error notification
     *
     * @param string $message The notification's message
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $title The notification's title
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array $options
     */
    public function error($text, $onlyNextRequest = true, array $options = [])

    {
        $theme = (isset($options['theme']) && $options['theme'] != '') ? $options['theme'] : 'metroui';
        $timeout = (isset($options['timeout']) && $options['timeout'] != '' && is_int($options['timeout'])) ? $options['timeout'] : 0;
        $layout = (isset($options['layout']) && $options['layout'] != '') ? $options['layout'] : 'topRight';

        $this->add($theme, $timeout, 'error', $layout, $text, null, null, $onlyNextRequest);

    }

    /**
     * Shortcut for adding a warning notification
     *
     * @param string $message The notification's message
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $title The notification's title
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array $options
     */
    public function warning($text, $onlyNextRequest = true, array $options = [])

    {
        $theme = (isset($options['theme']) && $options['theme'] != '') ? $options['theme'] : 'metroui';
        $timeout = (isset($options['timeout']) && $options['timeout'] != '' && is_int($options['timeout'])) ? $options['timeout'] : 0;
        $layout = (isset($options['layout']) && $options['layout'] != '') ? $options['layout'] : 'topRight';

        $this->add($theme, $timeout, 'warning', $layout, $text, null, null, $onlyNextRequest);

    }

    /**
     * Shortcut for adding a success notification
     *
     * @param string $message The notification's message
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $title The notification's title
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array $options
     */
    public function success($text, $onlyNextRequest = true, array $options = [])

    {
        $theme = (isset($options['theme']) && $options['theme'] != '') ? $options['theme'] : 'metroui';
        $timeout = (isset($options['timeout']) && $options['timeout'] != '' && is_int($options['timeout'])) ? $options['timeout'] : 0;
        $layout = (isset($options['layout']) && $options['layout'] != '') ? $options['layout'] : 'topRight';
        $this->add($theme, $timeout, 'success', $layout, $text, null, null, $onlyNextRequest);

    }


    /**
     * Clear all notifications
     *
     * @param bool $withSession if true (default) clean notifications in session too.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function clear()
    {
        $this->notifications = [];
    }

    public function clearFlashed(bool $withSession = true)
    {
        $this->flashedNotifications = [];

        if ($withSession) {
            $this->session->forget('laravel::flash-notifications');
        }
    }

    public function clearAll(bool $withSession = true)
    {
        $this->notifications = [];
        $this->flashedNotifications = [];

        if ($withSession) {
            $this->session->forget('laravel::flash-notifications');
        }
    }
}


1			<?php
2
3			namespace Padosoft\Laravel\Notification\Notifier;
4
5			use Illuminate\Session\SessionManager;
6
7			class Notifier
8			{
9
10			/**
11			* Added notifications
12			*
13			* @var array
14			*/
15			protected $notifications = [];
16
17			/**
18			* Flashable added notifications
19			*
20			* @var array
21			*/
22			protected $flashedNotifications = [];
23
24			/**
25			* Added notifications
26			*
27			* @var array
28			*/
29			protected $options = [];
30
31			/**
32			* Illuminate Session
33			*
34			* @var \Illuminate\Session\SessionManager
35			*/
36			protected $session;
37
38			/**
39			* Constructor
40			*

padosoft / laravel-notifier