Padosoft\AffiliateNetwork\EffiliationEx

Complexity

Total Complexity

7

Size/Duplication

Total Lines	49
Duplicated Lines	14.29 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
C	getTransactionList()	7	41	7

<?php
/**
 * Copyright (c) Padosoft.com 2017.
 */
namespace Padosoft\AffiliateNetwork;
use Oara\Network\Publisher\Effiliation as EffiliationOara;

class EffiliationEx extends EffiliationOara{
    /**
     * @param null $merchantList
     * @param \DateTime|null $dStartDate
     * @param \DateTime|null $dEndDate
     * @return array
     */
    public function getTransactionList($merchantList = null, \DateTime $dStartDate = null, \DateTime $dEndDate = null)
    {
        $totalTransactions = array();

        $merchantIdList = \Oara\Utilities::getMerchantIdMapFromMerchantList($merchantList);

        $url = 'http://api.effiliation.com/apiv2/transaction.csv?key=' . $this->_credentials["apiPassword"] . '&start=' . $dStartDate->format("d/m/Y") . '&end=' . $dEndDate->format("d/m/Y") . '&type=date&all=yes';

The property _credentials cannot be accessed from this context as it is declared private in class Oara\Network\Publisher\Effiliation.

It seems like $dStartDate is not always an object, but can also be of type null. Maybe add an additional type check?

It seems like $dEndDate is not always an object, but can also be of type null. Maybe add an additional type check?

        $content = \utf8_encode(\file_get_contents($url));
        $exportData = \str_getcsv($content, "\n");
        $num = \count($exportData);

        for ($i = 1; $i < $num; $i++) {
            $transactionExportArray = \str_getcsv($exportData[$i], "|");
            if (isset($merchantIdList[(int)$transactionExportArray[2]])) {

                $transaction = Array();
                $merchantId = (int)$transactionExportArray[2];
                $transaction['merchantId'] = $merchantId;
                $transaction['date'] = $transactionExportArray[10];
                $transaction['unique_id'] = $transactionExportArray[0];
                $transaction['custom_id'] = '';
                if ($transactionExportArray[4] != null) {
                    $transaction['custom_id'] = $transactionExportArray[4];
                }

                if ($transactionExportArray[9] == 'Valide') {
                    $transaction['status'] = \Oara\Utilities::STATUS_CONFIRMED;
                } else

This code seems to be duplicated across your project.

                    if ($transactionExportArray[9] == 'Attente') {
                        $transaction['status'] = \Oara\Utilities::STATUS_PENDING;
                    } else
                        if ($transactionExportArray[9] == 'Refus�') {
                            $transaction['status'] = \Oara\Utilities::STATUS_DECLINED;
                        }
                $transaction['amount'] = \Oara\Utilities::parseDouble($transactionExportArray[7]);
                $transaction['commission'] = \Oara\Utilities::parseDouble($transactionExportArray[8]);
                $totalTransactions[] = $transaction;
            }
        }
        return $totalTransactions;
    }
}