Padosoft\AffiliateNetwork\Networks\Zanox::getDeals()

Complexity

Conditions	17
Paths	587

Size

Total Lines	92
Code Lines	68

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getDeals($merchantID=NULL,int $page = 0, int $items_per_page = 0 ): DealsResultset
    {
        $result = DealsResultset::createInstance();
        if (!$this->checkLogin()) {
            return $result;
        }
        /*

48% of this comment could be valid code. Did you maybe forget this after debugging?

        if (!isIntegerPositive($items_per_page) || $items_per_page <= 0 || $items_per_page > 999) {
            $items_per_page = 999;
        }
        */
        $adSpaces=$this->_apiClient->getAdspaces(0,100);
        if (!is_object($adSpaces)){
            $adSpaces=json_encode($adSpaces);
        }
        if ($adSpaces->items<1){
            return $result;
        }

        $adSpaceId=$adSpaces->adspaceItems->adspaceItem[0]->id;
        if (!isIntegerPositive($merchantID)){
            $merchantID=NULL;
        }

        $Response = $this->_apiClient->searchIncentives($merchantID,$adSpaceId,null,null, $page, $items_per_page);
        
        if (!is_object($Response)){
            $Response=json_decode($Response);
        }
        $result->page=$Response->page;
        $result->items=$Response->items;
        $result->total=$Response->total;
        // ($Response->total>0)?$result->num_pages=(int)ceil($Response->total/$items_per_page):$result->num_pages=0;

66% of this comment could be valid code. Did you maybe forget this after debugging?

        $arrAdmediumItems = $Response->incentiveItems->incentiveItem;

        foreach ($arrAdmediumItems as $admediumItems) {
            $Deal = Deal::createInstance();
            $Deal->deal_ID = (int)$admediumItems->id;
            $Deal->start_date = $Deal->convertDate($admediumItems->startDate);

It seems like $Deal->convertDate($admediumItems->startDate) can also be of type false. However, the property $start_date is declared as type object<DateTime>. Maybe add an additional type check?

            isset($admediumItems->endDate) ? $Deal->end_date = $Deal->convertDate($admediumItems->endDate): $Deal->end_date = '2099-12-31';

It seems like $Deal->convertDate($admediumItems->endDate) can also be of type false. However, the property $end_date is declared as type object<DateTime>. Maybe add an additional type check?

It seems like '2099-12-31' of type string is incompatible with the declared type object<DateTime> of property $end_date.

            $Deal->name = $admediumItems->name;
            $Deal->code = $admediumItems->couponCode;
            $Deal->description = $admediumItems->info4customer;
            $Deal->information = $admediumItems->info4publisher.' '.$admediumItems->restrictions;
            $Deal->is_percentage = 0;

The property $is_percentage was declared of type boolean, but 0 is of type integer. Maybe add a type cast?

            $Deal->discount_amount = 0;

The property $discount_amount was declared of type string, but 0 is of type integer. Maybe add a type cast?

            $Deal->currency_initial = '';
            if (isset($admediumItems->percentage) && isIntegerPositive($admediumItems->percentage)){
                $Deal->is_percentage = 1;

The property $is_percentage was declared of type boolean, but 1 is of type integer. Maybe add a type cast?

                $Deal->discount_amount = $admediumItems->percentage;
            }elseif (isset($admediumItems->total)){
                $Deal->discount_amount = $admediumItems->total;
                $Deal->currency_initial = $admediumItems->currency;
            }
            switch ($admediumItems->incentiveType) {
                case 'coupons':
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_VOUCHER;
                    break;
                case 'bargains':
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_DISCOUNT;
                    break;
                case 'noShippingCosts':
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_FREE_SHIPPING;
                    break;
                case 'freeProducts':
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_FREE_ARTICLE;
                    break;
                case 'lotteries':
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_LOTTERY;
                    break;
                default:
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_DISCOUNT;
                    break;
            }
            $Deal->merchant_ID = (int)$admediumItems->program->id;
            
            $Deal->merchant_name = $admediumItems->program->_;
            if (isset($admediumItems->admedia->admediumItem[0]->trackingLinks->trackingLink)) {
                $Deal->ppv = $admediumItems->admedia->admediumItem[0]->trackingLinks->trackingLink[0]->ppv;
                $Deal->ppc = $admediumItems->admedia->admediumItem[0]->trackingLinks->trackingLink[0]->ppc;
                $Deal->default_track_uri = $Deal->ppc;
            }
            else {
                $Deal->ppv = "*** NO LINK ***";
                $Deal->ppc = "*** NO LINK ***";

            }
            $arrResult[] = $Deal;

$arrResult was never initialized. Although not strictly required by PHP, it is generally a good practice to add $arrResult = array(); before regardless.

        }
        $result->deals[] = $arrResult;

The variable $arrResult does not seem to be defined for all execution paths leading up to this point.

        return $result;
    }