Padosoft\AffiliateNetwork\Networks\TradeDoubler

Complexity

Total Complexity

29

Size/Duplication

Total Lines	215
Duplicated Lines	23.72 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	8	8	1
A	login()	21	21	4
A	checkLogin()	0	4	1
A	getMerchants()	16	16	3
C	getDeals()	0	69	11
B	getSales()	6	30	6
A	getStats()	0	4	1
A	getProducts()	0	5	1
A	getTrackingParameter()	0	3	1

<?php

namespace Padosoft\AffiliateNetwork\Networks;

use Padosoft\AffiliateNetwork\Transaction;
use Padosoft\AffiliateNetwork\DealsResultset;
use Padosoft\AffiliateNetwork\Merchant;
use Padosoft\AffiliateNetwork\Stat;
use Padosoft\AffiliateNetwork\Deal;
use Padosoft\AffiliateNetwork\AbstractNetwork;
use Padosoft\AffiliateNetwork\NetworkInterface;
use Padosoft\AffiliateNetwork\TradeDoublerEx;
use Padosoft\AffiliateNetwork\ProductsResultset;

if (!defined('COOKIES_BASE_DIR')){
    define('COOKIES_BASE_DIR',public_path('upload/report'));
}
/**
 * Class TradeDoubler
 * @package Padosoft\AffiliateNetwork\Networks
 */
class TradeDoubler extends AbstractNetwork implements NetworkInterface
{
    /**
     * @var object
     */
    private $_network = null;
    private $_apiClient = null;
    private $_username = '';
    private $_password = '';
    private $_logged    = false;
    protected $_tracking_parameter    = 'epi';

    /**
     * @method __construct
     */
    public function __construct(string $username, string $password,string $idSite='')

The parameter $idSite is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $this->_network = new TradeDoublerEx;
        $this->_username = $username;
        $this->_password = $password;
        $this->_apiClient = null;
        $this->login( $this->_username, $this->_password );
    }

    public function login(string $username, string $password,string $idSite=''): bool

The parameter $idSite is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $this->_logged = false;
        if (isNullOrEmpty( $username ) || isNullOrEmpty( $password )) {

            return false;
        }
        $this->_username = $username;
        $this->_password = $password;
        $credentials = array();
        $credentials["user"] = $this->_username;
        $credentials["password"] = $this->_password;
        $this->_network->login( $credentials );

        if ($this->_network->checkConnection()) {
            $this->_logged = true;

        }

        return $this->_logged;
    }

    /**
     * @return bool
     */
    public function checkLogin() : bool
    {
        return $this->_logged;;
    }

    /**
     * @return array of Merchants
     */
    public function getMerchants() : array

This method seems to be duplicated in your project.

    {
        if (!$this->checkLogin()) {
            return array();
        }
        $arrResult = array();
        $merchantList = $this->_network->getMerchantList();
        foreach($merchantList as $merchant) {
            $Merchant = Merchant::createInstance();
            $Merchant->merchant_ID = $merchant['cid'];
            $Merchant->name = $merchant['name'];
            $arrResult[] = $Merchant;
        }

        return $arrResult;
    }

    /**
     * @param int|null $merchantID
     * @param int $page
     * @param int $items_per_page
     *
     * @return DealsResultset
     */
    public function getDeals($merchantID,int $page=0,int $items_per_page=10) : DealsResultset
    {
        if (!isIntegerPositive($items_per_page)){
            $items_per_page=10;

$items_per_page is not used, you could remove the assignment.

        }
        $result=DealsResultset::createInstance();
        if (!$this->checkLogin()) {
            return $result;
        }
        $arrResult = array();
        $jsonVouchers = file_get_contents("https://api.tradedoubler.com/1.0/vouchers.json;dateOutputFormat=iso8601?token=".$_ENV['TRADEDOUBLER_TOKEN']);
        $arrVouchers = json_decode($jsonVouchers, true);

        foreach($arrVouchers as $voucher) {
            $Deal = Deal::createInstance();
            $Deal->setValues($voucher, [
                'id' => 'deal_ID' ,
                'programId' => 'merchant_ID' ,
                'code' => 'code' ,
                'updateDate' => 'update_date' ,
                'publishStartDate' => 'publish_start_date' ,
                'publishEndDate' => 'publish_end_date' ,
                'startDate' => 'start_date' ,
                'endDate' => 'end_date' ,
                'title' => 'name' ,
                'shortDescription' => 'short_description' ,
                'description' => 'description' ,
                'voucherTypeId' => 'deal_type' ,
                'defaultTrackUri' => 'default_track_uri' ,
                'landingUrl' => 'landing_url' ,
                'discountAmount' => 'discount_amount' ,
                'isPercentage' => 'is_percentage' ,
                'publisherInformation' => 'information' ,
                'languageId' => 'language' ,
                'exclusive' => 'is_exclusive' ,
                'siteSpecific' => 'is_site_specific' ,
                'currencyId' => 'currency_initial' ,
                'logoPath' => 'logo_path' ,
            ]);
            switch ($voucher['voucherTypeId']) {
                case 1:
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_VOUCHER;
                    break;
                case 2:
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_DISCOUNT;
                    break;
                case 3:
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_FREE_ARTICLE;
                    break;
                case 4:
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_FREE_SHIPPING;
                    break;
                case 5:
                    $Deal->deal_type = \Oara\Utilities::OFFER_TYPE_LOTTERY;
                    break;
            }

            if($merchantID > 0) {
                if($voucher['programId'] == $merchantID) {
                    $arrResult[] = $Deal;
                }
            }
            else {
                $arrResult[] = $Deal;
            }
        }
        $result->deals[]=$arrResult;
        return $result;
    }

    /**
     * @param \DateTime $dateFrom
     * @param \DateTime $dateTo
     * @param int $merchantID

There is no parameter named $merchantID. Did you maybe mean $arrMerchantID?

     * @return array of Transaction
     */
    public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array
    {
        if (!$this->checkLogin()) {
            return array();
        }
        $arrResult = array();
        if (count( $arrMerchantID ) < 1) {

This code seems to be duplicated across your project.

            $merchants = $this->getMerchants();
            foreach ($merchants as $merchant) {
                $arrMerchantID[$merchant->merchant_ID] = ['cid' => $merchant->merchant_ID, 'name' => $merchant->name];
            }
        }
        $transactionList = $this->_network->getTransactionList($arrMerchantID, $dateFrom, $dateTo);
        foreach($transactionList as $transaction) {
            $Transaction = Transaction::createInstance();
            $Transaction->merchant_ID = $transaction['merchantId'];
            $date = new \DateTime($transaction['date']);
            $Transaction->date = $date; // $date->format('Y-m-d H:i:s');

It seems like $date of type object<DateTime> is incompatible with the declared type string of property $date.

75% of this comment could be valid code. Did you maybe forget this after debugging?

            $Transaction->unique_ID = $transaction['unique_id'];
            $Transaction->transaction_ID = $transaction['unique_id'] . '-' . $transaction['event_id'];
            array_key_exists_safe( $transaction,
                'custom_id' ) ? $Transaction->custom_ID = $transaction['custom_id'] : $Transaction->custom_ID = '';
            $Transaction->status = $transaction['status'];
            $Transaction->amount = $transaction['amount'];
            $Transaction->commission = $transaction['commission'];
            $arrResult[] = $Transaction;
        }

        return $arrResult;
    }

    /**
     * @param \DateTime $dateFrom
     * @param \DateTime $dateTo
     * @param int $merchantID
     * @return array of Stat
     */
    public function getStats(\DateTime $dateFrom, \DateTime $dateTo, int $merchantID = 0) : array
    {
        return array();        
    }


    /**
     * @param  array $params
     *
     * @return ProductsResultset
     */
    public function getProducts(array $params = []): ProductsResultset
    {
        // TODO: Implement getProducts() method.
        throw new \Exception("Not implemented yet");
    }

    public function getTrackingParameter(){
        return $this->_tracking_parameter;
    }
}