Padosoft\AffiliateNetwork\EffiliationEx::getTransactionList()

Complexity

Conditions	8
Paths	61

Size

Total Lines	60
Code Lines	40

Duplication

Lines	7
Ratio	11.67 %

Importance

Changes	2
Bugs	1	Features	0

<?php
    public function getTransactionList($merchantList = null, \DateTime $dStartDate = null, \DateTime $dEndDate = null)
    {
        try {

            $totalTransactions = array();

            $merchantIdList = \Oara\Utilities::getMerchantIdMapFromMerchantList($merchantList);

            $url = 'http://api.effiliation.com/apiv2/transaction.csv?key=' . $this->_credentials["apiPassword"] . '&start=' . $dStartDate->format("d/m/Y") . '&end=' . $dEndDate->format("d/m/Y") . '&type=date&all=yes';

It seems like $dStartDate is not always an object, but can also be of type null. Maybe add an additional type check?

It seems like $dEndDate is not always an object, but can also be of type null. Maybe add an additional type check?

            // Set timeout to 300 secs. due to api delays - <PN> 2017-06-20
            $ctx = stream_context_create(array(
                    'http' => array(
                        'timeout' => 300
                    )
                )
            );
            // Log Debug info
            echo (New \DateTime())->format("d/m/Y H:i:s") . " - EffiliationEx getTransactionList from " . $dStartDate->format("d/m/Y") . " to " . $dEndDate->format("d/m/Y"),PHP_EOL;

            $content = \utf8_encode(\file_get_contents($url, 0, $ctx));
            $exportData = \str_getcsv($content, "\n");
            $num = \count($exportData);

            for ($i = 1; $i < $num; $i++) {
                $transactionExportArray = \str_getcsv($exportData[$i], "|");
                if (isset($merchantIdList[(int)$transactionExportArray[2]])) {

                    $transaction = Array();
                    $merchantId = (int)$transactionExportArray[2];
                    $transaction['merchantId'] = $merchantId;
                    $transaction['date'] = $transactionExportArray[10];
                    $transaction['unique_id'] = $transactionExportArray[0];
                    $transaction['custom_id'] = '';
                    $transaction['status'] = \Oara\Utilities::STATUS_PENDING;
                    if ($transactionExportArray[4] != null) {
                        $transaction['custom_id'] = $transactionExportArray[4];
                    }

                    if ($transactionExportArray[9] == 'Valide') {
                        $transaction['status'] = \Oara\Utilities::STATUS_CONFIRMED;
                    } else

This code seems to be duplicated across your project.

                        if ($transactionExportArray[9] == 'Attente') {
                            $transaction['status'] = \Oara\Utilities::STATUS_PENDING;
                        } else
                            if ($transactionExportArray[9] == 'Refusé') {
                                $transaction['status'] = \Oara\Utilities::STATUS_DECLINED;
                            }
                    $transaction['amount'] = \Oara\Utilities::parseDouble($transactionExportArray[7]);
                    $transaction['commission'] = \Oara\Utilities::parseDouble($transactionExportArray[8]);
                    $totalTransactions[] = $transaction;
                }
            }
        } catch (\Exception $e) {
            // Avoid lost of transactions if one date failed - <PN> - 2017-06-20
            echo PHP_EOL."EffiliationEx - getTransactionList err: ".$e->getMessage().PHP_EOL;
            throw new \Exception($e);
        }
        echo (New \DateTime())->format("d/m/Y H:i:s") . " - EffiliationEx getTransactionList - return " . count($totalTransactions) . " transactions",PHP_EOL;
        return $totalTransactions;
    }
}