Padosoft\AffiliateNetwork\TradeDoublerEx

Complexity

Total Complexity

35

Size/Duplication

Total Lines	215
Duplicated Lines	26.05 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
F	getTransactionList()	47	67	18
F	getTransactionListByDateType()	9	144	17

<?php
/**
 * Copyright (c) Padosoft.com 2017.
 */
namespace Padosoft\AffiliateNetwork;

use Oara\Network\Publisher\TradeDoublerWhitelabel;

class TradeDoublerEx extends TradeDoublerWhitelabel
{
    public function getTransactionList($merchantList = null, \DateTime $dStartDate = null, \DateTime $dEndDate = null)
    {
        $updateTransactions = Array();

$updateTransactions is not used, you could remove the assignment.

        $totalTransactions = Array();

        if (isset($_ENV['TRADEDOUBLER_CURRENCY'])) {
            $currency = $_ENV['TRADEDOUBLER_CURRENCY'];
        }
        else {
            $currency = 'EUR';
        }

        // Get updated transactions in date range
        $updatedTransactions = self::getTransactionListByDateType($merchantList, $dStartDate, $dEndDate, true, $currency);
        // Get new transactions in date range
        $insertedTransactions= self::getTransactionListByDateType($merchantList, $dStartDate, $dEndDate, false, $currency);

        $parsedIDs=[];

$parsedIDs is not used, you could remove the assignment.

        foreach ($insertedTransactions as $transaction){

This code seems to be duplicated across your project.

            if (array_key_exists('unique_id', $transaction)){
                $found=false;
                for ($i=0;$i<count($totalTransactions);$i++){

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                    // Check also event_id to obtain a real unique key - <PN> - 2017-07-03
                    if ($totalTransactions[$i]['unique_id']==$transaction['unique_id'] && $totalTransactions[$i]['event_id']==$transaction['event_id']){
                        if ($totalTransactions[$i]['commission']<=0){
                            $totalTransactions[$i] = $transaction;
                            $found=true;
                            break;
                        }
                        if ($totalTransactions[$i]['status']==\Oara\Utilities::STATUS_DECLINED){
                            $totalTransactions[$i] = $transaction;
                            $found=true;
                            break;
                        }
                    }
                }
                if (!$found){
                    $totalTransactions[] = $transaction;
                }
            }
        }
        foreach ($updatedTransactions as $transaction){

This code seems to be duplicated across your project.

            if (array_key_exists('unique_id',$transaction)){
                $found=false;
                for ($i=0;$i<count($totalTransactions);$i++){

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                    // Check also event_id to obtain a real unique key - <PN> - 2017-07-03
                    if ($totalTransactions[$i]['unique_id']==$transaction['unique_id'] && $totalTransactions[$i]['event_id']==$transaction['event_id']){
                        if ($totalTransactions[$i]['commission']<=0){
                            $totalTransactions[$i]=$transaction;
                            $found=true;
                            break;
                        }
                        if ($totalTransactions[$i]['status']==\Oara\Utilities::STATUS_DECLINED){
                            $totalTransactions[$i]=$transaction;
                            $found=true;
                            break;
                        }

                    }
                }
                if (!$found){
                    $totalTransactions[]=$transaction;
                }
            }
        }
        return $totalTransactions;
    }

    public function getTransactionListByDateType($merchantList = null, \DateTime $dStartDate = null, \DateTime $dEndDate = null, bool $byDateUpdated = false, $currency = null)

The parameter $merchantList is not used and could be removed.

    {
        $transactions = Array();

        $valuesFormExport = array(new \Oara\Curl\Parameter('reportName', 'aAffiliateEventBreakdownReport'),
            new \Oara\Curl\Parameter('columns', 'programId'),
            new \Oara\Curl\Parameter('columns', 'timeOfVisit'),
            new \Oara\Curl\Parameter('columns', 'timeOfEvent'),
            new \Oara\Curl\Parameter('columns', 'timeInSession'),
            new \Oara\Curl\Parameter('columns', 'lastModified'),
            new \Oara\Curl\Parameter('columns', 'epi1'),
            new \Oara\Curl\Parameter('columns', 'eventName'),
            new \Oara\Curl\Parameter('columns', 'pendingStatus'),
            new \Oara\Curl\Parameter('columns', 'siteName'),
            new \Oara\Curl\Parameter('columns', 'graphicalElementName'),
            new \Oara\Curl\Parameter('columns', 'graphicalElementId'),
            new \Oara\Curl\Parameter('columns', 'productName'),
            new \Oara\Curl\Parameter('columns', 'productNrOf'),
            new \Oara\Curl\Parameter('columns', 'productValue'),
            new \Oara\Curl\Parameter('columns', 'affiliateCommission'),
            new \Oara\Curl\Parameter('columns', 'link'),
            new \Oara\Curl\Parameter('columns', 'leadNR'),
            new \Oara\Curl\Parameter('columns', 'orderNR'),
            new \Oara\Curl\Parameter('columns', 'pendingReason'),
            new \Oara\Curl\Parameter('columns', 'orderValue'),
            new \Oara\Curl\Parameter('columns', 'eventId'),           // Added <PN> 2017-07-03
            new \Oara\Curl\Parameter('isPostBack', ''),
            new \Oara\Curl\Parameter('metric1.lastOperator', '/'),
            new \Oara\Curl\Parameter('interval', ''),
            new \Oara\Curl\Parameter('favoriteDescription', ''),
            new \Oara\Curl\Parameter('event_id', '0'),
            new \Oara\Curl\Parameter('pending_status', '1'),
            new \Oara\Curl\Parameter('run_as_organization_id', ''),
            new \Oara\Curl\Parameter('minRelativeIntervalStartTime', '0'),
            new \Oara\Curl\Parameter('includeWarningColumn', 'true'),
            new \Oara\Curl\Parameter('metric1.summaryType', 'NONE'),
            new \Oara\Curl\Parameter('metric1.operator1', '/'),
            new \Oara\Curl\Parameter('latestDayToExecute', '0'),
            new \Oara\Curl\Parameter('showAdvanced', 'true'),
            new \Oara\Curl\Parameter('currencyId', $currency),              // Added <PN> 2018-03-26
            new \Oara\Curl\Parameter('breakdownOption', '1'),
            new \Oara\Curl\Parameter('metric1.midFactor', ''),
            new \Oara\Curl\Parameter('reportTitleTextKey', 'REPORT3_SERVICE_REPORTS_AAFFILIATEEVENTBREAKDOWNREPORT_TITLE'),
            new \Oara\Curl\Parameter('setColumns', 'true'),
            new \Oara\Curl\Parameter('metric1.columnName1', 'orderValue'),
            new \Oara\Curl\Parameter('metric1.columnName2', 'orderValue'),
            new \Oara\Curl\Parameter('reportPrograms', ''),
            new \Oara\Curl\Parameter('metric1.midOperator', '/'),
            new \Oara\Curl\Parameter('dateSelectionType', $byDateUpdated ? '2' : '1'),    // Retrieve transactions by Date Event (default = 1) or by Date Last Updated (2)
            new \Oara\Curl\Parameter('favoriteName', ''),
            new \Oara\Curl\Parameter('dateType', '1'),
            new \Oara\Curl\Parameter('period', 'custom_period'),
            new \Oara\Curl\Parameter('tabMenuName', ''),
            new \Oara\Curl\Parameter('maxIntervalSize', '0'),
            new \Oara\Curl\Parameter('favoriteId', ''),
            new \Oara\Curl\Parameter('sortBy', 'timeOfEvent'),
            new \Oara\Curl\Parameter('metric1.name', ''),
            new \Oara\Curl\Parameter('customKeyMetricCount', '0'),
            new \Oara\Curl\Parameter('metric1.factor', ''),
            new \Oara\Curl\Parameter('showFavorite', 'false'),
            new \Oara\Curl\Parameter('separator', ','),
            new \Oara\Curl\Parameter('format', 'CSV')
        );
        $valuesFormExport[] = new \Oara\Curl\Parameter('startDate', self::formatDate($dStartDate));
        $valuesFormExport[] = new \Oara\Curl\Parameter('endDate', self::formatDate($dEndDate));
        if (!empty($this->_credentials['idSite'])){
            $valuesFormExport[] = new \Oara\Curl\Parameter('affiliateId', $this->_credentials['idSite']);

The property _credentials does not exist. Did you maybe forget to declare it?

        }
        else{
            $valuesFormExport[] = new \Oara\Curl\Parameter('affiliateId', '');
        }
        $urls = array();
        $urls[] = new \Oara\Curl\Request('http://publisher.tradedoubler.com/pan/aReport3Internal.action?', $valuesFormExport);
        $exportReport = $this->_client->get($urls);

        $exportReport[0] = self::checkReportError($exportReport[0], $urls[0]);
        $exportData = \str_getcsv($exportReport[0], "\r\n");
        $num = \count($exportData);
        for ($i = 2; $i < $num - 1; $i++) {

            try {
                $transactionExportArray = \str_getcsv($exportData[$i], ",");

                if (!isset($transactionExportArray[2])) {
                    throw new \Exception('Problem getting transaction\n\n');
                }
                if (\count($this->_sitesAllowed) == 0 || \in_array($transactionExportArray[13], $this->_sitesAllowed)) {

                    if (!empty(trim($transactionExportArray[7] . $transactionExportArray[8]))) {
                        // Skip rows without a unique_id
                        $transaction = Array();
                        $transaction['merchantId'] = $transactionExportArray[2];
                        $transactionDate = self::toDate(\substr($transactionExportArray[4], 0, -6));
                        if ($transactionDate === false) {
                            // Bad date ... skip
                            $transaction['date'] = '';
                        }
                        else {
                            $transaction['date'] = $transactionDate->format("Y-m-d H:i:s");
                        }
                        if ($transactionExportArray[8] != '') {
                            $transaction['unique_id'] = \substr($transactionExportArray[8], 0, 200);
                        } else
                            if ($transactionExportArray[7] != '') {
                                $transaction['unique_id'] = \substr($transactionExportArray[7], 0, 200);
                            } else {
                                throw new \Exception("No Identifier");
                            }


                        if ($transactionExportArray[9] != '') {
                            $transaction['custom_id'] = $transactionExportArray[9];
                        }

                        $transaction['status'] = \Oara\Utilities::STATUS_PENDING;
                        if ($transactionExportArray[12] == 'A') {

This code seems to be duplicated across your project.

                            $transaction['status'] = \Oara\Utilities::STATUS_CONFIRMED;
                        } else
                            if ($transactionExportArray[12] == 'P') {
                                $transaction['status'] = \Oara\Utilities::STATUS_PENDING;
                            } else
                                if ($transactionExportArray[12] == 'D') {
                                    $transaction['status'] = \Oara\Utilities::STATUS_DECLINED;
                                }

                        if ($transactionExportArray[20] != '') {
                            $transaction['amount'] = \Oara\Utilities::parseDouble($transactionExportArray[20]);
                        } else {
                            $transaction['amount'] = \Oara\Utilities::parseDouble($transactionExportArray[21]);
                        }

                        $transaction['commission'] = \Oara\Utilities::parseDouble($transactionExportArray[21]);
                        $transaction['event_id'] = $transactionExportArray[11];
                        $transaction['currency'] = $currency;
                        $transactions[] = $transaction;
                    }
                }
            }
            catch (\Exception $e) {
                echo PHP_EOL."TradeDoublerEx - getTransactionList err: ".$e->getMessage().PHP_EOL;
            }
        }
        return $transactions;
    }
}