Padosoft\AffiliateNetwork\Networks\Partnerize

Complexity

Total Complexity

20

Size/Duplication

Total Lines	161
Duplicated Lines	36.02 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	checkLogin()	0	4	1
A	getMerchants()	16	16	3
A	getDeals()	0	5	1
A	getStats()	0	4	1
A	getProducts()	0	5	1
A	getTrackingParameter()	0	3	1
B	getSales()	42	42	7
A	login()	0	19	4
A	__construct()	0	8	1

<?php

namespace Padosoft\AffiliateNetwork\Networks;

use Padosoft\AffiliateNetwork\Transaction;
use Padosoft\AffiliateNetwork\DealsResultset;
use Padosoft\AffiliateNetwork\Merchant;
use Padosoft\AffiliateNetwork\Stat;
use Padosoft\AffiliateNetwork\Deal;
use Padosoft\AffiliateNetwork\AbstractNetwork;
use Padosoft\AffiliateNetwork\NetworkInterface;
use Padosoft\AffiliateNetwork\AffiliateWindowEx;
use Padosoft\AffiliateNetwork\ProductsResultset;

/**
 * Class Partnerize
 * @package Padosoft\AffiliateNetwork\Networks
 */
class Partnerize extends AbstractNetwork implements NetworkInterface
{
    /**
     * @var object
     */
    private $_network = null;
    private $_apiClient = null;
    private $_username = '';
    private $_password = '';
    private $_logged    = false;
    protected $_tracking_parameter    = 'pubref';

    /**
     * @method __construct
     */
    public function __construct(string $username, string $password)
    {
        $this->_network = new \Oara\Network\Publisher\PerformanceHorizon();
        $this->_username = $username;
        $this->_password = $password;
        $this->_apiClient = null;
        $this->login( $this->_username, $this->_password );
    }

    public function login(string $username, string $password): bool
    {
        $this->_logged = false;
        if (isNullOrEmpty( $username ) || isNullOrEmpty( $password )) {
            return false;
        }
        $this->_username = $username;
        $this->_password = $password;
        $credentials = array();
        $credentials["accountid"] = $this->_username;
        $credentials["apipassword"] = $this->_password;
        $this->_network->login( $credentials );
        if ($this->_network->checkConnection()) {
            $this->_logged = true;

        }

        return $this->_logged;
    }

    /**
     * @return bool
     */
    public function checkLogin() : bool
    {
        return $this->_logged;
    }

    /**
     * @return array of Merchants
     */
    public function getMerchants() : array

This method seems to be duplicated in your project.

    {
        if (!$this->checkLogin()) {
            return array();
        }
        $arrResult = array();
        $merchantList = $this->_network->getMerchantList();
        foreach($merchantList as $merchant) {
            $Merchant = Merchant::createInstance();
            $Merchant->merchant_ID = $merchant['cid'];
            $Merchant->name = $merchant['name'];
            $Merchant->status = $merchant['status'];
            $arrResult[] = $Merchant;
        }
        return $arrResult;
    }

    /**
     * @param int|null $merchantID
     * @param int $page
     * @param int $items_per_page
     *
     * @return DealsResultset
     */
    public function getDeals($merchantID,int $page=0,int $items_per_page=10) : DealsResultset
    {
        // TODO: Implement getDeals() method.
        throw new \Exception("Not implemented yet");
    }

    /**
     * @param \DateTime $dateFrom
     * @param \DateTime $dateTo
     * @param int $merchantID

There is no parameter named $merchantID. Did you maybe mean $arrMerchantID?

     * @return array of Transaction
     */
    public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

This method seems to be duplicated in your project.

    {
        $arrResult = array();

        try {
            // Added timezone parameter
            $transactionList = $this->_network->getTransactionList($arrMerchantID, $dateFrom, $dateTo, 'UTC');

            if (is_array($transactionList)) {
                foreach ($transactionList as $transaction) {
                    try {

                        $myTransaction = Transaction::createInstance();

                        $myTransaction->merchant_ID = $transaction['merchantId'];
                        $myTransaction->date = $transaction['date'];
                        if (!empty($transaction['date'])) {
                            $date = new \DateTime($transaction['date'], new \DateTimeZone('UTC'));
                            $myTransaction->date = $date;

It seems like $date of type object<DateTime> is incompatible with the declared type string of property $date.

                        }
                        $myTransaction->unique_ID = $transaction['unique_id'];
                        if (isset($transaction['custom_id'])) {
                            $myTransaction->custom_ID = $transaction['custom_id'];
                        }
                        $myTransaction->status = $transaction['status'];
                        $myTransaction->amount = \Oara\Utilities::parseDouble($transaction['amount']);

It seems like \Oara\Utilities::parseDouble($transaction['amount']) of type string or integer is incompatible with the declared type double of property $amount.

                        $myTransaction->commission = \Oara\Utilities::parseDouble($transaction['commission']);

It seems like \Oara\Utilities::parseDouble($transaction['commission']) of type string or integer is incompatible with the declared type double of property $commission.

                        $myTransaction->currency = $transaction['currency'];
                        $arrResult[] = $myTransaction;
                    } catch (\Exception $e) {
                        echo "<br><br>Transaction Error Partnerize, id: " . $myTransaction['unique_id'] . " msg: ".$e->getMessage()."<br><br>";
                        var_dump($e->getTraceAsString());

var_dump($e->getTraceAsString()); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

                    }
                }
            }
        } catch (\Exception $e) {
            echo "<br><br>Generic Error Partnerize: ".$e->getMessage()."<br><br>";
            var_dump($e->getTraceAsString());
            throw new \Exception($e);
        }
        return $arrResult;
    }

    /**
     * @param \DateTime $dateFrom
     * @param \DateTime $dateTo
     * @param int $merchantID
     * @return array of Stat
     */
    public function getStats(\DateTime $dateFrom, \DateTime $dateTo, int $merchantID = 0) : array
    {
        return array();        
    }


    /**
     * @param  array $params
     *
     * @return ProductsResultset
     */
    public function getProducts(array $params = []): ProductsResultset
    {
        // TODO: Implement getProducts() method.
        throw new \Exception("Not implemented yet");
    }

    public function getTrackingParameter(){
        return $this->_tracking_parameter;
    }
}