Padosoft\AffiliateNetwork\Networks\Belboon

Complexity

Total Complexity

20

Size/Duplication

Total Lines	188
Duplicated Lines	8.51 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	checkLogin()	0	4	1
A	getMerchants()	16	16	3
A	getDeals()	0	41	3
D	getSales()	0	48	9
A	getStats()	0	17	1
A	getProducts()	0	5	1
A	getTrackingParameter()	0	4	1

<?php

namespace Padosoft\AffiliateNetwork\Networks;

use Padosoft\AffiliateNetwork\Deal;
use Padosoft\AffiliateNetwork\Stat;
use Padosoft\AffiliateNetwork\Merchant;
use Padosoft\AffiliateNetwork\Transaction;
use Padosoft\AffiliateNetwork\DealsResultset;
use Padosoft\AffiliateNetwork\AbstractNetwork;
use Padosoft\AffiliateNetwork\NetworkInterface;
use Padosoft\AffiliateNetwork\ProductsResultset;

/**
 * Class Belboon
 * @package Padosoft\AffiliateNetwork\Networks
 */
class Belboon extends AbstractNetwork implements NetworkInterface
{
    /**
     * @var object
     */
    private $_network = null;
    protected $_tracking_parameter    = 'scm1';

    /**
     * @method __construct
     */
    public function __construct(string $username, string $password, string $idSite='')

The parameter $idSite is not used and could be removed.

    {
        $apiKey = $_ENV["BELBOON_API_KEY"];
        $userId = $_ENV["BELBOON_USER_ID"];
        $this->_network = new \Oara\Network\Publisher\Belboon($apiKey, $userId);
    }

    /**
     * @return bool
     */
    public function checkLogin() : bool
    {
        return true;
    }

    /**
     * @return array of Merchants
     */
    public function getMerchants() : array

This method seems to be duplicated in your project.

    {
        if (!$this->checkLogin()) {
            return array();
        }
        $arrResult = array();
        $merchantList = $this->_network->getMerchantList();
        foreach ($merchantList as $merchant) {
            $Merchant = Merchant::createInstance();
            $Merchant->merchant_ID = $merchant['cid'];
            $Merchant->name = $merchant['name'];
            $arrResult[] = $Merchant;
        }

        return $arrResult;
    }

    /**
     * @param int $merchantID
     * @return array of Deal
     */
    public function getDeals($merchantID=null, int $page=0, int $items_per_page=10): DealsResultset
    {
        $dealList = $this->_network->getVouchers();

        // only the type voucher is imported
        // possible types:
        // discount_all, discount_single, free_ship, freebie, misc, ''
        $onlyVouchersDeals = array_filter(
            $dealList,
            function ($deal) {
                // the deal types can be multiple...
                $dealTypes = $deal["voucher_type"];
                $isDiscountAll = strpos($dealTypes, 'discount_all') != false;

It seems like you are loosely comparing strpos($dealTypes, 'discount_all') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

                $isDiscountSingle = strpos($dealTypes, 'discount_single') != false;

It seems like you are loosely comparing strpos($dealTypes, 'discount_single') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

                $isEmpty = $dealTypes == '';

                return $isDiscountAll || $isDiscountSingle || $isEmpty;
            }
        );

        $result = DealsResultset::createInstance();

        $deals = array_map(function ($rawDeal) {
            $deal = new Deal();
            $deal->deal_ID = $rawDeal["vcid"];
            $deal->merchant_ID = $rawDeal["mid"];
            $deal->code = $rawDeal["codes"];
            $deal->description = $rawDeal["description"];
            $deal->start_date = $deal->convertDate($rawDeal["date_from"]);

It seems like $deal->convertDate($rawDeal['date_from']) can also be of type false. However, the property $start_date is declared as type object<DateTime>. Maybe add an additional type check?

            $deal->end_date = $deal->convertDate($rawDeal["date_to"]);

It seems like $deal->convertDate($rawDeal['date_to']) can also be of type false. However, the property $end_date is declared as type object<DateTime>. Maybe add an additional type check?

            $deal->landing_url = $rawDeal["landingpage"];
            $deal->discount_amount = $rawDeal["discount_amount"];
            $deal->minimum_order_value = $rawDeal["min_order_value"];
            $deal->deal_type = \Oara\Utilities::OFFER_TYPE_VOUCHER;
            return $deal;
        }, $onlyVouchersDeals);

        $result->deals[] = $deals;

        return $result;
    }

    /**
     * @param \DateTime $dateFrom
     * @param \DateTime $dateTo
     * @param int $merchantID

There is no parameter named $merchantID. Did you maybe mean $arrMerchantID?

     * @return array of Transaction
     */
    public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array
    {
        $arrResult = array();
        try {
            $transactionList = $this->_network->getTransactionList(null, $dateFrom, $dateTo);

            foreach ($transactionList as $transaction) {
                $myTransaction = Transaction::createInstance();
                try {
                    $myTransaction->merchant_ID = $transaction['merchantId'];
                    $myTransaction->title ='';
                    $myTransaction->currency ='EUR';
                    if (!empty($transaction['date'])) {
                        $date = new \DateTime($transaction['date']);
                        $myTransaction->date = $date; // $date->format('Y-m-d H:i:s');

It seems like $date of type object<DateTime> is incompatible with the declared type string of property $date.

                    }
                    if (!empty($transaction['click_date'])) {
                        $date = new \DateTime($transaction['click_date']);
                        $myTransaction->click_date = $date; // $date->format('Y-m-d H:i:s');

It seems like $date of type object<DateTime> is incompatible with the declared type string of property $click_date.

                    }
                    if (!empty($transaction['lastchangedate'])) {
                        $date = new \DateTime($transaction['lastchangedate']);
                        $myTransaction->update_date = $date;

It seems like $date of type object<DateTime> is incompatible with the declared type string of property $update_date.

                    }
                    $myTransaction->unique_ID = $transaction['unique_id'];
                    $myTransaction->custom_ID = array_key_exists('custom_id', $transaction) ? $transaction['custom_id'] : '';
                    $myTransaction->status = $transaction['status'];
                    $myTransaction->amount = $transaction['amount'];
                    $myTransaction->commission = $transaction['commission'];

                    $myTransaction->approved = false;
                    if ($transaction['status'] == \Oara\Utilities::STATUS_CONFIRMED) {
                        $myTransaction->approved = true;
                    }
                    $arrResult[] = $myTransaction;
                } catch (\Exception $e) {
                    echo "<br><br>errore transazione Belboon, id: ".$myTransaction->unique_ID." msg: ".$e->getMessage()."<br><br>";
                    var_dump($e->getTraceAsString());

var_dump($e->getTraceAsString()); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

                }
            }
        } catch (\Exception $e) {
            echo "<br><br>errore generico transazione Belboon: ".$e->getMessage()."<br><br>";
            var_dump($e->getTraceAsString());
            throw new \Exception($e);
        }

        return $arrResult;
    }

    /**
     * @param \DateTime $dateFrom
     * @param \DateTime $dateTo
     * @param int $merchantID
     * @return array of Stat
     */
    public function getStats(\DateTime $dateFrom, \DateTime $dateTo, int $merchantID = 0) : array
    {
        return array();
        /*
        $this->_apiClient->setConnectId($this->_username);
        $this->_apiClient->setSecretKey($this->_password);
        $dateFromIsoEngFormat = $dateFrom->format('Y-m-d');
        $dateToIsoEngFormat = $dateTo->format('Y-m-d');
        $response = $this->_apiClient->getReportBasic($dateFromIsoEngFormat, $dateToIsoEngFormat);
        $arrResponse = json_decode($response, true);
        $reportItems = $arrResponse['reportItems'];
        $Stat = Stat::createInstance();
        $Stat->reportItems = $reportItems;

        return array($Stat);
        */
    }


    /**
     * @param  array $params
     *
     * @return ProductsResultset
     */
    public function getProducts(array $params = []): ProductsResultset
    {
        // TODO: Implement getProducts() method.
        throw new \Exception("Not implemented yet");
    }

    public function getTrackingParameter()
    {
        return $this->_tracking_parameter;
    }
}