Admitad - Code Metrics - padosoft/laravel-affiliate-network - Measure and Improve Code Quality continuously with Scrutinizer

Admitad A
last analyzed 2021-06-03 10:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	209
Duplicated Lines	18.66 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
wmc	26
lcom	1
cbo	6
dl	39
loc	209
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	login()	0	20	4
A	checkLogin()	0	4	1
A	__construct()	0	9	1
A	getDeals()	0	33	4
B	getSales()	39	39	10
A	getStats()	0	18	1
A	getProducts()	0	5	1
A	getTrackingParameter()	0	3	1
A	getMerchants()	0	18	3

How to fix Duplicated Code

<?php

namespace Padosoft\AffiliateNetwork\Networks;

use Padosoft\AffiliateNetwork\Transaction;
use Padosoft\AffiliateNetwork\DealsResultset;
use Padosoft\AffiliateNetwork\Merchant;
use Padosoft\AffiliateNetwork\Stat;
use Padosoft\AffiliateNetwork\Deal;
use Padosoft\AffiliateNetwork\AbstractNetwork;
use Padosoft\AffiliateNetwork\NetworkInterface;
use Padosoft\AffiliateNetwork\ProductsResultset;

/**
 * Class Admitad
 * @package Padosoft\AffiliateNetwork\Networks
 */
class Admitad extends AbstractNetwork implements NetworkInterface
{
    /**
     * @var object
     */
    private $_network = null;
    private $_username = '';
    private $_password = '';
    private $_apiClient = null;
    protected $_tracking_parameter    = '';
    private $_idSite = '';

    /**
     * @method __construct
     */
    public function __construct(string $username, string $password, string $idSite='')
    {
        $this->_network = new \Oara\Network\Publisher\Admitad;
        $this->_username = $username;
        $this->_password = $password;
        $this->_idSite = $idSite;

        $this->login( $this->_username, $this->_password, $idSite );
    }

    public function login(string $username, string $password,string $idSite=''): bool{
        $this->_logged = false;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        if (isNullOrEmpty( $username ) || isNullOrEmpty( $password )) {

            return false;
        }
        $this->_username = $username;
        $this->_password = $password;
        $this->_idSite = $idSite;
        $credentials = array();
        $credentials["user"] = $this->_username;
        $credentials["password"] = $this->_password;
        $credentials["idSite"] = $this->_idSite;
        $this->_network->login($credentials);
        if ($this->_network->checkConnection()) {
            $this->_logged = true;
        }

        return $this->_logged;
    }

    /**
     * @return bool
     */
    public function checkLogin() : bool
    {
        return $this->_logged;
    }

    /**
	 * @return array of Merchants
	 * @throws \Exception
	 */
    public function getMerchants() : array
    {
        $arrResult = array();
        $merchantList = $this->_network->getMerchantList();
        foreach($merchantList as $merchant) {
            $Merchant = Merchant::createInstance();
            $Merchant->merchant_ID = $merchant['cid'];
            $Merchant->name = $merchant['name'];
            $Merchant->status = $merchant['status'];
            $Merchant->url = $merchant['url'];
            if (!empty($merchant['launch_date'])) {
                $date = new \DateTime($merchant['launch_date']);
                $Merchant->launch_date = $date;

            }
            $arrResult[] = $Merchant;
        }
        return $arrResult;
    }

    /**
	 * @param null $merchantID
	 * @param int $page
	 * @param int $items_per_page
	 * @return DealsResultset  array of Deal
	 * @throws \Exception
	 */
    public function getDeals($merchantID=NULL,int $page=0,int $items_per_page=100 ): DealsResultset
    {
        $arrResult = array();

        $result = DealsResultset::createInstance();

        $arrVouchers = $this->_network->getVouchers($this->_idSite);

        foreach($arrVouchers as $voucher) {
            if (!empty($voucher['tracking']) && !empty($voucher['advertiser_id'])) {
                $Deal = Deal::createInstance();
                $Deal->deal_ID = md5($voucher['tracking']);    // Use link to generate a unique deal ID
$answer = 42;

$correct = false;

$correct = (bool) $answer;
                $Deal->merchant_ID = $voucher['advertiser_id'];
                $Deal->merchant_name = $voucher['advertiser_name'];
                $Deal->code = $voucher['code'];
                $Deal->name = $voucher['name'];
                $Deal->description = $voucher['description'];
                $Deal->start_date = $Deal->convertDate($voucher['start_date']);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                $Deal->end_date = $Deal->convertDate($voucher['end_date']);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                $Deal->default_track_uri = $voucher['tracking'];
                $Deal->discount_amount = $voucher['discount_amount'];
                $Deal->is_percentage = $voucher['is_percentage'];
                $Deal->is_exclusive = false;
                $Deal->deal_type = $voucher['type'];
                $arrResult[] = $Deal;
            }
        }

        $result->deals[]=$arrResult;

        return $result;

    }

   	/**
	 * @param \DateTime $dateFrom
	 * @param \DateTime $dateTo
	 * @param array $arrMerchantID
	 * @return array of Transaction
	 * @throws \Exception
	 */
    public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

    {

        $arrResult = array();
        $transactionList = $this->_network->getTransactionList($arrMerchantID, $dateFrom, $dateTo);
        foreach($transactionList as $transaction) {
            $Transaction = Transaction::createInstance();
            if (isset($transaction['currency']) && !empty($transaction['currency'])) {
                $Transaction->currency = $transaction['currency'];
            } else {
                $Transaction->currency = "EUR";
            }
            $Transaction->status = $transaction['status'];
            $Transaction->amount = $transaction['amount'];
            array_key_exists_safe( $transaction,'custom_id' ) ? $Transaction->custom_ID = $transaction['custom_id'] : $Transaction->custom_ID = '';
            $Transaction->title = '';
            $Transaction->unique_ID = $transaction['unique_id'];
            $Transaction->commission = $transaction['commission'];
            $date = new \DateTime($transaction['date']);
            $Transaction->date = $date; // $date->format('Y-m-d H:i:s');

            // Future use - Only few providers returns these dates values - <PN> - 2017-06-29
            if (isset($transaction['click_date']) && !empty($transaction['click_date'])) {
                $Transaction->click_date = new \DateTime($transaction['click_date']);

            }
            if (isset($transaction['update_date']) && !empty($transaction['update_date'])) {
                $Transaction->update_date = new \DateTime($transaction['update_date']);

            }
            $Transaction->merchant_ID = $transaction['merchantId'];
            $Transaction->campaign_name =  $transaction['merchantName'];
            $Transaction->IP =  $transaction['IP'];
            $Transaction->approved = false;
            if ($Transaction->status == \Oara\Utilities::STATUS_CONFIRMED){
                $Transaction->approved = true;
            }
            $arrResult[] = $Transaction;
        }

        return $arrResult;
    }

    /**
     * @param \DateTime $dateFrom
     * @param \DateTime $dateTo
     * @param int $merchantID
     * @return array of Stat
     */
    public function getStats(\DateTime $dateFrom, \DateTime $dateTo, int $merchantID = 0) : array
    {
        // TODO
        return array();
        /*
        $this->_apiClient->setConnectId($this->_username);
        $this->_apiClient->setSecretKey($this->_password);
        $dateFromIsoEngFormat = $dateFrom->format('Y-m-d');
        $dateToIsoEngFormat = $dateTo->format('Y-m-d');
        $response = $this->_apiClient->getReportBasic($dateFromIsoEngFormat, $dateToIsoEngFormat);
        $arrResponse = json_decode($response, true);
        $reportItems = $arrResponse['reportItems'];
        $Stat = Stat::createInstance();
        $Stat->reportItems = $reportItems;

        return array($Stat);
        */
    }


    /**
	 * @param array $params
	 * @return ProductsResultset
	 * @throws \Exception
	 */
    public function getProducts(array $params = []): ProductsResultset
    {
        // TODO: Implement getProducts() method.
        throw new \Exception("Not implemented yet");
    }

    public function getTrackingParameter(){
        return $this->_tracking_parameter;
    }



}


1		<?php
2
3		namespace Padosoft\AffiliateNetwork\Networks;
4
5		use Padosoft\AffiliateNetwork\Transaction;
6		use Padosoft\AffiliateNetwork\DealsResultset;
7		use Padosoft\AffiliateNetwork\Merchant;
8		use Padosoft\AffiliateNetwork\Stat;
9		use Padosoft\AffiliateNetwork\Deal;
10		use Padosoft\AffiliateNetwork\AbstractNetwork;
11		use Padosoft\AffiliateNetwork\NetworkInterface;
12		use Padosoft\AffiliateNetwork\ProductsResultset;
13
14		/**
15		* Class Admitad
16		* @package Padosoft\AffiliateNetwork\Networks
17		*/
18		class Admitad extends AbstractNetwork implements NetworkInterface
19		{
20		/**
21		* @var object
22		*/
23		private $_network = null;
24		private $_username = '';
25		private $_password = '';
26		private $_apiClient = null;
27		protected $_tracking_parameter = '';
28		private $_idSite = '';
29
30		/**
31		* @method __construct
32		*/
33		public function __construct(string $username, string $password, string $idSite='')
34		{
35		$this->_network = new \Oara\Network\Publisher\Admitad;
36		$this->_username = $username;
37		$this->_password = $password;
38		$this->_idSite = $idSite;
39
40		$this->login( $this->_username, $this->_password, $idSite );
41		}
42
43		public function login(string $username, string $password,string $idSite=''): bool{
44		$this->_logged = false;
		0 ignored issues – show Bug introduced 2017-06-29 08:17 UTC by Report Bug Copy Issue Report The property `_logged` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
45		if (isNullOrEmpty( $username ) \|\| isNullOrEmpty( $password )) {
46
47		return false;
48		}
49		$this->_username = $username;
50		$this->_password = $password;
51		$this->_idSite = $idSite;
52		$credentials = array();
53		$credentials["user"] = $this->_username;
54		$credentials["password"] = $this->_password;
55		$credentials["idSite"] = $this->_idSite;
56		$this->_network->login($credentials);
57		if ($this->_network->checkConnection()) {
58		$this->_logged = true;
59		}
60
61		return $this->_logged;
62		}
63
64		/**
65		* @return bool
66		*/
67		public function checkLogin() : bool
68		{
69		return $this->_logged;
70		}
71
72		/**
73		* @return array of Merchants
74		* @throws \Exception
75		*/
76		public function getMerchants() : array
77		{
78		$arrResult = array();
79		$merchantList = $this->_network->getMerchantList();
80		foreach($merchantList as $merchant) {
81		$Merchant = Merchant::createInstance();
82		$Merchant->merchant_ID = $merchant['cid'];
83		$Merchant->name = $merchant['name'];
84		$Merchant->status = $merchant['status'];
85		$Merchant->url = $merchant['url'];
86		if (!empty($merchant['launch_date'])) {
87		$date = new \DateTime($merchant['launch_date']);
88		$Merchant->launch_date = $date;
		0 ignored issues – show Documentation Bug introduced 2019-10-10 09:53 UTC by Report Bug Copy Issue Report It seems like `$date` of type `object<DateTime>` is incompatible with the declared type `string` of property `$launch_date`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
89		}
90		$arrResult[] = $Merchant;
91		}
92		return $arrResult;
93		}
94
95		/**
96		* @param null $merchantID
97		* @param int $page
98		* @param int $items_per_page
99		* @return DealsResultset array of Deal
100		* @throws \Exception
101		*/
102		public function getDeals($merchantID=NULL,int $page=0,int $items_per_page=100 ): DealsResultset
103		{
104		$arrResult = array();
105
106		$result = DealsResultset::createInstance();
107
108		$arrVouchers = $this->_network->getVouchers($this->_idSite);
109
110		foreach($arrVouchers as $voucher) {
111		if (!empty($voucher['tracking']) && !empty($voucher['advertiser_id'])) {
112		$Deal = Deal::createInstance();
113		$Deal->deal_ID = md5($voucher['tracking']); // Use link to generate a unique deal ID
		0 ignored issues – show Documentation Bug introduced 2017-11-29 16:13 UTC by Report Bug Copy Issue Report The property `$deal_ID` was declared of type `integer`, but `md5($voucher['tracking'])` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
114		$Deal->merchant_ID = $voucher['advertiser_id'];
115		$Deal->merchant_name = $voucher['advertiser_name'];
116		$Deal->code = $voucher['code'];
117		$Deal->name = $voucher['name'];
118		$Deal->description = $voucher['description'];
119		$Deal->start_date = $Deal->convertDate($voucher['start_date']);
		0 ignored issues – show Documentation Bug introduced 2017-11-29 16:13 UTC by Report Bug Copy Issue Report It seems like `$Deal->convertDate($voucher['start_date'])` can also be of type `false`. However, the property `$start_date` is declared as type `object<DateTime>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
120		$Deal->end_date = $Deal->convertDate($voucher['end_date']);
		0 ignored issues – show Documentation Bug introduced 2017-11-29 16:13 UTC by Report Bug Copy Issue Report It seems like `$Deal->convertDate($voucher['end_date'])` can also be of type `false`. However, the property `$end_date` is declared as type `object<DateTime>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
121		$Deal->default_track_uri = $voucher['tracking'];
122		$Deal->discount_amount = $voucher['discount_amount'];
123		$Deal->is_percentage = $voucher['is_percentage'];
124		$Deal->is_exclusive = false;
125		$Deal->deal_type = $voucher['type'];
126		$arrResult[] = $Deal;
127		}
128		}
129
130		$result->deals[]=$arrResult;
131
132		return $result;
133
134		}
135
136		/**
137		* @param \DateTime $dateFrom
138		* @param \DateTime $dateTo
139		* @param array $arrMerchantID
140		* @return array of Transaction
141		* @throws \Exception
142		*/
143	View Code Duplication	public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array
		0 ignored issues – show Duplication introduced 2017-11-29 09:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
144		{
145
146		$arrResult = array();
147		$transactionList = $this->_network->getTransactionList($arrMerchantID, $dateFrom, $dateTo);
148		foreach($transactionList as $transaction) {
149		$Transaction = Transaction::createInstance();
150		if (isset($transaction['currency']) && !empty($transaction['currency'])) {
151		$Transaction->currency = $transaction['currency'];
152		} else {
153		$Transaction->currency = "EUR";
154		}
155		$Transaction->status = $transaction['status'];
156		$Transaction->amount = $transaction['amount'];
157		array_key_exists_safe( $transaction,'custom_id' ) ? $Transaction->custom_ID = $transaction['custom_id'] : $Transaction->custom_ID = '';
158		$Transaction->title = '';
159		$Transaction->unique_ID = $transaction['unique_id'];
160		$Transaction->commission = $transaction['commission'];
161		$date = new \DateTime($transaction['date']);
162		$Transaction->date = $date; // $date->format('Y-m-d H:i:s');
		0 ignored issues – show Documentation Bug introduced 2016-11-16 14:17 UTC by Report Bug Copy Issue Report It seems like `$date` of type `object<DateTime>` is incompatible with the declared type `string` of property `$date`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
163		// Future use - Only few providers returns these dates values - <PN> - 2017-06-29
164		if (isset($transaction['click_date']) && !empty($transaction['click_date'])) {
165		$Transaction->click_date = new \DateTime($transaction['click_date']);
		0 ignored issues – show Documentation Bug introduced 2017-11-29 09:00 UTC by Report Bug Copy Issue Report It seems like `new \DateTime($transaction['click_date'])` of type `object<DateTime>` is incompatible with the declared type `string` of property `$click_date`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
166		}
167		if (isset($transaction['update_date']) && !empty($transaction['update_date'])) {
168		$Transaction->update_date = new \DateTime($transaction['update_date']);
		0 ignored issues – show Documentation Bug introduced 2017-11-29 09:00 UTC by Report Bug Copy Issue Report It seems like `new \DateTime($transaction['update_date'])` of type `object<DateTime>` is incompatible with the declared type `string` of property `$update_date`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
169		}
170		$Transaction->merchant_ID = $transaction['merchantId'];
171		$Transaction->campaign_name = $transaction['merchantName'];
172		$Transaction->IP = $transaction['IP'];
173		$Transaction->approved = false;
174		if ($Transaction->status == \Oara\Utilities::STATUS_CONFIRMED){
175		$Transaction->approved = true;
176		}
177		$arrResult[] = $Transaction;
178		}
179
180		return $arrResult;
181		}
182
183		/**
184		* @param \DateTime $dateFrom
185		* @param \DateTime $dateTo
186		* @param int $merchantID
187		* @return array of Stat
188		*/
189		public function getStats(\DateTime $dateFrom, \DateTime $dateTo, int $merchantID = 0) : array
190		{
191		// TODO
192		return array();
193		/*
194		$this->_apiClient->setConnectId($this->_username);
195		$this->_apiClient->setSecretKey($this->_password);
196		$dateFromIsoEngFormat = $dateFrom->format('Y-m-d');
197		$dateToIsoEngFormat = $dateTo->format('Y-m-d');
198		$response = $this->_apiClient->getReportBasic($dateFromIsoEngFormat, $dateToIsoEngFormat);
199		$arrResponse = json_decode($response, true);
200		$reportItems = $arrResponse['reportItems'];
201		$Stat = Stat::createInstance();
202		$Stat->reportItems = $reportItems;
203
204		return array($Stat);
205		*/
206		}
207
208
209		/**
210		* @param array $params
211		* @return ProductsResultset
212		* @throws \Exception
213		*/
214		public function getProducts(array $params = []): ProductsResultset
215		{
216		// TODO: Implement getProducts() method.
217		throw new \Exception("Not implemented yet");
218		}
219
220		public function getTrackingParameter(){
221		return $this->_tracking_parameter;
222		}
223
224
225
226		}
227

padosoft / laravel-affiliate-network

Admitad A last analyzed 2021-06-03 10:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Admitad A
last analyzed 2021-06-03 10:42 UTC