Padosoft\AffiliateNetwork\EbayEx

Complexity

Total Complexity

12

Size/Duplication

Total Lines	170
Duplicated Lines	17.65 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	login()	0	19	1
A	getNeededCredentials()	18	18	1
A	checkConnection()	0	18	1
A	addAllowedSite()	0	3	1
A	getMerchantList()	12	12	1
B	getTransactionList()	0	68	7

<?php
/**
 * Copyright (c) Padosoft.com 2017.
 * Created by Paolo Nardini - 2017-08-31
 */


namespace Padosoft\AffiliateNetwork;
use Oara\Network\Publisher\Ebay as EbayOara;

class EbayEx extends EbayOara
{
    protected $_serverNumber = 6;
    protected $_merchantIdList = array();     // To avoid repeated calls to \Oara\Utilities::getMerchantIdMapFromMerchantList

    /**
     * @param $credentials
     */
    public function login($credentials)
    {
        $this->_credentials = $credentials;

The property _credentials does not exist. Did you maybe forget to declare it?

        $this->_client = new \Oara\Curl\Access($credentials);

        /*
        $valuesLogin = array(
            new \Oara\Curl\Parameter('login_username', $this->_credentials['user']),
            new \Oara\Curl\Parameter('login_password', $this->_credentials['password']),
            new \Oara\Curl\Parameter('submit_btn', 'GO'),
            new \Oara\Curl\Parameter('hubpage', 'y')
        );
        $loginUrl = 'https://ebaypartnernetwork.com/PublisherLogin?hubpage=y&lang=en-US?';

        $urls = array();
        $urls[] = new \Oara\Curl\Request($loginUrl, $valuesLogin);
        $this->_client->post($urls);
        */
    }

    /**
     * @return array
     */
    public function getNeededCredentials()

This method seems to be duplicated in your project.

    {
        $credentials = array();

        $parameter = array();
        $parameter["description"] = "User Log in";
        $parameter["required"] = true;
        $parameter["name"] = "User";
        $credentials["user"] = $parameter;

        $parameter = array();
        $parameter["description"] = "Password to Log in";
        $parameter["required"] = true;
        $parameter["name"] = "Password";
        $credentials["password"] = $parameter;

        return $credentials;
    }

    /**
     * @return bool
     */
    public function checkConnection()
    {
        //If not login properly the construct launch an exception
        $connection = true;
        /*
        $yesterday = new \DateTime();
        $yesterday->sub(new \DateInterval('P2D'));

        $urls = array();
        $urls[] = new \Oara\Curl\Request("https://publisher.ebaypartnernetwork.com/PublisherReportsTx?pt=2&start_date={$yesterday->format("n/j/Y")}&end_date={$yesterday->format("n/j/Y")}&user_name={$this->_credentials['user']}&user_password={$this->_credentials['password']}&advIdProgIdCombo=&tx_fmt=2&submit_tx=Download", array());
        $exportReport = $this->_client->get($urls);

        if (\preg_match("/DOCTYPE html PUBLIC/", $exportReport[0])) {
            $connection = false;
        }
        */
        return $connection;
    }

    /**
     * @param string $idSite
     */
    public function addAllowedSite(string $idSite){
        $this->_sitesAllowed[]=$idSite;
    }

    /**
     * @return array
     */
    public function getMerchantList()

This method seems to be duplicated in your project.

    {
        $merchants = array();

        $obj = array();
        $obj['cid'] = "1";
        $obj['name'] = "Ebay";
        $obj['url'] = "https://publisher.ebaypartnernetwork.com";
        $merchants[] = $obj;

        return $merchants;
    }

    /**
     * @param null $merchantList
     * @param \DateTime|null $dStartDate
     * @param \DateTime|null $dEndDate
     * @return array
     */
    public function getTransactionList($merchantList = null, \DateTime $dStartDate = null, \DateTime $dEndDate = null)
    {
        $totalTransactions = array();

        $urls = array();

        $postParams = array(
            new \Oara\Curl\Parameter('username', $this->_credentials['user']),
            new \Oara\Curl\Parameter('password', $this->_credentials['password']),
            new \Oara\Curl\Parameter('isEnc', 'false'),
            new \Oara\Curl\Parameter('fileFormat', 'txt'),
            new \Oara\Curl\Parameter('eventType', 'earnings'),  // use 'all' to download all events
            new \Oara\Curl\Parameter('startPostDate', $dStartDate->format('Y-m-d')),

It seems like $dStartDate is not always an object, but can also be of type null. Maybe add an additional type check?

            new \Oara\Curl\Parameter('endPostDate', $dEndDate->format('Y-m-d')),

It seems like $dEndDate is not always an object, but can also be of type null. Maybe add an additional type check?

        );
        $url = new \Oara\Curl\Request("https://api.epn.ebay.com/rpt/events/v1/detail/tdr", $postParams );


        $urls[] = $url;
        $exportData = array();

        try {
            $exportReport = $this->_client->post($urls, 0);
            $exportData = \str_getcsv($exportReport[0], "\n");
        } catch (\Exception $e) {
            // ignore any error
        }

        // OLD Version - URL Doesn't work anymore - 2017-08-31 <PN>
        /*
        $urls = array();
        $urls[] = new \Oara\Curl\Request("https://publisher.ebaypartnernetwork.com/PublisherReportsTx?pt=2&start_date={$dStartDate->format("n/j/Y")}&end_date={$dEndDate->format("n/j/Y")}&user_name={$this->_credentials['user']}&user_password={$this->_credentials['password']}&advIdProgIdCombo=&tx_fmt=3&submit_tx=Download", array());
        $exportData = array();
        try {
            $exportReport = $this->_client->get($urls, 'content', 5);
            $exportData = \str_getcsv($exportReport[0], "\n");
        } catch (\Exception $e) {

        */
        $num = \count($exportData);
        for ($i = 1; $i < $num; $i++) {
            $transactionExportArray = \str_getcsv($exportData[$i], "\t");

            if ($transactionExportArray[2] == "Winning Bid (Revenue)" && (empty($this->_sitesAllowed) || \in_array($transactionExportArray[5], $this->_sitesAllowed))) {
                $transaction = Array();
                $transaction['merchantId'] = 0;
                $transaction['merchantName'] = '';
                $transaction['unique_id']  = $transactionExportArray[18];
                $transactionDate = \DateTime::createFromFormat("Y-m-d", $transactionExportArray[0]);
                $transaction['date'] = $transactionDate->format("Y-m-d") . ' 00:00:00';
                $postDate = \DateTime::createFromFormat("Y-m-d", $transactionExportArray[1]);
                $transaction['post_date'] = $postDate->format("Y-m-d") . ' 00:00:00';
                if ($transactionExportArray[10] != null) {
                    $transaction['custom_id'] = $transactionExportArray[10];
                }
                $transaction['click_date'] = $transactionExportArray[11];
                $transaction['ebay_amount'] = (float) $transactionExportArray[3];
                $transaction['amount'] = (float) $transactionExportArray[15];
                $transaction['commission'] = (float) $transactionExportArray[20];
                // Set status as Pending
                // ... real status (approved / denied) must be calculated by summing all negative/positive records
                // ... and checking final amount for a positive or zero value
                $transaction['status'] = \Oara\Utilities::STATUS_PENDING;
                $totalTransactions[] = $transaction;
            }
        }
        return $totalTransactions;
    }
}