Complex classes like FileHelper often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FileHelper, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
9 | class FileHelper |
||
10 | { |
||
11 | public static $arrMimeType = array( |
||
12 | |||
13 | 'txt' => 'text/plain', |
||
14 | 'htm' => 'text/html', |
||
15 | 'html' => 'text/html', |
||
16 | 'php' => 'text/html', |
||
17 | 'css' => 'text/css', |
||
18 | 'js' => 'application/javascript', |
||
19 | 'json' => 'application/json', |
||
20 | 'xml' => 'application/xml', |
||
21 | 'swf' => 'application/x-shockwave-flash', |
||
22 | 'flv' => 'video/x-flv', |
||
23 | |||
24 | // images |
||
25 | 'png' => 'image/png', |
||
26 | 'jpe' => 'image/jpeg', |
||
27 | 'jpeg' => 'image/jpeg', |
||
28 | 'jpg' => 'image/jpeg', |
||
29 | 'gif' => 'image/gif', |
||
30 | 'bmp' => 'image/bmp', |
||
31 | 'ico' => 'image/vnd.microsoft.icon', |
||
32 | 'tiff' => 'image/tiff', |
||
33 | 'tif' => 'image/tiff', |
||
34 | 'svg' => 'image/svg+xml', |
||
35 | 'svgz' => 'image/svg+xml', |
||
36 | |||
37 | // archives |
||
38 | 'zip' => 'application/zip', |
||
39 | 'rar' => 'application/x-rar-compressed', |
||
40 | 'exe' => 'application/x-msdownload', |
||
41 | 'msi' => 'application/x-msdownload', |
||
42 | 'cab' => 'application/vnd.ms-cab-compressed', |
||
43 | |||
44 | // audio/video |
||
45 | 'mp3' => 'audio/mpeg', |
||
46 | 'qt' => 'video/quicktime', |
||
47 | 'mov' => 'video/quicktime', |
||
48 | |||
49 | // adobe |
||
50 | 'pdf' => 'application/pdf', |
||
51 | 'psd' => 'image/vnd.adobe.photoshop', |
||
52 | 'ai' => 'application/postscript', |
||
53 | 'eps' => 'application/postscript', |
||
54 | 'ps' => 'application/postscript', |
||
55 | |||
56 | // ms office |
||
57 | 'doc' => 'application/msword', |
||
58 | 'rtf' => 'application/rtf', |
||
59 | 'xls' => 'application/vnd.ms-excel', |
||
60 | 'ppt' => 'application/vnd.ms-powerpoint', |
||
61 | |||
62 | // open office |
||
63 | 'odt' => 'application/vnd.oasis.opendocument.text', |
||
64 | 'ods' => 'application/vnd.oasis.opendocument.spreadsheet', |
||
65 | ); |
||
66 | |||
67 | /** |
||
68 | * Simple pathinfo wrapper. |
||
69 | * @param string $filePath |
||
70 | * @param int $fileInfOoptions |
||
71 | * @return string |
||
72 | * @see http://php.net/manual/en/function.pathinfo.php |
||
73 | */ |
||
74 | public static function getPathinfoPart(string $filePath, int $fileInfOoptions) : string |
||
75 | { |
||
76 | if ($filePath == '' || is_dir($filePath) || DirHelper::endsWithSlash($filePath)) { |
||
77 | return ''; |
||
78 | } |
||
79 | |||
80 | $info = pathinfo($filePath, $fileInfOoptions); |
||
81 | |||
82 | if ($info == '.' && $fileInfOoptions == PATHINFO_DIRNAME) { |
||
83 | return ''; |
||
84 | } |
||
85 | return ($info !== null && $info != '') ? $info : ''; |
||
86 | } |
||
87 | |||
88 | /** |
||
89 | * Return the file name of file (without path and without extension). |
||
90 | * Return empty string if $filePath is null, empty or is a directory. |
||
91 | * Ex.: /public/upload/pippo.txt return '/public/upload' |
||
92 | * @param string $filePath |
||
93 | * @return string |
||
94 | */ |
||
95 | public static function getDirname(string $filePath) : string |
||
99 | |||
100 | /** |
||
101 | * Return the file name of file (without path and with extension). |
||
102 | * Return empty string if $filePath is null, empty or is a directory. |
||
103 | * Ex.: /public/upload/pippo.txt return 'pippo.txt' |
||
104 | * @param string $filePath |
||
105 | * @return string |
||
106 | */ |
||
107 | public static function getFilename(string $filePath) : string |
||
111 | |||
112 | /** |
||
113 | * Return the file name of file (without path and without extension). |
||
114 | * Return empty string if $filePath is null, empty or is a directory. |
||
115 | * Ex.: /public/upload/pippo.txt return 'pippo' |
||
116 | * @param string $filePath |
||
117 | * @return string |
||
118 | */ |
||
119 | public static function getFilenameWithoutExtension(string $filePath) : string |
||
123 | |||
124 | /** |
||
125 | * Return the file name of file (without path and without extension). |
||
126 | * Return empty string if $filePath is null, empty or is a directory. |
||
127 | * Ex.: /public/upload/pippo.txt return '.txt' |
||
128 | * @param string $filePath |
||
129 | * @param bool $ignoreCase if set to true return lowercase extension |
||
130 | * (Requires mbstring extension for correct multi-byte character handling in extension) |
||
131 | * |
||
132 | * @return string |
||
133 | */ |
||
134 | public static function getFilenameExtension(string $filePath, bool $ignoreCase = false) : string |
||
139 | |||
140 | /** |
||
141 | * Returns whether the path has an extension. |
||
142 | * |
||
143 | * @param string $path The path string |
||
144 | * @param string|array|null $extensions If null or not provided, checks if an |
||
145 | * extension exists, otherwise checks for |
||
146 | * the specified extension or array of extensions |
||
147 | * (with or without leading dot) |
||
148 | * @param bool $ignoreCase Whether to ignore case-sensitivity |
||
149 | * (Requires mbstring extension for correct |
||
150 | * multi-byte character handling in extension) |
||
151 | * |
||
152 | * @return bool true if the path has an (or the specified) extension, otherwise false |
||
153 | * |
||
154 | * @see https://github.com/laradic/support/blob/master/src/Path.php |
||
155 | */ |
||
156 | public static function hasExtension(string $path, $extensions = null, bool $ignoreCase = false) : bool |
||
178 | |||
179 | /** |
||
180 | * if $extensions is not an array, return [$extensions]. |
||
181 | * @param $extensions |
||
182 | * @return array |
||
183 | */ |
||
184 | protected static function variable2Array($extensions) : array |
||
191 | |||
192 | /** |
||
193 | * Changes the extension of a path string. |
||
194 | * |
||
195 | * @param string $path The path string with filename.ext to change |
||
196 | * @param string $extension New extension (with or without leading dot) |
||
197 | * |
||
198 | * @return string The path string with new file extension |
||
199 | * |
||
200 | * @see https://github.com/laradic/support/blob/master/src/Path.php |
||
201 | */ |
||
202 | public static function changeExtension($path, $extension) |
||
219 | |||
220 | /** |
||
221 | * unlink file if exists. |
||
222 | * Return false if exists and unlink fails or if filePath is a dir. |
||
223 | * @param string $filePath |
||
224 | * @return bool |
||
225 | */ |
||
226 | public static function unlinkSafe(string $filePath) : bool |
||
238 | |||
239 | /** |
||
240 | * Check if passed file exists or not. |
||
241 | * If dir passed return false. |
||
242 | * @param string $filePath |
||
243 | * @return bool |
||
244 | */ |
||
245 | public static function fileExistsSafe(string $filePath) : bool |
||
246 | { |
||
247 | if ($filePath == '') { |
||
248 | return false; |
||
249 | } |
||
250 | |||
251 | if (DirHelper::isDirSafe($filePath)) { |
||
252 | return false; |
||
253 | } |
||
254 | |||
255 | return file_exists($filePath); |
||
256 | } |
||
257 | |||
258 | /** |
||
259 | * Find files matching a pattern (recursive with matched files in subdirs). |
||
260 | * Returns an array containing the matched files (full path and not directories), |
||
261 | * an empty array if no file matched or on error. |
||
262 | * @param string $fileNamePattern if is null it set to base_path()/* if exists otherwise __DIR__/* . It support glob() string pattern. |
||
263 | * @param int $flags glob() Valid flags |
||
264 | * @return array of files (full path) |
||
265 | */ |
||
266 | public static function findFiles(string $fileNamePattern, int $flags = 0) |
||
309 | |||
310 | /** |
||
311 | * Equals to file_put_contents but safe, i.e. |
||
312 | * accept empty string and return false without raise an error, |
||
313 | * accept a directory and return false without raise an error, |
||
314 | * and if $forceCreateDirIfNotExists is set to true and path doesn't exists, file_put_contents fails |
||
315 | * so, this class, try to create the complete path before save file. |
||
316 | * @param string $filename file name including folder. |
||
317 | * example :: /path/to/file/filename.ext or filename.ext |
||
318 | * @param string $data The data to write. |
||
319 | * @param bool $forceCreateDirIfNotExists if true and path not exists, try to create it. |
||
320 | * @param string $modeMask The mask applied to dir if need to create some dir. |
||
321 | * @param int $flags same flags used for file_put_contents. |
||
322 | * @see more info: http://php.net/manual/en/function.file-put-contents.php |
||
323 | * @return bool TRUE file created succesfully, return FALSE if failed to create file. |
||
324 | */ |
||
325 | public static function filePutContentsSafe( |
||
326 | string $filename, |
||
327 | string $data, |
||
328 | bool $forceCreateDirIfNotExists = true, |
||
329 | string $modeMask = '0755', |
||
330 | int $flags = 0 |
||
331 | ) : bool |
||
332 | { |
||
333 | if ($filename == '') { |
||
334 | return false; |
||
335 | } |
||
336 | |||
337 | //check if a directory passed ($filename ends with slash) |
||
338 | if (DirHelper::endsWithSlash($filename)) { |
||
339 | return false; |
||
340 | } |
||
341 | |||
342 | $dirName = dirname($filename); |
||
343 | |||
344 | if (!$forceCreateDirIfNotExists && !DirHelper::isDirSafe($dirName)) { |
||
345 | return false; |
||
346 | } |
||
347 | |||
348 | if (!DirHelper::checkDirExistOrCreate(DirHelper::addFinalSlash($dirName), $modeMask)) { |
||
349 | return false; |
||
350 | } |
||
351 | |||
352 | return file_put_contents($filename, $data, $flags); |
||
353 | } |
||
354 | |||
355 | /** |
||
356 | * Return mime type of a passed file in optimized mode. |
||
357 | * @param string $fullPathFile |
||
358 | * @return string |
||
359 | */ |
||
360 | public static function getMimeType(string $fullPathFile) : string |
||
377 | |||
378 | /** |
||
379 | * Return mime type of a passed file using finfo |
||
380 | * @param string $fullPathFile |
||
381 | * @return string return empty string if it fails. |
||
382 | */ |
||
383 | public static function getMimeTypeByFinfo(string $fullPathFile) : string |
||
396 | |||
397 | /** |
||
398 | * Return mime type of a passed file using mime_content_type() |
||
399 | * @param string $fullPathFile |
||
400 | * @return string return empty string if it fails. |
||
401 | */ |
||
402 | public static function getMimeTypeByMimeContentType(string $fullPathFile) : string |
||
409 | |||
410 | /** |
||
411 | * Converts string to lower-case (multi-byte safe if mbstring is installed). |
||
412 | * |
||
413 | * @param string $str The string |
||
414 | * |
||
415 | * @return string Lower case string |
||
416 | * @see https://github.com/laradic/support/blob/master/src/Path.php |
||
417 | */ |
||
418 | private static function toLower($str) |
||
425 | |||
426 | /** |
||
427 | * Check if $path is a file and is readable. |
||
428 | * Return false if you pass a dir. |
||
429 | * @param string $path |
||
430 | * @return bool |
||
431 | */ |
||
432 | public static function isReadable(string $path):bool |
||
436 | |||
437 | /** |
||
438 | * Gets file or dir permissions in octal form ('0777') or not ('644'). |
||
439 | * @param string $file |
||
440 | * @param bool $octal default false i.e. return '644' |
||
441 | * @return bool|string return false if it fails. |
||
442 | */ |
||
443 | public static function filPerms(string $file, bool $octal = false) |
||
458 | } |
||
459 |