HttpHelperFacade - Code Metrics - padosoft/HTTPClient - Measure and Improve Code Quality continuously with Scrutinizer

HttpHelperFacade A
last analyzed 2017-08-09 09:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	163
Duplicated Lines	14.11 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	5
dl	23
loc	163
c	0
b	0
f	0
rs	10

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	sendSimpleRequest()	0	23	1
A	sendGet()	0	12	1
A	sendGetWithAuth()	13	13	1
A	sendPost()	0	10	1
A	sendPostWithAuth()	10	10	1
A	sendPostJsonWithAuth()	0	9	1

How to fix Duplicated Code

<?php
/**
 * Copyright (c) Padosoft.com 2016.
 */

namespace Padosoft\HTTPClient;

use GuzzleHttp\Client;

/**
 * Class HttpHelper
 * HTTP Helper class
 * @package Padosoft\HTTPClient
 */
class HttpHelperFacade
{
    /**
     * @var Response
     */
    protected $response;
    /**
     * @var HTTPClient
     */
    protected $httpclient;
    /**
     * @var \Padosoft\HTTPClient\RequestHelper
     */
    protected $requestHelper;

    /**
     * HttpHelper constructor.
     * @param HTTPClient $httpclient
     */
    public function __construct(\Padosoft\HTTPClient\HTTPClient $httpclient)
    {
        $this->httpclient = $httpclient;
        $this->requestHelper = $httpclient->requestHelper;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->response = new Response();
    }

    /**
     * Send HTTP Request
     *
     * @param $method
     * @param $uri
     * @param array $getParams
     * @param array $postParams
     * @param string $user
     * @param string $password
     * @param array $jsonParams
     * @param int $requesTimeout
     * @param bool $SSLVerify
     * @param array $customHeaders
     * @param string $accept
     * @param string $protocolVersion
     * @return Response
     */
    public static function sendSimpleRequest($method, $uri
                                    , array $getParams=[], array $postParams=[]
                                    , $user="", $password=""
                                    , array $jsonParams=[]
                                    , $requesTimeout=0, $SSLVerify=true
                                    , array $customHeaders=[], $accept="", $protocolVersion=""
                                    )
    {

        $requestHelper = new RequestHelper();
        $guzzle = new Client();
        $httpClient = new HTTPClient($guzzle,$requestHelper);
        $httpHelper = new HttpHelper($httpClient);

        $response = $httpHelper->sendSimpleRequest($method, $uri
            , $getParams, $postParams
            , $user, $password
            , $jsonParams
                , $requesTimeout, $SSLVerify
                , $customHeaders, $accept, $protocolVersion);

        return $response;
    }

    /**
     * @param $uri
     * @param array $getParams
     * @param array $postParams
     * @return Response
     */
    public static function sendGet($uri, array $getParams=[], array $postParams=[])
    {

        $requestHelper = new RequestHelper();
        $guzzle = new Client();
        $httpClient = new HTTPClient($guzzle,$requestHelper);
        $httpHelper = new HttpHelper($httpClient);
        $response = $httpHelper->sendGet($uri, $getParams, $postParams);

        return $response;

    }

    /**
     * @param $uri
     * @param array $getParams
     * @param array $postParams
     * @param $user
     * @param $password
     * @return Response
     */
    public static function sendGetWithAuth($uri, array $getParams=[], array $postParams=[], $user, $password)

    {

        $requestHelper = new RequestHelper();
        $guzzle = new Client();
        $httpClient = new HTTPClient($guzzle,$requestHelper);
        $httpHelper = new HttpHelper($httpClient);
        $response = $httpHelper->sendGetWithAuth($uri,  $getParams,  $postParams, $user, $password);

        return $response;


    }

    /**
     * @param $uri
     * @param array $getParams
     * @param array $postParams
     * @return Response
     */
    public static function sendPost($uri, array $getParams=[], array $postParams=[])
    {
        $requestHelper = new RequestHelper();
        $guzzle = new Client();
        $httpClient = new HTTPClient($guzzle,$requestHelper);
        $httpHelper = new HttpHelper($httpClient);
        $response = $httpHelper->sendPost($uri,  $getParams,  $postParams);

        return $response;
    }

    /**
     * @param $uri
     * @param array $getParams
     * @param array $postParams
     * @param $user
     * @param $password
     * @return Response
     */
    public static function sendPostWithAuth($uri, array $getParams=[], array $postParams=[], $user, $password)

    {
        $requestHelper = new RequestHelper();
        $guzzle = new Client();
        $httpClient = new HTTPClient($guzzle,$requestHelper);
        $httpHelper = new HttpHelper($httpClient);
        $response = $httpHelper->sendPostWithAuth($uri, $getParams,  $postParams, $user, $password);

        return $response;
    }

    /**
     * @param $uri
     * @param array $jsonParams
     * @param $user
     * @param $password
     * @return Response
     */
    public static function sendPostJsonWithAuth($uri, array $jsonParams=[], $user, $password)
    {
        $requestHelper = new RequestHelper();
        $guzzle = new Client();
        $httpClient = new HTTPClient($guzzle,$requestHelper);
        $httpHelper = new HttpHelper($httpClient);
        $response = $httpHelper->sendPostJsonWithAuth($uri, $jsonParams, $user, $password);
        return $response;
    }


}


1		<?php
2		/**
3		* Copyright (c) Padosoft.com 2016.
4		*/
5
6		namespace Padosoft\HTTPClient;
7
8		use GuzzleHttp\Client;
9
10		/**
11		* Class HttpHelper
12		* HTTP Helper class
13		* @package Padosoft\HTTPClient
14		*/
15		class HttpHelperFacade
16		{
17		/**
18		* @var Response
19		*/
20		protected $response;
21		/**
22		* @var HTTPClient
23		*/
24		protected $httpclient;
25		/**
26		* @var \Padosoft\HTTPClient\RequestHelper
27		*/
28		protected $requestHelper;
29
30		/**
31		* HttpHelper constructor.
32		* @param HTTPClient $httpclient
33		*/
34		public function __construct(\Padosoft\HTTPClient\HTTPClient $httpclient)
35		{
36		$this->httpclient = $httpclient;
37		$this->requestHelper = $httpclient->requestHelper;
		0 ignored issues – show Documentation introduced 2016-10-12 15:19 UTC by Report Bug Copy Issue Report The property `$requestHelper` is declared protected in `Padosoft\HTTPClient\HTTPClient`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38		$this->response = new Response();
39		}
40
41		/**
42		* Send HTTP Request
43		*
44		* @param $method
45		* @param $uri
46		* @param array $getParams
47		* @param array $postParams
48		* @param string $user
49		* @param string $password
50		* @param array $jsonParams
51		* @param int $requesTimeout
52		* @param bool $SSLVerify
53		* @param array $customHeaders
54		* @param string $accept
55		* @param string $protocolVersion
56		* @return Response
57		*/
58		public static function sendSimpleRequest($method, $uri
59		, array $getParams=[], array $postParams=[]
60		, $user="", $password=""
61		, array $jsonParams=[]
62		, $requesTimeout=0, $SSLVerify=true
63		, array $customHeaders=[], $accept="", $protocolVersion=""
64		)
65		{
66
67		$requestHelper = new RequestHelper();
68		$guzzle = new Client();
69		$httpClient = new HTTPClient($guzzle,$requestHelper);
70		$httpHelper = new HttpHelper($httpClient);
71
72		$response = $httpHelper->sendSimpleRequest($method, $uri
73		, $getParams, $postParams
74		, $user, $password
75		, $jsonParams
76		, $requesTimeout, $SSLVerify
77		, $customHeaders, $accept, $protocolVersion);
78
79		return $response;
80		}
81
82		/**
83		* @param $uri
84		* @param array $getParams
85		* @param array $postParams
86		* @return Response
87		*/
88		public static function sendGet($uri, array $getParams=[], array $postParams=[])
89		{
90
91		$requestHelper = new RequestHelper();
92		$guzzle = new Client();
93		$httpClient = new HTTPClient($guzzle,$requestHelper);
94		$httpHelper = new HttpHelper($httpClient);
95		$response = $httpHelper->sendGet($uri, $getParams, $postParams);
96
97		return $response;
98
99		}
100
101		/**
102		* @param $uri
103		* @param array $getParams
104		* @param array $postParams
105		* @param $user
106		* @param $password
107		* @return Response
108		*/
109	View Code Duplication	public static function sendGetWithAuth($uri, array $getParams=[], array $postParams=[], $user, $password)
		0 ignored issues – show Duplication introduced 2016-10-12 15:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110		{
111
112		$requestHelper = new RequestHelper();
113		$guzzle = new Client();
114		$httpClient = new HTTPClient($guzzle,$requestHelper);
115		$httpHelper = new HttpHelper($httpClient);
116		$response = $httpHelper->sendGetWithAuth($uri, $getParams, $postParams, $user, $password);
117
118		return $response;
119
120
121		}
122
123		/**
124		* @param $uri
125		* @param array $getParams
126		* @param array $postParams
127		* @return Response
128		*/
129		public static function sendPost($uri, array $getParams=[], array $postParams=[])
130		{
131		$requestHelper = new RequestHelper();
132		$guzzle = new Client();
133		$httpClient = new HTTPClient($guzzle,$requestHelper);
134		$httpHelper = new HttpHelper($httpClient);
135		$response = $httpHelper->sendPost($uri, $getParams, $postParams);
136
137		return $response;
138		}
139
140		/**
141		* @param $uri
142		* @param array $getParams
143		* @param array $postParams
144		* @param $user
145		* @param $password
146		* @return Response
147		*/
148	View Code Duplication	public static function sendPostWithAuth($uri, array $getParams=[], array $postParams=[], $user, $password)
		0 ignored issues – show Duplication introduced 2016-10-12 15:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
149		{
150		$requestHelper = new RequestHelper();
151		$guzzle = new Client();
152		$httpClient = new HTTPClient($guzzle,$requestHelper);
153		$httpHelper = new HttpHelper($httpClient);
154		$response = $httpHelper->sendPostWithAuth($uri, $getParams, $postParams, $user, $password);
155
156		return $response;
157		}
158
159		/**
160		* @param $uri
161		* @param array $jsonParams
162		* @param $user
163		* @param $password
164		* @return Response
165		*/
166		public static function sendPostJsonWithAuth($uri, array $jsonParams=[], $user, $password)
167		{
168		$requestHelper = new RequestHelper();
169		$guzzle = new Client();
170		$httpClient = new HTTPClient($guzzle,$requestHelper);
171		$httpHelper = new HttpHelper($httpClient);
172		$response = $httpHelper->sendPostJsonWithAuth($uri, $jsonParams, $user, $password);
173		return $response;
174		}
175
176
177		}
178

padosoft / HTTPClient

HttpHelperFacade A last analyzed 2017-08-09 09:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

HttpHelperFacade A
last analyzed 2017-08-09 09:12 UTC