Packback\Prices\Clients\AmazonPriceClient

Complexity

Total Complexity

20

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	5

Test Coverage

Coverage

98.68%

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
B	addPricesToCollection()	0	21	8
B	populatePriceData()	0	24	4
A	addParam()	0	5	1
A	setConfiguration()	0	9	1
B	getPricesForIsbns()	0	34	4
A	send()	0	5	1

<?php namespace Packback\Prices\Clients;

use Packback\Prices\PriceClient;
use ApaiIO\Configuration\GenericConfiguration;
use ApaiIO\Operations\Search;
use ApaiIO\ApaiIO;

class AmazonPriceClient extends PriceClient
{
    const RETAILER = 'amazon';

    public $conf;
    public $container;
    public $search;

    public function __construct($config = [])
    {
        $this->conf = new GenericConfiguration();
        $this->setConfiguration($config);
        $this->container = new ApaiIO($this->conf);
        $this->search = new Search();
    }

    public function setConfiguration($config = [])
    {
        $this->conf
            ->setCountry('com')
            ->setAccessKey($config['access_key'])
            ->setSecretKey($config['secret_key'])
            ->setAssociateTag($config['associate_tag']);
        $this->conf->setResponseTransformer('\ApaiIO\ResponseTransformer\XmlToSimpleXmlObject');
    }

    public function getPricesForIsbns($isbns = [])
    {
        $isbn_groups = [];

        if (count($isbns) > 10) {
            $isbn_groups = array_chunk($isbns, 10);
        } else {
            array_push($isbn_groups, $isbns);
        }
        foreach ($isbn_groups as $isbn_group) {
            $response = $this->addParam('Condition', 'New')

$response is not used, you could remove the assignment.

                ->addParam('IdType', 'ISBN')
                ->addParam('ItemId', $isbn_group)
                ->addParam('Condition', 'All')
                ->addParam('SearchIndex', 'Books')
                ->addParam('Operation', 'ItemLookup')
                ->addParam('Version', '2011-08-01')
                ->addParam('ResponseGroup', ['Large'])
                ->addParam('Service', 'AWSECommerceService');

            // Get response for Marketplace books
            $response = $this->send();
            // If there is an error with the API key, throw an exception
            if (isset($response->Error)) {
                throw new \Exception($response->Error->Code.': '.$response->Error->Message);
            }
            $this->addPricesToCollection($response);
            // Get response for only Amazon books
            $response = $this->addParam('MerchantId', 'Amazon')->send();
            $this->addPricesToCollection($response);
        }

        return $this->collection;
    }

    public function addPricesToCollection($response)
    {
        if (isset($response->Items->Request->IsValid) && $response->Items->Request->IsValid) {
            if (isset($response->Items->Item)) {
                $items = $response->Items->Item;
                foreach ($items as $key => $item) {
                    // Create price objects for each offer
                    if (isset($item->Offers->Offer)) {
                        if (is_array($item->Offers->Offer)) {
                            foreach ($item->Offers->Offer as $offer) {
                                $this->collection[] = $this->populatePriceData($offer, $item, self::RETAILER);
                            }
                        } else {
                            $this->collection[] = $this->populatePriceData($item->Offers->Offer, $item, self::RETAILER);
                        }
                    }
                }
            }
        }
        return $this->collection;
    }

    public function populatePriceData($offer, $item, $merchant_id)
    {
        // New price model object
        $price = $this->createNewPrice();
        // Set retailer
        $price->retailer = $merchant_id;
        // Populate ISBN 13
        if (isset($item->ItemAttributes->EAN)) {
            $price->isbn13 = $item->ItemAttributes->EAN;
        } elseif (isset($item->ItemAttributes->EISBN)) {
            $price->isbn13 = $item->ItemAttributes->EISBN;
        }
        // Populate URL
        if (isset($item->DetailPageURL)) {
            $price->url = $item->DetailPageURL;
        }
        // Populate condition
        $price->condition = parent::getConditionFromString($offer->OfferAttributes->Condition);

It seems like you call parent on a different method (getConditionFromString() instead of populatePriceData()). Are you sure this is correct? If so, you might want to change this to $this->getConditionFromString().

        // Populate term
        $price->term = parent::TERM_PERPETUAL;
        // Populate Price
        $price->price = ((float)$offer->OfferListing->Price->Amount)/100;

The property $price was declared of type string, but (double) $offer->OfferListing->Price->Amount / 100 is of type double. Maybe add a type cast?

        return $price;
    }

    public function addParam($key, $value)
    {
        $this->search->{'set'.$key}($value);
        return $this;
    }

    public function send()
    {
        $response = $this->container->runOperation($this->search);
        return json_decode(json_encode($response));
    }
}