PH7\Test\Unit\Framework\Layout\Html\DesignTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	testSetFlashMsgWithDefaultType()	0	6	1
A	testSetFlashMsgWithErrorType()	0	6	1
A	testSetFlashMsgWithWrongType()	0	6	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 17 and the first side effect is on line 11.

/**
 * @author           Pierre-Henry Soria <hello@ph7cms.com>
 * @copyright        (c) 2017, Pierre-Henry Soria. All Rights Reserved.
 * @license          GNU General Public License; See PH7.LICENSE.txt and PH7.COPYRIGHT.txt in the root directory.
 * @package          PH7 / Test / Unit / Framework / Layout / Html
 */

namespace PH7\Test\Unit\Framework\Layout\Html;

@session_start();

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

use PH7\Framework\Layout\Html\Design;
use PH7\Framework\Session\Session;
use PH7\Framework\Config\Config;

class DesignTest extends \PHPUnit_Framework_TestCase
{
    private $oDesign;
    private $oSession;
    private $oConfig;

    protected function setUp()
    {
        $this->oConfig = Config::getInstance();
        $this->oSession = new Session;
        $this->oDesign = new Design;
    }

    public function testSetFlashMsgWithDefaultType()
    {
        $this->oDesign->setFlashMsg('Hey You!');
        $this->assertEquals('Hey You!', $this->oSession->get('flash_msg'));
        $this->assertEquals('success', $this->oSession->get('flash_type'));
    }

    public function testSetFlashMsgWithErrorType()
    {
        $this->oDesign->setFlashMsg('Wrong Message!', Design::ERROR_TYPE);
        $this->assertEquals('Wrong Message!', $this->oSession->get('flash_msg'));
        $this->assertEquals('error', $this->oSession->get('flash_type'));
    }

    public function testSetFlashMsgWithWrongType()
    {
        $this->oDesign->setFlashMsg('blabla', 'wrong_type');
        $this->assertEquals('blabla', $this->oSession->get('flash_msg'));
        $this->assertEquals('', $this->oSession->get('flash_type'));
    }
 }