a file either defines symbols or has side-effects, but not both.
These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
0 ignored issues
–
show
|
|||
2 | /** |
||
3 | * @author Pierre-Henry Soria <[email protected]> |
||
4 | * @copyright (c) 2012-2017, Pierre-Henry Soria. All Rights Reserved. |
||
5 | * @license GNU General Public License; See PH7.LICENSE.txt and PH7.COPYRIGHT.txt in the root directory. |
||
6 | * @package PH7 / Inc / Ajax |
||
7 | */ |
||
8 | |||
9 | namespace PH7; |
||
10 | define('PH7', 1); |
||
11 | |||
12 | require '_ajax.inc.php'; |
||
13 | |||
14 | if (!empty($_POST['dir'])) |
||
15 | { |
||
16 | if (is_directory($_POST['dir'])) |
||
17 | echo '<p class="success">' . $LANG['yes_dir'] . '</p>'; |
||
18 | else |
||
19 | echo '<p class="error">' . $LANG['no_dir'] . '</p>'; |
||
20 | } |
||
21 |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.