PH7\Framework\Navigation\Page

Complexity

Total Complexity

19

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	totalPages()	0	11	4
A	getTotalPages()	0	5	2
A	getTotalItems()	0	4	1
A	getFirstItem()	0	4	2
A	getNbItemsPerPage()	0	4	1
A	getCurrentPage()	0	4	1
A	cleanDynamicUrl()	0	13	2
A	trailingSlash()	0	4	3
A	getUrlSlug()	0	4	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 19 and the first side effect is on line 15.

/**
 * @title            Page Class
 * @desc             Various Page methods with also the pagination methods.
 *
 * @author           Pierre-Henry Soria <ph7software@gmail.com>
 * @copyright        (c) 2012-2018, Pierre-Henry Soria. All Rights Reserved.
 * @license          GNU General Public License; See PH7.LICENSE.txt and PH7.COPYRIGHT.txt in the root directory.
 * @package          PH7 / Framework / Navigation
 * @version          1.2
 */

namespace PH7\Framework\Navigation;

defined('PH7') or exit('Restricted access');

use PH7\Framework\Mvc\Request\Http as HttpRequest;

class Page
{
    const DEFAULT_NUMBER_ITEMS = 10;

    /** @var HttpRequest */
    private $oHttpRequest;

    /** @var int */
    private $iTotalPages;

    /** @var int */
    private $iTotalItems;

    /** @var int */
    private $iNbItemsPerPage;

    /** @var int */
    private $iCurrentPage;

    /** @var int */
    private $iFirstItem;

    public function __construct()
    {
        $this->oHttpRequest = new HttpRequest;
    }

    /**
     * @param int $iTotalItems
     * @param int $iNbItemsPerPage
     *
     * @return void
     */
    protected function totalPages($iTotalItems, $iNbItemsPerPage)
    {
        $this->iTotalItems = (int)$iTotalItems;
        $this->iNbItemsPerPage = (int)$iNbItemsPerPage; // or intval() function, but it is slower than casting
        $this->iCurrentPage = (int)$this->oHttpRequest->getExists('p') ? $this->oHttpRequest->get('p') : 1;

It seems like (int) $this->oHttpRequest->getExists('p') ? $this->oHttpRequest->get('p') : 1 can also be of type string. However, the property $iCurrentPage is declared as type integer. Maybe add an additional type check?

        // Ternary condition to prevent division by zero
        $this->iTotalPages = (int)($this->iTotalItems !== 0 && $this->iNbItemsPerPage !== 0) ? ceil($this->iTotalItems / $this->iNbItemsPerPage) : 0;

It seems like (int) ($this->iTotalItems !== 0 && $this->iNbItemsPerPage !== 0) ? ceil($this->iTotalItems / $this->iNbItemsPerPage) : 0 can also be of type double. However, the property $iTotalPages is declared as type integer. Maybe add an additional type check?

        $this->iFirstItem = (int)($this->iCurrentPage - 1) * $this->iNbItemsPerPage;
    }

    /**
     * @param int $iTotalItems
     * @param int $iNbItemsPerPage Default 10
     *
     * @return int The number of pages.
     */
    public function getTotalPages($iTotalItems, $iNbItemsPerPage = self::DEFAULT_NUMBER_ITEMS)
    {
        $this->totalPages($iTotalItems, $iNbItemsPerPage);
        return ($this->iTotalPages < 1) ? 1 : $this->iTotalPages;
    }

    public function getTotalItems()
    {
        return $this->iTotalItems;
    }

    public function getFirstItem()
    {
        return $this->iFirstItem < 0 ? 0 : $this->iFirstItem;
    }

    public function getNbItemsPerPage()
    {
        return $this->iNbItemsPerPage;
    }

    public function getCurrentPage()
    {
        return $this->iCurrentPage;
    }

    /**
     * Clean a Dynamic URL for some features CMS.
     *
     * @param string $sVar The Query URL (e.g. www.pierre-henry-soria.com/my-mod/?query=value).
     *
     * @return string $sPageUrl The new clean URL.
     */
    public static function cleanDynamicUrl($sVar)
    {
        $sCurrentUrl = (new HttpRequest)->currentUrl();
        $sUrl = preg_replace('#\?.+$#', '', $sCurrentUrl);

        if (preg_match('#\?(.+[^\./])=(.+[^\./])$#', $sCurrentUrl)) {
            $sPageUrl = $sUrl . self::getUrlSlug($sCurrentUrl) . '&amp;' . $sVar . '=';
        } else {
            $sPageUrl = $sUrl . static::trailingSlash($sUrl) . '?' . $sVar . '=';

Since trailingSlash() is declared private, calling it with static will lead to errors in possible sub-classes. You can either use self, or increase the visibility of trailingSlash() to at least protected.

        }

        return $sPageUrl;
    }

    /**
     * Returns a trailing slash if needed.
     *
     * @param  string $sUrl
     *
     * @return string
     */
    private static function trailingSlash($sUrl)
    {
        return (substr($sUrl, -1) !== PH7_SH && !strstr($sUrl, PH7_PAGE_EXT)) ? PH7_SH : '';
    }

    /**
     * @param string $sCurrentUrl
     *
     * @return string
     */
    private static function getUrlSlug($sCurrentUrl)
    {
        return strpos($sCurrentUrl, '&') !== false ? strrchr($sCurrentUrl, '?') : strrchr($sCurrentUrl, '?');
    }
}