For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 16 and the first side effect is on line 10.
The PSR-1: Basic Coding Standard recommends that a file should either introduce
new symbols, that is classes, functions, constants or similar, or have side effects.
Side effects are anything that executes logic, like for example printing output,
changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state
of an application. It also promotes a cleaner style of programming and makes your code
less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the
PSR-1.
and let’s assume the following content of Bar.php:
// Bar.phpnamespaceOtherDir;useSomeDir\Foo;// This now conflicts the class OtherDir\Foo
If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the
same runtime, you will see a PHP error such as the following:
PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as OtherDir/Foo.php does not necessarily have to be loaded and the
error is only triggered if it is loaded before OtherDir/Bar.php, this problem
might go unnoticed for a while. In order to prevent this error from surfacing,
you must import the namespace with a different alias:
// Bar.phpnamespaceOtherDir;useSomeDir\FooasSomeDirFoo;// There is no conflict anymore.
Loading history...
15
16
class DisableModuleFormProcess extends Form
17
{
18
public function __construct()
19
{
20
parent::__construct();
21
22
$oModuleModel = new ModuleModel;
23
24
// First, disable all mods as uncheckboxes elements aren't send throughth the form
25
$this->disableMods($oModuleModel);
26
27
// Then, enable the mods selected to be enabled
28
foreach($this->httpRequest->post('module_id') as $iModId) {
29
$oModuleModel->update($iModId, '1'); // Need to be string because in DB it's an "enum" type
30
}
31
unset($oModuleModel);
32
33
$this->clearCache();
34
35
\PFBC\Form::setSuccess('form_module', t('Module Status have been saved!'));
36
}
37
38
protected function disableMods(ModuleModel $oModuleModel)
39
{
40
foreach ($oModuleModel->get() as $oMod) {
41
// Need to be string because in DB it's an "enum" type
42
$oModuleModel->update($oMod->moduleId, '0');
43
}
44
}
45
46
private function clearCache()
47
{
48
(new Cache)->start(ModuleModel::CACHE_GROUP, null, null)->clear();
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.