PH7\AdsFormProcess

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	20	2
A	clearCache()	0	5	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 18 and the first side effect is on line 10.

/**
 * @author         Pierre-Henry Soria <ph7software@gmail.com>
 * @copyright      (c) 2012-2017, Pierre-Henry Soria. All Rights Reserved.
 * @license        GNU General Public License; See PH7.LICENSE.txt and PH7.COPYRIGHT.txt in the root directory.
 * @package        PH7 / App / System / Module / Admin / From / Processing
 */
namespace PH7;

defined('PH7') or exit('Restricted access');

use

There must be a single space after the USE keyword

PH7\Framework\Cache\Cache,
PH7\Framework\Mvc\Request\Http,
PH7\Framework\Mvc\Router\Uri,
PH7\Framework\Url\Header;

class AdsFormProcess extends Form
{
    public function __construct()
    {
        parent::__construct();

        $iIsAff = (AdsCore::getTable() == 'AdsAffiliates');

        $sTable = AdsCore::getTable();
        $sTitle = $this->httpRequest->post('title');
        $sCode = $this->httpRequest->post('code', Http::NO_CLEAN);
        $aSize = explode('x', $this->httpRequest->post('size'));
        $iWidth = $aSize[0];
        $iHeight = $aSize[1];

        (new AdsCoreModel)->add($sTitle, $sCode, $iWidth, $iHeight, $sTable);

        $this->clearCache();

        $sSlug = ($iIsAff) ? 'affiliate' : '';
        Header::redirect(Uri::get(PH7_ADMIN_MOD, 'setting', 'ads', $sSlug), t('The banner has been added!'));
    }

    /**
     * Clean AdminCoreModel Ads and Model\Design for STATIC data.
     *
     * @return void
     */
    private function clearCache()
    {
        (new Cache)->start(Framework\Mvc\Model\Design::CACHE_STATIC_GROUP, null, null)->clear()
            ->start(AdsCoreModel::CACHE_GROUP, 'totalAds' . ($iIsAff ? 'Affiliates' : ''), null)->clear();

The variable $iIsAff does not exist. Did you forget to declare it?

    }
}