Sludio\HelperBundle\Translatable\Twig\TranslationExtension

Complexity

Total Complexity

11

Size/Duplication

Total Lines	60
Duplicated Lines	38.33 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	6	2
A	getName()	0	3	1
A	getFilters()	16	20	2
B	getVar()	0	17	6

<?php

namespace Sludio\HelperBundle\Translatable\Twig;

use Twig_Extension;
use Twig_SimpleFilter;

class TranslationExtension extends Twig_Extension

The property $short_functions is not named in camelCase.

{
    protected $em;

Avoid variables with short names like $em. Configured minimum length is 3.

    protected $request;
    protected $defaultLocale;
    protected $short_functions;

    public function __construct($em, $request_stack, $default, $container)

This method seems to be duplicated in your project.

Avoid variables with short names like $em. Configured minimum length is 3.

The parameter $request_stack is not named in camelCase.

    {
        $this->em = $em;
        $this->request = $request_stack->getCurrentRequest();
        $this->defaultLocale = $default;
        $this->short_functions = $container->hasParameter('sludio_helper.script.short_functions') && $container->getParameter('sludio_helper.script.short_functions', false);
    }

    public function getName()
    {
        return 'sludio_helper.twig.translate_extension';
    }

    public function getFilters()

This method seems to be duplicated in your project.

    {
        $array = [
            new Twig_SimpleFilter('sludio_var', [
                $this,
                'getVar',
            ]),
        ];

        $short_array = [
            new Twig_SimpleFilter('var', [
                $this,
                'getVar',
            ]),
        ];

        if ($this->short_functions) {
            return array_merge($array, $short_array);
        } else {
            return $array;
        }
    }

    public function getVar($type, $object, $original = false, $locale = null)
    {
        if ($object && is_object($object)) {
            $hl = $this->request ? $this->request->cookies->get('hl') : $this->defaultLocale;

Avoid variables with short names like $hl. Configured minimum length is 3.

            $new_locale = $locale;
            if (!$locale) {
                $new_locale = $this->request ? $this->request->get('_locale') : $hl;
            }

            $trans = $object->getVariableByLocale($type, $new_locale, $original);
            $class = get_class($object);
            $class = str_replace('Proxies\__CG__\\', '', $class);

The assignment to $class is dead and can be removed.

            return $trans;
        } else {
            return $type;
        }
    }
}