Sludio\HelperBundle\Script\Twig\BrowserExtension

Complexity

Total Complexity

9

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	2
A	isIE()	0	9	4
A	getFunctions()	0	20	2
A	getName()	0	3	1

<?php

namespace Sludio\HelperBundle\Script\Twig;

use Symfony\Component\HttpFoundation\Request;
use Twig_Extension;
use Twig_SimpleFunction;

class BrowserExtension extends Twig_Extension

The property $short_functions is not named in camelCase.

{
    protected $short_functions;

    public function __construct($container)
    {
        $this->short_functions = $container->hasParameter('sludio_helper.script.short_functions') && $container->getParameter('sludio_helper.script.short_functions', false);
    }

    public function getFunctions()
    {
        $array = [
            new Twig_SimpleFunction('sludio_is_ie', [
                $this,
                'isIE',
            ]),
        ];

        $short_array = [
            new Twig_SimpleFunction('is_ie', [
                $this,
                'isIE',
            ]),
        ];

        if ($this->short_functions) {
            return array_merge($array, $short_array);
        } else {
            return $array;
        }
    }

    public function getName()
    {
        return 'sludio_helper.twig.browser_extension';
    }

    public function isIE()

This method's name is shorter than the configured minimum length of 5 characters.

    {
        $request = Request::createFromGlobals();
        $ua = $request->server->get('HTTP_USER_AGENT');

Avoid variables with short names like $ua. Configured minimum length is 3.

        if (strpos($ua, 'MSIE') || strpos($ua, 'Edge') || strpos($ua, 'Trident/7')) {
            return 1;
        }

        return 0;
    }
}