Sludio\HelperBundle\DependencyInjection\Component\Openid

Complexity

Total Complexity

11

Size/Duplication

Total Lines	69
Duplicated Lines	23.19 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
D	configure()	16	36	9
A	configureClient()	0	8	1
A	buildClientConfiguration()	0	18	1

<?php

namespace Sludio\HelperBundle\DependencyInjection\Component;

use Symfony\Component\Config\Definition\Builder\NodeDefinition;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\Processor;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Reference;

class Openid implements Extensionable
{
    public function configure(ContainerBuilder &$container)
    {
        $clientConfigurations = $container->getParameter('sludio_helper.openid.clients');
        foreach ($clientConfigurations as $key => $clientConfig) {
            $tree = new TreeBuilder();
            $node = $tree->root('sludio_helper_openid_client/clients/'.$key);
            $this->buildClientConfiguration($node);
            $processor = new Processor();
            $config = $processor->process($tree->buildTree(), [$clientConfig]);
            $clientServiceKey = 'sludio_helper.openid.client.'.$key;
            $service = [
                'key' => $clientServiceKey,
            ];
            if (isset($config['provider_options']) && isset($config['provider_options']['name'])) {

This code seems to be duplicated across your project.

                $service['name'] = $config['provider_options']['name'];
            } else {
                $service['name'] = ucfirst($key);
            }

            $clientServiceKeys[$key] = $service;
            foreach ($config as $ckey => $cvalue) {

This code seems to be duplicated across your project.

                if ($ckey === 'provider_options') {
                    if (is_array($cvalue)) {
                        foreach ($cvalue as $pkey => $pvalue) {
                            $container->setParameter($clientServiceKey.'.option.'.$pkey, $pvalue);
                        }
                    }
                } else {
                    $container->setParameter($clientServiceKey.'.'.$ckey, $cvalue);
                }
            }
            $this->configureClient($container, $clientServiceKey);
        }
        $container->getDefinition('sludio_helper.openid.registry')->replaceArgument(1, $clientServiceKeys);

The variable $clientServiceKeys seems to be defined by a foreach iteration on line 16. Are you sure the iterator is never empty, otherwise this variable is not defined?

        if ($container->getParameter('sludio_helper.oauth.enabled', false)) {

The call to Symfony\Component\DependencyInjection\Container::getParameter() has too many arguments starting with false.

            $container->getDefinition('sludio_helper.registry')->replaceArgument(2, $clientServiceKeys);
        }
    }

    public function buildClientConfiguration(NodeDefinition &$node)
    {
        $optionsNode = $node->children();

        // @formatter:off
        $optionsNode
            ->scalarNode('api_key')->isRequired()->cannotBeEmpty()->end()
            ->scalarNode('openid_url')->isRequired()->cannotBeEmpty()->end()
            ->scalarNode('preg_check')->isRequired()->cannotBeEmpty()->end()
            ->scalarNode('ns_mode')->defaultValue('sreg')->end()
            ->scalarNode('user_class')->isRequired()->end()
            ->scalarNode('user_provider')->defaultValue('Sludio\HelperBundle\Openid\Login\Login')->end()
            ->scalarNode('redirect_route')->isRequired()->cannotBeEmpty()->end()
            ->arrayNode('provider_options')->prototype('variable')->end()->end()
        ;
        // @formatter:on

        $optionsNode->end();
    }

    public function configureClient(ContainerBuilder $container, $clientServiceKey, array $options = [])
    {
        $clientDefinition = $container->register($clientServiceKey, $container->getParameter($clientServiceKey.'.user_provider'));
        $clientDefinition->setArguments([
            $clientServiceKey,
            new Reference('request_stack'),
            new Reference('service_container'),
            new Reference('router'),
        ]);
    }
}