Issues in WebTranslateItRepositoryTest.php (master) - Issues in master - ozean12/WebTranslateItBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (7)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Tests/Service/WebTranslateItRepositoryTest.php (3 issues)

Labels

Bug 3

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Ozean12\WebTranslateItBundle\Tests\Service;

use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Response;
use JMS\Serializer\SerializerInterface;
use Ozean12\WebTranslateItBundle\DTO\ProjectDTO;
use Ozean12\WebTranslateItBundle\DTO\PullProjectResponseDTO;
use Ozean12\WebTranslateItBundle\Service\WebTranslateItRepository;

/**
 * Class WebTranslateItRepositoryTest
 */
class WebTranslateItRepositoryTest extends \PHPUnit_Framework_TestCase
{
    const READ_KEY = 'test_key';
    const BASE_URL = 'test_base_url/';

    const FILE_URL = 'base_url/{token}/files/...?file_path={name}';
    const FILE_NAME = 'test_messages.en.yml';

    const PROJECT_URL_NORMALIZED = 'test_base_url/projects/test_key.json';
    const FILE_URL_NORMALIZED = 'test_base_url/projects/test_key/files/...?file_path=test_messages.en.yml';

    /**
     * @var WebTranslateItRepository
     */
    private $repository;

    /**
     * @var SerializerInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $serializer;

    /**
     * @var Client|\PHPUnit_Framework_MockObject_MockObject
     */
    private $client;

    /**
     * SetUp
     */
    public function setUp()
    {
        $this->serializer = $this->getMockBuilder(SerializerInterface::class)->getMock();
        $this->client = $this->getMockBuilder(Client::class)->setMethods(['get'])->getMock();

        $this->repository = new WebTranslateItRepository(
            self::READ_KEY,
            self::BASE_URL,
            $this->client,
            $this->serializer
        );

        parent::setUp();
    }

    /**
     * Test project pull
     */
    public function testPullProject()
    {
        $responseString = $this->getPullProjectResponseString();
        $response = new Response(200, [], $responseString);

        $this->client
            ->method('get')
            ->willReturn($response)
        ;

        $this->client
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('get')
            ->with(self::PROJECT_URL_NORMALIZED)
        ;

        $this->serializer
            ->method('deserialize')
            ->willReturn($this->getProjectDTO())
        ;

        $this->serializer
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('deserialize')
            ->with($responseString, PullProjectResponseDTO::class, WebTranslateItRepository::FORMAT_JSON)
        ;

        $this->assertEquals($this->getProjectDTO(), $this->repository->pullProject());
    }

    /**
     * Test pull file
     */
    public function testPullFile()
    {
        $responseString = $this->getPullFileResponseString();
        $response = new Response(200, [], $responseString);

        $this->client
            ->method('get')
            ->willReturn($response)
        ;

        $this->client
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('get')
            ->with(self::FILE_URL_NORMALIZED)
        ;

        $this->assertEquals($responseString, $this->repository->pullFile(self::FILE_NAME));
    }

    /**
     * @return string
     */
    private function getPullProjectResponseString()
    {
        return '{"project":{"id":"45"}}';
    }

    /**
     * @return ProjectDTO
     */
    private function getProjectDTO()
    {
        $projectDTO = new ProjectDTO();

        return $projectDTO
            ->setId(45)
            ->setName('test')
        ;
    }

    /**
     * @return string
     */
    private function getPullFileResponseString()
    {
        return 'hello: Hello';
    }
}


1			<?php
2
3			namespace Ozean12\WebTranslateItBundle\Tests\Service;
4
5			use GuzzleHttp\Client;
6			use GuzzleHttp\Psr7\Response;
7			use JMS\Serializer\SerializerInterface;
8			use Ozean12\WebTranslateItBundle\DTO\ProjectDTO;
9			use Ozean12\WebTranslateItBundle\DTO\PullProjectResponseDTO;
10			use Ozean12\WebTranslateItBundle\Service\WebTranslateItRepository;
11
12			/**
13			* Class WebTranslateItRepositoryTest
14			*/
15			class WebTranslateItRepositoryTest extends \PHPUnit_Framework_TestCase
16			{
17			const READ_KEY = 'test_key';
18			const BASE_URL = 'test_base_url/';
19
20			const FILE_URL = 'base_url/{token}/files/...?file_path={name}';
21			const FILE_NAME = 'test_messages.en.yml';
22
23			const PROJECT_URL_NORMALIZED = 'test_base_url/projects/test_key.json';
24			const FILE_URL_NORMALIZED = 'test_base_url/projects/test_key/files/...?file_path=test_messages.en.yml';
25
26			/**
27			* @var WebTranslateItRepository
28			*/
29			private $repository;
30
31			/**
32			* @var SerializerInterface\|\PHPUnit_Framework_MockObject_MockObject
33			*/
34			private $serializer;
35
36			/**
37			* @var Client\|\PHPUnit_Framework_MockObject_MockObject
38			*/
39			private $client;
40
41			/**
42			* SetUp
43			*/
44			public function setUp()
45			{
46			$this->serializer = $this->getMockBuilder(SerializerInterface::class)->getMock();
47			$this->client = $this->getMockBuilder(Client::class)->setMethods(['get'])->getMock();
48
49			$this->repository = new WebTranslateItRepository(
50			self::READ_KEY,
51			self::BASE_URL,
52			$this->client,
53			$this->serializer
54			);
55
56			parent::setUp();
57			}
58
59			/**
60			* Test project pull
61			*/
62			public function testPullProject()
63			{
64			$responseString = $this->getPullProjectResponseString();
65			$response = new Response(200, [], $responseString);
66
67			$this->client
68			->method('get')
69			->willReturn($response)
70			;
71
72			$this->client
			0 ignored issues – show Bug introduced 2016-12-23 10:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `GuzzleHttp\Client`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
73			->expects($this->once())
74			->method('get')
75			->with(self::PROJECT_URL_NORMALIZED)
76			;
77
78			$this->serializer
79			->method('deserialize')
80			->willReturn($this->getProjectDTO())
81			;
82
83			$this->serializer
			0 ignored issues – show Bug introduced 2016-12-23 10:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `JMS\Serializer\SerializerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
84			->expects($this->once())
85			->method('deserialize')
86			->with($responseString, PullProjectResponseDTO::class, WebTranslateItRepository::FORMAT_JSON)
87			;
88
89			$this->assertEquals($this->getProjectDTO(), $this->repository->pullProject());
90			}
91
92			/**
93			* Test pull file
94			*/
95			public function testPullFile()
96			{
97			$responseString = $this->getPullFileResponseString();
98			$response = new Response(200, [], $responseString);
99
100			$this->client
101			->method('get')
102			->willReturn($response)
103			;
104
105			$this->client
			0 ignored issues – show Bug introduced 2016-12-23 10:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `GuzzleHttp\Client`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
106			->expects($this->once())
107			->method('get')
108			->with(self::FILE_URL_NORMALIZED)
109			;
110
111			$this->assertEquals($responseString, $this->repository->pullFile(self::FILE_NAME));
112			}
113
114			/**
115			* @return string
116			*/
117			private function getPullProjectResponseString()
118			{
119			return '{"project":{"id":"45"}}';
120			}
121
122			/**
123			* @return ProjectDTO
124			*/
125			private function getProjectDTO()
126			{
127			$projectDTO = new ProjectDTO();
128
129			return $projectDTO
130			->setId(45)
131			->setName('test')
132			;
133			}
134
135			/**
136			* @return string
137			*/
138			private function getPullFileResponseString()
139			{
140			return 'hello: Hello';
141			}
142			}
143

GitHub Access Token became invalid

Issues (7)

Security Analysis no request data

Tests/Service/WebTranslateItRepositoryTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

ozean12 / WebTranslateItBundle

GitHub Access Token became invalid

Issues (7)

Security Analysis no request data

Tests/Service/WebTranslateItRepositoryTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like