Ozean12\GooglePubSubBundle\Tests\Service\PublisherTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	137
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	9	1
A	testPublish()	0	51	2
B	getTestPublishData()	0	28	1
A	getTopicMock()	0	7	1
A	getClientMock()	0	7	1

<?php

namespace Ozean12\GooglePubSubBundle\Tests\Service;

use Google\Cloud\Core\Exception\ConflictException;
use Google\Cloud\PubSub\PubSubClient;
use Google\Cloud\PubSub\Topic;
use JMS\Serializer\Serializer;
use JMS\Serializer\SerializerBuilder;
use Ozean12\GooglePubSubBundle\Service\Publisher\Publisher;
use Ozean12\GooglePubSubBundle\Tests\DTO\TestPublishMessageDTO;
use Ozean12\GooglePubSubBundle\Tests\DTO\TestPublishMessageResultDTO;

/**
 * Class PublisherTest
 */
class PublisherTest extends \PHPUnit_Framework_TestCase
{
    const TOPIC = 'test_topic';

    /**
     * @var Serializer|\PHPUnit_Framework_MockObject_MockObject
     */
    private $serializer;

    /**
     * SetUp
     */
    public function setUp()
    {
        $this->serializer = $this->getMockBuilder('JMS\Serializer\Serializer')
            ->disableOriginalConstructor()
            ->getMock()
        ;

        parent::setUp();
    }

    /**
     * @dataProvider getTestPublishData
     *
     * @param Topic|\PHPUnit_Framework_MockObject_MockObject        $topic
     * @param PubSubClient|\PHPUnit_Framework_MockObject_MockObject $client
     * @param bool                                                  $setLogger
     * @param int                                                   $logInfoCallsCount
     * @param string                                                $message
     */
    public function testPublish(Topic $topic, PubSubClient $client, $setLogger, $logInfoCallsCount, $message)

The parameter $message is not used and could be removed.

    {
        $publisher = new Publisher(self::TOPIC, $client, $this->serializer);

        $message = new TestPublishMessageDTO(uniqid('test_'));
        $result = (new TestPublishMessageResultDTO())
            ->setMessageIds([uniqid('test_')])
        ;

        $serializer = SerializerBuilder::create()->build();
        $serializedData = $serializer->serialize($message, 'json');
        $serializedResult = $serializer->toArray($result);

        $this->serializer

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in JMS\Serializer\Serializer.

            ->expects($this->once())
            ->method('serialize')
            ->with($message, 'json')
            ->willReturn($serializedData)
        ;

        $this->serializer
            ->expects($this->once())
            ->method('fromArray')
            ->with($serializedResult)
            ->willReturn($result)
        ;

        $topic

The method expects() does not seem to exist on object<Google\Cloud\PubSub\Topic>.

            ->expects($this->once())
            ->method('publish')
            ->with(['data' => $serializedData], [])
            ->willReturn($serializedResult)
        ;

        if ($setLogger) {
            $logger = $this->getMockBuilder('Psr\Log\LoggerInterface')
                ->disableOriginalConstructor()
                ->getMock()
            ;

            $logger
                ->expects($this->exactly($logInfoCallsCount))
                ->method('info')
            ;

            $publisher->setLogger($logger);
        }

        $actualResult = $publisher->publish($message);
        $this->assertEquals($result, $actualResult);
    }

    /**
     * @return array
     */
    public function getTestPublishData()
    {
        $newTopic = $this->getTopicMock();
        $newTopicWithLogger = $this->getTopicMock();
        $existingTopic = $this->getTopicMock();
        $existingTopicWithLogger = $this->getTopicMock();

        $newTopicClient = $this->getClientMock();
        $newTopicClientWithLogger = $this->getClientMock();
        $existingTopicClient = $this->getClientMock();
        $existingTopicClientWithLogger = $this->getClientMock();

        $newTopicClient->expects($this->once())->method('createTopic')->with(self::TOPIC)->willReturn($newTopic);

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in Google\Cloud\PubSub\PubSubClient.

        $newTopicClientWithLogger->expects($this->once())->method('createTopic')->with(self::TOPIC)->willReturn($newTopicWithLogger);

        $existingTopicClient->expects($this->once())->method('createTopic')->willThrowException(new ConflictException('test'));
        $existingTopicClient->expects($this->once())->method('topic')->with(self::TOPIC)->willReturn($existingTopic);

        $existingTopicClientWithLogger->expects($this->once())->method('createTopic')->willThrowException(new ConflictException('test'));
        $existingTopicClientWithLogger->expects($this->once())->method('topic')->with(self::TOPIC)->willReturn($existingTopicWithLogger);

        return [
            [$newTopic, $newTopicClient, false, 0, 'New topic'],
            [$newTopicWithLogger, $newTopicClientWithLogger, true, 2, 'New topic with logger'],
            [$existingTopic, $existingTopicClient, false, 0, 'Existing topic'],
            [$existingTopicWithLogger, $existingTopicClientWithLogger, true, 1, 'Existing topic with logger'],
        ];
    }

    /**
     * @return Topic|\PHPUnit_Framework_MockObject_MockObject
     */
    private function getTopicMock()
    {
        return $this->getMockBuilder('Google\Cloud\PubSub\Topic')
            ->disableOriginalConstructor()
            ->getMock()
        ;
    }

    /**
     * @return PubSubClient|\PHPUnit_Framework_MockObject_MockObject
     */
    private function getClientMock()
    {
        return $this->getMockBuilder('Google\Cloud\PubSub\PubSubClient')
            ->disableOriginalConstructor()
            ->getMock()
        ;
    }
}