owncourses / courses-server

src/Serializer/CourseNormalizer.php

<?php

declare(strict_types=1);

namespace App\Serializer;

use App\Model\CourseInterface;
use App\Serializer\Processor\FileHrefProcessor;
use App\Serializer\Processor\ProgressProcessor;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;

class CourseNormalizer implements NormalizerInterface
{
    private $normalizer;
    private $fileHrefProcessor;
    private $progressProcessor;

    public function __construct(
        ObjectNormalizer $normalizer,
        FileHrefProcessor $fileHrefProcessor,
        ProgressProcessor $progressProcessor
    ) {
        $this->normalizer = $normalizer;
        $this->fileHrefProcessor = $fileHrefProcessor;
        $this->progressProcessor = $progressProcessor;
    }

    public function normalize($object, $format = null, array $context = [])
    {
        if (!$object instanceof CourseInterface) {
            return [];
        }

        $data = $this->normalizer->normalize($object, $format, $context);
        $data = $this->fileHrefProcessor->process($object, $data);

It seems like $data can also be of type ArrayObject; however, parameter $data of App\Serializer\Processor\FileHrefProcessor::process() does only seem to accept array, maybe add an additional type check?

        $data = $this->progressProcessor->process($object, $data);

        return $data;
    }

    public function supportsNormalization($data, $format = null): bool
    {
        return $data instanceof CourseInterface;
    }
}