App\Controller\ApiNotificationsController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	markAsRead()	0	19	2
A	list()	0	11	1
A	__construct()	0	7	1
A	getNumberOfUnreadNotifications()	0	17	4

<?php

namespace App\Controller;

use App\Model\UserInterface;
use App\Repository\NotificationRepositoryInterface;
use Doctrine\ORM\EntityManagerInterface;
use SWP\Component\Common\Exception\NotFoundHttpException;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Serializer\SerializerInterface;

class ApiNotificationsController extends AbstractController
{
    protected SerializerInterface $serializer;

    private NotificationRepositoryInterface $notificationRepository;

    public function __construct(
        SerializerInterface $serializer,
        NotificationRepositoryInterface $notificationRepository
    )
    {
        $this->serializer = $serializer;
        $this->notificationRepository = $notificationRepository;
    }

    public function list(): Response
    {
        $notifications = $this->notificationRepository->findAll();

The method findAll() does not exist on App\Repository\NotificationRepositoryInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to App\Repository\NotificationRepositoryInterface.

        /** @var UserInterface $user */
        $user = $this->getUser();

        return new Response($this->serializer->serialize(
            [
                'notifications' => $notifications,
                'unread' => $this->getNumberOfUnreadNotifications($notifications, $user)
            ], 'json', ['groups' => ['list']]));
    }

    public function markAsRead(string $uuid, EntityManagerInterface $entityManager): Response
    {
        $notification = $this->notificationRepository->findOneBy(['id' =>$uuid]);

The method findOneBy() does not exist on App\Repository\NotificationRepositoryInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to App\Repository\NotificationRepositoryInterface.

        if (null === $notification) {
            throw new NotFoundHttpException('Notification was not found');
        }

        /** @var UserInterface $user */
        $user = $this->getUser();
        $user->addNotification($notification);
        $entityManager->flush();

        $notifications = $this->notificationRepository->findAll();

        return new Response($this->serializer->serialize(
            [
                'notifications' => $notifications,
                'unread' => $this->getNumberOfUnreadNotifications($notifications, $user)
            ], 'json', ['groups' => ['list']]), 201);
    }

    private function getNumberOfUnreadNotifications(array $notifications, UserInterface $user): int
    {
        $readByUserNotifications = \array_map(function ($notification) {
            return $notification->getId();
        }, $user->getNotifications()->toArray());

        if (0 === count($readByUserNotifications)) {
            return count($notifications);
        }

        foreach ($notifications as $key => $notification) {
            if (in_array($notification->getId(), $readByUserNotifications)) {
                unset($notifications[$key]);
            }
        }

        return count($notifications);
    }
}