Course::unserialize() - Code Metrics - Inspection of "Feature/lesson attachments" - owncourses/courses-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#12)

by Paweł

created 2019-05-13 06:19 UTC

Course::unserialize() A

↳ Parent: Course

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace App\Entity;

use App\Model\CourseInterface;
use App\Model\TimeLimitedAwareTrait;
use App\Model\TimestampableAwareTrait;
use App\Model\VisibilityAwareTrait;
use Serializable;
use Symfony\Component\HttpFoundation\File\File;

class Course implements CourseInterface, Serializable
{
    use TimestampableAwareTrait, VisibilityAwareTrait, TimeLimitedAwareTrait;

    private $id;

    private $title;

    private $description;

    private $coverImageName;

    /**
     * Hack for PropertyInfo issues with File.
     *
     * @var null
     */
    private $coverImageFile;

    public function __construct()
    {
        $this->visible = true;
    }

    public function getId(): ?int
    {
        return $this->id;
    }

    public function getTitle(): ?string
    {
        return $this->title;
    }

    public function setTitle(string $title): void
    {
        $this->title = $title;
    }

    public function getDescription(): ?string
    {
        return $this->description;
    }

    public function setDescription(string $description): void
    {
        $this->description = $description;
    }

    public function getCoverImageName(): ?string
    {
        return $this->coverImageName;
    }

    public function setCoverImageName(?string $coverImageName): void
    {
        $this->coverImageName = $coverImageName;
    }

    public function setCoverImageFile(?File $coverImageFile = null): void
    {
        $this->coverImageFile = $coverImageFile;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->updated = new \DateTime();
    }

    public function getCoverImageFile(): ?File
    {
        return $this->coverImageFile;
    }

    public function serialize(): void
    {
        $this->coverImageFile = null;
    }

    public function unserialize($serialized): void
    {
        $this->coverImageFile = null;
    }

    public function __toString()
    {
        return (string) ($this->title ?? 'New course');
    }
}


1			<?php
2
3			namespace App\Entity;
4
5			use App\Model\CourseInterface;
6			use App\Model\TimeLimitedAwareTrait;
7			use App\Model\TimestampableAwareTrait;
8			use App\Model\VisibilityAwareTrait;
9			use Serializable;
10			use Symfony\Component\HttpFoundation\File\File;
11
12			class Course implements CourseInterface, Serializable
13			{
14			use TimestampableAwareTrait, VisibilityAwareTrait, TimeLimitedAwareTrait;
15
16			private $id;
17
18			private $title;
19
20			private $description;
21
22			private $coverImageName;
23
24			/**
25			* Hack for PropertyInfo issues with File.
26			*
27			* @var null
28			*/
29			private $coverImageFile;
30
31			public function __construct()
32			{
33			$this->visible = true;
34			}
35
36			public function getId(): ?int
37			{
38			return $this->id;
39			}
40
41			public function getTitle(): ?string
42			{
43			return $this->title;
44			}
45
46			public function setTitle(string $title): void
47			{
48			$this->title = $title;
49			}
50
51			public function getDescription(): ?string
52			{
53			return $this->description;
54			}
55
56			public function setDescription(string $description): void
57			{
58			$this->description = $description;
59			}
60
61			public function getCoverImageName(): ?string
62			{
63			return $this->coverImageName;
64			}
65
66			public function setCoverImageName(?string $coverImageName): void
67			{
68			$this->coverImageName = $coverImageName;
69			}
70
71			public function setCoverImageFile(?File $coverImageFile = null): void
72			{
73			$this->coverImageFile = $coverImageFile;
			0 ignored issues – show Documentation Bug introduced 2019-05-10 05:31 UTC by Report Bug Copy Issue Report It seems like `$coverImageFile` can also be of type `Symfony\Component\HttpFoundation\File\File`. However, the property `$coverImageFile` is declared as type `null`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
74			$this->updated = new \DateTime();
75			}
76
77			public function getCoverImageFile(): ?File
78			{
79			return $this->coverImageFile;
80			}
81
82			public function serialize(): void
83			{
84			$this->coverImageFile = null;
85			}
86
87			public function unserialize($serialized): void
88			{
89			$this->coverImageFile = null;
90			}
91
92			public function __toString()
93			{
94			return (string) ($this->title ?? 'New course');
95			}
96			}
97

owncourses / courses-server

Pull Request — master (#12)

Course::unserialize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like