Issues in container.php (master) - Issues in master - owncloud/updater - Measure and Improve Code Quality continuously with Scrutinizer

Issues (52)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/config/container.php (16 issues)

Labels

Unused Code 16

Severity

Minor 16

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @author Victor Dubiniuk <[email protected]>
 *
 * @copyright Copyright (c) 2015, ownCloud, Inc.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

use Pimple\Container;
use GuzzleHttp\Client;
use Owncloud\Updater\Console\Application;
use Owncloud\Updater\Utils\AppManager;
use Owncloud\Updater\Utils\Checkpoint;
use Owncloud\Updater\Utils\ConfigReader;
use Owncloud\Updater\Utils\Fetcher;
use Owncloud\Updater\Utils\FilesystemHelper;
use Owncloud\Updater\Utils\Locator;
use Owncloud\Updater\Utils\OccRunner;
use Owncloud\Updater\Utils\Registry;
use Owncloud\Updater\Command\BackupDataCommand;
use Owncloud\Updater\Command\BackupDbCommand;
use Owncloud\Updater\Command\CheckpointCommand;
use Owncloud\Updater\Command\CheckSystemCommand;
use Owncloud\Updater\Command\CleanCacheCommand;
use Owncloud\Updater\Command\DetectCommand;
use Owncloud\Updater\Command\ExecuteCoreUpgradeScriptsCommand;
use Owncloud\Updater\Command\InfoCommand;
use Owncloud\Updater\Command\MaintenanceModeCommand;
use Owncloud\Updater\Command\PostUpgradeCleanupCommand;
use Owncloud\Updater\Command\PostUpgradeRepairCommand;
use Owncloud\Updater\Command\PreUpgradeRepairCommand;
use Owncloud\Updater\Command\RestartWebServerCommand;
use Owncloud\Updater\Command\UpdateConfigCommand;
use Owncloud\Updater\Command\StartCommand;

$c = new Container();

/*
  $c['parameters'] = [
  'locator.file' => 'locator.xml'
  ];
 */

$c['guzzle.httpClient'] = function($c){

	return new Client();
};

$c['utils.locator'] = function($c){

	return new Locator(CURRENT_DIR);
};

$c['utils.occrunner'] = function($c){
	$disabled = explode(',', ini_get('disable_functions'));
	$isProcOpenEnabled = function_exists('proc_open') && !in_array('proc_open', $disabled);
	return new OccRunner($c['utils.locator'], $isProcOpenEnabled && IS_CLI);
};

$c['utils.registry'] = function($c){

	return new Registry();
};

$c['utils.appmanager'] = function($c){
	return new AppManager($c['utils.occrunner']);
};
$c['utils.filesystemhelper'] = function($c){

	return new FilesystemHelper();
};
$c['utils.checkpoint'] = function($c){
	return new Checkpoint($c['utils.locator'], $c['utils.filesystemhelper']);
};
$c['utils.configReader'] = function($c){
	return new ConfigReader($c['utils.occrunner']);
};
$c['utils.fetcher'] = function($c){
	return new Fetcher($c['guzzle.httpClient'], $c['utils.locator'], $c['utils.configReader']);
};

$c['command.backupData'] = function($c){

	return new BackupDataCommand();
};
$c['command.backupDb'] = function($c){

	return new BackupDbCommand();
};
$c['command.checkpoint'] = function($c){

	return new CheckpointCommand();
};
$c['command.checkSystem'] = function($c){

	return new CheckSystemCommand();
};
$c['command.cleanCache'] = function($c){

	return new CleanCacheCommand();
};
$c['command.detect'] = function($c){
	return new DetectCommand($c['utils.fetcher'], $c['utils.configReader']);
};
$c['command.executeCoreUpgradeScripts'] = function($c){
	return new ExecuteCoreUpgradeScriptsCommand($c['utils.occrunner']);
};
$c['command.info'] = function($c){

	return new InfoCommand();
};
$c['command.maintenanceMode'] = function($c){
	return new MaintenanceModeCommand($c['utils.occrunner']);
};
$c['command.postUpgradeCleanup'] = function($c){

	return new PostUpgradeCleanupCommand();
};
$c['command.postUpgradeRepair'] = function($c){

	return new PostUpgradeRepairCommand();
};
$c['command.preUpgradeRepair'] = function($c){

	return new PreUpgradeRepairCommand();
};
$c['command.restartWebServer'] = function($c){

	return new RestartWebServerCommand();
};
$c['command.updateCoreConfig'] = function($c){

	return new UpdateConfigCommand();
};
$c['command.start'] = function($c){

	return new StartCommand();
};

$c['commands'] = function($c){
	return [
		$c['command.backupData'],
		$c['command.backupDb'],
		$c['command.checkpoint'],
		$c['command.checkSystem'],
		$c['command.cleanCache'],
		$c['command.detect'],
		$c['command.executeCoreUpgradeScripts'],
		$c['command.info'],
		$c['command.maintenanceMode'],
		$c['command.postUpgradeCleanup'],
		$c['command.postUpgradeRepair'],
		$c['command.preUpgradeRepair'],
		$c['command.restartWebServer'],
		$c['command.updateCoreConfig'],
		$c['command.start'],
	];
};

$c['application'] = function($c){
	$application = new Application('ownCloud updater', '1.0.1');
	$application->setContainer($c);
	$application->addCommands($c['commands']);
	$application->setDefaultCommand($c['command.start']->getName());
	return $application;
};

return $c;


1			<?php
2			/**
3			* @author Victor Dubiniuk <[email protected]>
4			*
5			* @copyright Copyright (c) 2015, ownCloud, Inc.
6			* @license AGPL-3.0
7			*
8			* This code is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU Affero General Public License, version 3,
10			* as published by the Free Software Foundation.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License, version 3,
18			* along with this program. If not, see <http://www.gnu.org/licenses/>
19			*
20			*/
21
22			use Pimple\Container;
23			use GuzzleHttp\Client;
24			use Owncloud\Updater\Console\Application;
25			use Owncloud\Updater\Utils\AppManager;
26			use Owncloud\Updater\Utils\Checkpoint;
27			use Owncloud\Updater\Utils\ConfigReader;
28			use Owncloud\Updater\Utils\Fetcher;
29			use Owncloud\Updater\Utils\FilesystemHelper;
30			use Owncloud\Updater\Utils\Locator;
31			use Owncloud\Updater\Utils\OccRunner;
32			use Owncloud\Updater\Utils\Registry;
33			use Owncloud\Updater\Command\BackupDataCommand;
34			use Owncloud\Updater\Command\BackupDbCommand;
35			use Owncloud\Updater\Command\CheckpointCommand;
36			use Owncloud\Updater\Command\CheckSystemCommand;
37			use Owncloud\Updater\Command\CleanCacheCommand;
38			use Owncloud\Updater\Command\DetectCommand;
39			use Owncloud\Updater\Command\ExecuteCoreUpgradeScriptsCommand;
40			use Owncloud\Updater\Command\InfoCommand;
41			use Owncloud\Updater\Command\MaintenanceModeCommand;
42			use Owncloud\Updater\Command\PostUpgradeCleanupCommand;
43			use Owncloud\Updater\Command\PostUpgradeRepairCommand;
44			use Owncloud\Updater\Command\PreUpgradeRepairCommand;
45			use Owncloud\Updater\Command\RestartWebServerCommand;
46			use Owncloud\Updater\Command\UpdateConfigCommand;
47			use Owncloud\Updater\Command\StartCommand;
48
49			$c = new Container();
50
51			/*
52			$c['parameters'] = [
53			'locator.file' => 'locator.xml'
54			];
55			*/
56
57			$c['guzzle.httpClient'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
58			return new Client();
59			};
60
61			$c['utils.locator'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
62			return new Locator(CURRENT_DIR);
63			};
64
65			$c['utils.occrunner'] = function($c){
66			$disabled = explode(',', ini_get('disable_functions'));
67			$isProcOpenEnabled = function_exists('proc_open') && !in_array('proc_open', $disabled);
68			return new OccRunner($c['utils.locator'], $isProcOpenEnabled && IS_CLI);
69			};
70
71			$c['utils.registry'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
72			return new Registry();
73			};
74
75			$c['utils.appmanager'] = function($c){
76			return new AppManager($c['utils.occrunner']);
77			};
78			$c['utils.filesystemhelper'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
79			return new FilesystemHelper();
80			};
81			$c['utils.checkpoint'] = function($c){
82			return new Checkpoint($c['utils.locator'], $c['utils.filesystemhelper']);
83			};
84			$c['utils.configReader'] = function($c){
85			return new ConfigReader($c['utils.occrunner']);
86			};
87			$c['utils.fetcher'] = function($c){
88			return new Fetcher($c['guzzle.httpClient'], $c['utils.locator'], $c['utils.configReader']);
89			};
90
91			$c['command.backupData'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
92			return new BackupDataCommand();
93			};
94			$c['command.backupDb'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
95			return new BackupDbCommand();
96			};
97			$c['command.checkpoint'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
98			return new CheckpointCommand();
99			};
100			$c['command.checkSystem'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
101			return new CheckSystemCommand();
102			};
103			$c['command.cleanCache'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
104			return new CleanCacheCommand();
105			};
106			$c['command.detect'] = function($c){
107			return new DetectCommand($c['utils.fetcher'], $c['utils.configReader']);
108			};
109			$c['command.executeCoreUpgradeScripts'] = function($c){
110			return new ExecuteCoreUpgradeScriptsCommand($c['utils.occrunner']);
111			};
112			$c['command.info'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
113			return new InfoCommand();
114			};
115			$c['command.maintenanceMode'] = function($c){
116			return new MaintenanceModeCommand($c['utils.occrunner']);
117			};
118			$c['command.postUpgradeCleanup'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
119			return new PostUpgradeCleanupCommand();
120			};
121			$c['command.postUpgradeRepair'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
122			return new PostUpgradeRepairCommand();
123			};
124			$c['command.preUpgradeRepair'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
125			return new PreUpgradeRepairCommand();
126			};
127			$c['command.restartWebServer'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
128			return new RestartWebServerCommand();
129			};
130			$c['command.updateCoreConfig'] = function($c){
			0 ignored issues – show Unused Code introduced 2016-07-05 13:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
131			return new UpdateConfigCommand();
132			};
133			$c['command.start'] = function($c){
			0 ignored issues – show Unused Code introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
134			return new StartCommand();
135			};
136
137			$c['commands'] = function($c){
138			return [
139			$c['command.backupData'],
140			$c['command.backupDb'],
141			$c['command.checkpoint'],
142			$c['command.checkSystem'],
143			$c['command.cleanCache'],
144			$c['command.detect'],
145			$c['command.executeCoreUpgradeScripts'],
146			$c['command.info'],
147			$c['command.maintenanceMode'],
148			$c['command.postUpgradeCleanup'],
149			$c['command.postUpgradeRepair'],
150			$c['command.preUpgradeRepair'],
151			$c['command.restartWebServer'],
152			$c['command.updateCoreConfig'],
153			$c['command.start'],
154			];
155			};
156
157			$c['application'] = function($c){
158			$application = new Application('ownCloud updater', '1.0.1');
159			$application->setContainer($c);
160			$application->addCommands($c['commands']);
161			$application->setDefaultCommand($c['command.start']->getName());
162			return $application;
163			};
164
165			return $c;
166

owncloud / updater

Issues (52)

Security Analysis not enabled

app/config/container.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like