FilesystemHelper::fileExists() - Code Metrics - Inspection of "[WIP] Web UI" - owncloud/updater - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#217)

by Victor

created 2016-01-29 12:57 UTC

FilesystemHelper::fileExists() A

↳ Parent: FilesystemHelper

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php
/**
 * @author Victor Dubiniuk <[email protected]>
 *
 * @copyright Copyright (c) 2015, ownCloud, Inc.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace Owncloud\Updater\Utils;

class FilesystemHelper {

	/**
	 * Wrapper for scandir function
	 * @param string $path
	 * @return array
	 */
	public function scandir($path){
		return scandir($path);
	}

	/**
	 * Wrapper for file_exists function
	 * @param string $path
	 * @return bool
	 */
	public function fileExists($path){
		return file_exists($path);
	}

	/**
	 * Wrapper for is_writable function
	 * @param string $path
	 * @return bool
	 */
	public function isWritable($path){
		return is_writable($path);
	}

	/**
	 * Wrapper for mkdir
	 * @param string $path
	 * @param bool $isRecursive
	 * @throws \Exception on error
	 */
	public function mkdir($path, $isRecursive = false){
		if (!mkdir($path, 0755, $isRecursive)){
			throw new \Exception("Unable to create $path");
		}
	}

	/**
	 * Copy recursive
	 * @param string $src  - source path
	 * @param string $dest - destination path
	 * @throws \Exception on error
	 */
	public function copyr($src, $dest, $stopOnError = true){
		if (is_dir($src)){
			if (!is_dir($dest)){
				try{
					$this->mkdir($dest);
				} catch (\Exception $e){
					if ($stopOnError){
						throw $e;
					}
				}
			}
			$files = scandir($src);
			foreach ($files as $file){
				if (!in_array($file, [".", ".."])){
					$this->copyr("$src/$file", "$dest/$file", $stopOnError);
				}
			}
		} elseif (file_exists($src)){
			if (!copy($src, $dest) && $stopOnError){
				throw new \Exception("Unable to copy $src to $dest");
			}
		}
	}

	/**
	 * Moves file/directory
	 * @param string $src  - source path
	 * @param string $dest - destination path
	 * @throws \Exception on error
	 */
	public function move($src, $dest){
		if (!rename($src, $dest)){
			throw new \Exception("Unable to move $src to $dest");
		}
	}

	/**
	 * Check permissions recursive
	 * @param string $src  - path to check
	 * @param Collection $collection - object to store incorrect permissions
	 */
	public function checkr($src, $collection){
		if (!file_exists($src)){
			return;
		}
		if (!is_writable($src)){
			$collection->addNotWritable($src);
		}
		if (!is_readable($src)){
			$collection->addNotReadable($src);
		}
		if (is_dir($src)){
			$files = scandir($src);
			foreach ($files as $file){
				if (!in_array($file, [".", ".."])){
					$this->checkr("$src/$file", $collection);
				}
			}
		}
	}

	public function removeIfExists($path) {
		if (!file_exists($path)) {
			return;
		}

		if (is_dir($path)) {
			$this->rmdirr($path);
		} else {
			@unlink($path);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		}
	}

	protected function rmdirr($dir) {
		if(is_dir($dir)) {
			$files = scandir($dir);
			foreach($files as $file) {
				if ($file != "." && $file != "..") {
					$this->rmdirr("$dir/$file");
				}
			}
			@rmdir($dir);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		}elseif(file_exists($dir)) {
			@unlink($dir);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		}
		if(file_exists($dir)) {
			return false;
		}else{
			return true;
		}
	}

}


1			<?php
2			/**
3			* @author Victor Dubiniuk <[email protected]>
4			*
5			* @copyright Copyright (c) 2015, ownCloud, Inc.
6			* @license AGPL-3.0
7			*
8			* This code is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU Affero General Public License, version 3,
10			* as published by the Free Software Foundation.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License, version 3,
18			* along with this program. If not, see <http://www.gnu.org/licenses/>
19			*
20			*/
21
22			namespace Owncloud\Updater\Utils;
23
24			class FilesystemHelper {
25
26			/**
27			* Wrapper for scandir function
28			* @param string $path
29			* @return array
30			*/
31			public function scandir($path){
32			return scandir($path);
33			}
34
35			/**
36			* Wrapper for file_exists function
37			* @param string $path
38			* @return bool
39			*/
40			public function fileExists($path){
41			return file_exists($path);
42			}
43
44			/**
45			* Wrapper for is_writable function
46			* @param string $path
47			* @return bool
48			*/
49			public function isWritable($path){
50			return is_writable($path);
51			}
52
53			/**
54			* Wrapper for mkdir
55			* @param string $path
56			* @param bool $isRecursive
57			* @throws \Exception on error
58			*/
59			public function mkdir($path, $isRecursive = false){
60			if (!mkdir($path, 0755, $isRecursive)){
61			throw new \Exception("Unable to create $path");
62			}
63			}
64
65			/**
66			* Copy recursive
67			* @param string $src - source path
68			* @param string $dest - destination path
69			* @throws \Exception on error
70			*/
71			public function copyr($src, $dest, $stopOnError = true){
72			if (is_dir($src)){
73			if (!is_dir($dest)){
74			try{
75			$this->mkdir($dest);
76			} catch (\Exception $e){
77			if ($stopOnError){
78			throw $e;
79			}
80			}
81			}
82			$files = scandir($src);
83			foreach ($files as $file){
84			if (!in_array($file, [".", ".."])){
85			$this->copyr("$src/$file", "$dest/$file", $stopOnError);
86			}
87			}
88			} elseif (file_exists($src)){
89			if (!copy($src, $dest) && $stopOnError){
90			throw new \Exception("Unable to copy $src to $dest");
91			}
92			}
93			}
94
95			/**
96			* Moves file/directory
97			* @param string $src - source path
98			* @param string $dest - destination path
99			* @throws \Exception on error
100			*/
101			public function move($src, $dest){
102			if (!rename($src, $dest)){
103			throw new \Exception("Unable to move $src to $dest");
104			}
105			}
106
107			/**
108			* Check permissions recursive
109			* @param string $src - path to check
110			* @param Collection $collection - object to store incorrect permissions
111			*/
112			public function checkr($src, $collection){
113			if (!file_exists($src)){
114			return;
115			}
116			if (!is_writable($src)){
117			$collection->addNotWritable($src);
118			}
119			if (!is_readable($src)){
120			$collection->addNotReadable($src);
121			}
122			if (is_dir($src)){
123			$files = scandir($src);
124			foreach ($files as $file){
125			if (!in_array($file, [".", ".."])){
126			$this->checkr("$src/$file", $collection);
127			}
128			}
129			}
130			}
131
132			public function removeIfExists($path) {
133			if (!file_exists($path)) {
134			return;
135			}
136
137			if (is_dir($path)) {
138			$this->rmdirr($path);
139			} else {
140			@unlink($path);
			0 ignored issues – show Security Best Practice introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
141			}
142			}
143
144			protected function rmdirr($dir) {
145			if(is_dir($dir)) {
146			$files = scandir($dir);
147			foreach($files as $file) {
148			if ($file != "." && $file != "..") {
149			$this->rmdirr("$dir/$file");
150			}
151			}
152			@rmdir($dir);
			0 ignored issues – show Security Best Practice introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
153			}elseif(file_exists($dir)) {
154			@unlink($dir);
			0 ignored issues – show Security Best Practice introduced 2015-12-21 09:30 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
155			}
156			if(file_exists($dir)) {
157			return false;
158			}else{
159			return true;
160			}
161			}
162
163			}
164

owncloud / updater

Pull Request — master (#217)

FilesystemHelper::fileExists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like