SearchProvider - Code Metrics - Inspection of "Update dependencies" - owncloud/tasks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — DAVclient ( 8808e7...202085 )

by Raimund

created 2016-05-15 11:47 UTC

SearchProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	2
c	2
b	0
f	0
lcom	0
cbo	1
dl	0
loc	22
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	search()	0	3	1

<?php
/**
 * ownCloud - Tasks
 *
 * @author Raimund Schlüßler
 * @copyright 2015 Raimund Schlüßler [email protected]
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
 * License as published by the Free Software Foundation; either
 * version 3 of the License, or any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU AFFERO GENERAL PUBLIC LICENSE for more details.
 *
 * You should have received a copy of the GNU Affero General Public
 * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Tasks\Controller;

use OCA\Tasks\AppInfo\Application;

/**
 * Tasks search provider
 */
class SearchProvider extends \OCP\Search\Provider {

	// private $tasksService;

	public function __construct() {
		$app = new Application();
		$container = $app->getContainer();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$this->app = $app;
		// $this->tasksService = $container->query('TasksService');

	}


	/**
	 * Search for query in tasks
	 *
	 * @param string $query
	 * @return array
	 */
	public function search($query) {
		// return $this->tasksService->search($query);

	}
}


1			<?php
2			/**
3			* ownCloud - Tasks
4			*
5			* @author Raimund Schlüßler
6			* @copyright 2015 Raimund Schlüßler [email protected]
7			*
8			* This library is free software; you can redistribute it and/or
9			* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
10			* License as published by the Free Software Foundation; either
11			* version 3 of the License, or any later version.
12			*
13			* This library is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
17			*
18			* You should have received a copy of the GNU Affero General Public
19			* License along with this library. If not, see <http://www.gnu.org/licenses/>.
20			*
21			*/
22
23			namespace OCA\Tasks\Controller;
24
25			use OCA\Tasks\AppInfo\Application;
26
27			/**
28			* Tasks search provider
29			*/
30			class SearchProvider extends \OCP\Search\Provider {
31
32			// private $tasksService;
33
34			public function __construct() {
35			$app = new Application();
36			$container = $app->getContainer();
			0 ignored issues – show Unused Code introduced 2016-02-13 13:46 UTC by Report Bug Copy Issue Report `$container` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
37			$this->app = $app;
38			// $this->tasksService = $container->query('TasksService');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-13 13:46 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
39			}
40
41
42			/**
43			* Search for query in tasks
44			*
45			* @param string $query
46			* @return array
47			*/
48			public function search($query) {
49			// return $this->tasksService->search($query);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-13 13:46 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50			}
51			}
52

owncloud / tasks

Push — DAVclient ( 8808e7...202085 )

SearchProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like