Issues in PasswordValidatorTest.php (master) - Issues in master - owncloud/security - Measure and Improve Code Quality continuously with Scrutinizer

Issues (40)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/PasswordValidatorTest.php (12 issues)

Labels

Bug 12

Severity

Major 12

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @copyright Copyright (c) 2017 Semih Serhat Karakaya <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */
namespace OCA\Password_Policy\Tests;
use OC\HintException;
use OCA\Security\SecurityConfig;
use OCA\Security\PasswordValidator;
use OCP\IL10N;
use Test\TestCase;
class PasswordValidatorTest extends TestCase {

	/** @var  SecurityConfig|\PHPUnit_Framework_MockObject_MockObject */
	private $config;

	/** @var  IL10N|\PHPUnit_Framework_MockObject_MockObject */
	private $l10n;

	/** @var  PasswordValidator */
	private $passValidator;

	public function setUp() {
		parent::setUp();
		$this->l10n = $this->createMock(IL10N::class);
		$this->config = $this->createMock(SecurityConfig::class);
		$this->passValidator = new PasswordValidator($this->config, $this->l10n);
	}

	/**
	 * @param array $mockedMethods
	 * @return PasswordValidator | \PHPUnit_Framework_MockObject_MockObject
	 */
	private function getMockInstance($mockedMethods = []) {
		$passwordValidator = $this->getMockBuilder('OCA\Security\PasswordValidator')
			->setConstructorArgs([$this->config, $this->l10n])
			->setMethods($mockedMethods)->getMock();
		return $passwordValidator;
	}

	public function testCheckPasswordLength() {
		$this->config->expects($this->exactly(1))->method('getMinPasswordLength')->willReturn(4);

		$this->passValidator->checkPasswordLength('password');
	}
	/**
	 * @expectedException \OC\HintException
	 */
	public function testCheckPasswordLengthFail() {
		$this->config->expects($this->exactly(1))->method('getMinPasswordLength')->willReturn(4);

		$this->passValidator->checkPasswordLength('123');
	}
	/**
	 * @dataProvider dataTestCheckUpperLowerCase
	 *
	 * @param string $password
	 * @param bool $enforceUpperLowerCase
	 */
	public function testCheckUpperLowerCase($password, $enforceUpperLowerCase) {
		$this->config->expects($this->once())->method('getIsUpperLowerCaseEnforced')

			->willReturn($enforceUpperLowerCase);
		$this->passValidator->checkUpperLowerCase($password);
	}
	public function dataTestCheckUpperLowerCase() {
		return [
			['testPass', true],
			['Testpass', true],
			['testpass', false],
			['TESTPASS', false],
		];
	}
	/**
	 * @dataProvider dataTestCheckUpperLowerCaseFail
	 * @param string $password
	 * @expectedException \OC\HintException
	 */
	public function testCheckUpperLowerCaseFail($password) {
		$this->config->expects($this->once())->method('getIsUpperLowerCaseEnforced')->willReturn(true);

		$this->passValidator->checkUpperLowerCase($password);
	}
	public function dataTestCheckUpperLowerCaseFail() {
		return [
			['TESTPASS'], ['testpass']
		];
	}
	/**
	 * @dataProvider dataTestCheckNumericCharacters
	 *
	 * @param string $password
	 * @param bool $enforceNumericCharacters
	 */
	public function testCheckNumericCharacters($password, $enforceNumericCharacters) {
		$this->config->expects($this->once())->method('getIsNumericCharactersEnforced')->willReturn($enforceNumericCharacters);

		$this->passValidator->checkNumericCharacters($password);
	}
	public function dataTestCheckNumericCharacters() {
		return [
			['testPass1', true],
			['testpass', false]
		];
	}
	/**
	 * @dataProvider dataTestCheckNumericCharactersFail
	 * @param string $password
	 * @expectedException \OC\HintException
	 */
	public function testCheckNumericCharactersFail($password) {
		$this->config->expects($this->once())->method('getIsNumericCharactersEnforced')->willReturn(true);

		$this->passValidator->checkNumericCharacters($password);
	}
	public function dataTestCheckNumericCharactersFail() {
		return [
			['testpass'],
			['TestPass%'],
			['TEST*PASS']
		];
	}
	/**
	 * @dataProvider dataTestCheckSpecialCharacters
	 *
	 * @param string $password
	 * @param bool $enforceSpecialCharacters
	 */
	public function testCheckSpecialCharacters($password, $enforceSpecialCharacters) {
		$this->config->expects($this->once())->method('getIsSpecialCharactersEnforced')->willReturn($enforceSpecialCharacters);

		$this->passValidator->checkSpecialCharacters($password);
	}
	public function dataTestCheckSpecialCharacters() {
		return [
			['testPass%', true],
			['testpass', false]
		];
	}
	/**
	 * @dataProvider dataTestCheckSpecialCharactersFail
	 * @param string $password
	 * @expectedException \OC\HintException
	 */
	public function testCheckSpecialCharactersFail($password) {
		$this->config->expects($this->once())->method('getIsSpecialCharactersEnforced')->willReturn(true);

		$this->passValidator->checkSpecialCharacters($password);
	}
	public function dataTestCheckSpecialCharactersFail() {
		return [
			['testpass'],
			['TestPass1'],
			['TEST2PASS']
		];
	}
	public function testValidate() {
		$password = 'password';
		$instance = $this->getMockInstance(
			[
				'checkPasswordLength',
				'checkUpperLowerCase',
				'checkNumericCharacters',
				'checkSpecialCharacters',
			]
		);
		$instance->expects($this->once())->method('checkPasswordLength')->with($password);

		$instance->expects($this->once())->method('checkUpperLowerCase')->with($password);

		$instance->expects($this->once())->method('checkNumericCharacters')->with($password);

		$instance->expects($this->once())->method('checkSpecialCharacters')->with($password);

		$instance->validate($password);
	}
}

1			<?php
2			/**
3			* @copyright Copyright (c) 2017 Semih Serhat Karakaya <[email protected]>
4			*
5			* @license GNU AGPL version 3 or any later version
6			*
7			* This program is free software: you can redistribute it and/or modify
8			* it under the terms of the GNU Affero General Public License as
9			* published by the Free Software Foundation, either version 3 of the
10			* License, or (at your option) any later version.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License
18			* along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*
20			*/
21			namespace OCA\Password_Policy\Tests;
22			use OC\HintException;
23			use OCA\Security\SecurityConfig;
24			use OCA\Security\PasswordValidator;
25			use OCP\IL10N;
26			use Test\TestCase;
27			class PasswordValidatorTest extends TestCase {
28
29			/** @var SecurityConfig\|\PHPUnit_Framework_MockObject_MockObject */
30			private $config;
31
32			/** @var IL10N\|\PHPUnit_Framework_MockObject_MockObject */
33			private $l10n;
34
35			/** @var PasswordValidator */
36			private $passValidator;
37
38			public function setUp() {
39			parent::setUp();
40			$this->l10n = $this->createMock(IL10N::class);
41			$this->config = $this->createMock(SecurityConfig::class);
42			$this->passValidator = new PasswordValidator($this->config, $this->l10n);
43			}
44
45			/**
46			* @param array $mockedMethods
47			* @return PasswordValidator \| \PHPUnit_Framework_MockObject_MockObject
48			*/
49			private function getMockInstance($mockedMethods = []) {
50			$passwordValidator = $this->getMockBuilder('OCA\Security\PasswordValidator')
51			->setConstructorArgs([$this->config, $this->l10n])
52			->setMethods($mockedMethods)->getMock();
53			return $passwordValidator;
54			}
55
56			public function testCheckPasswordLength() {
57			$this->config->expects($this->exactly(1))->method('getMinPasswordLength')->willReturn(4);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\SecurityConfig>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
58			$this->passValidator->checkPasswordLength('password');
59			}
60			/**
61			* @expectedException \OC\HintException
62			*/
63			public function testCheckPasswordLengthFail() {
64			$this->config->expects($this->exactly(1))->method('getMinPasswordLength')->willReturn(4);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\SecurityConfig>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
65			$this->passValidator->checkPasswordLength('123');
66			}
67			/**
68			* @dataProvider dataTestCheckUpperLowerCase
69			*
70			* @param string $password
71			* @param bool $enforceUpperLowerCase
72			*/
73			public function testCheckUpperLowerCase($password, $enforceUpperLowerCase) {
74			$this->config->expects($this->once())->method('getIsUpperLowerCaseEnforced')
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\SecurityConfig>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
75			->willReturn($enforceUpperLowerCase);
76			$this->passValidator->checkUpperLowerCase($password);
77			}
78			public function dataTestCheckUpperLowerCase() {
79			return [
80			['testPass', true],
81			['Testpass', true],
82			['testpass', false],
83			['TESTPASS', false],
84			];
85			}
86			/**
87			* @dataProvider dataTestCheckUpperLowerCaseFail
88			* @param string $password
89			* @expectedException \OC\HintException
90			*/
91			public function testCheckUpperLowerCaseFail($password) {
92			$this->config->expects($this->once())->method('getIsUpperLowerCaseEnforced')->willReturn(true);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\SecurityConfig>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
93			$this->passValidator->checkUpperLowerCase($password);
94			}
95			public function dataTestCheckUpperLowerCaseFail() {
96			return [
97			['TESTPASS'], ['testpass']
98			];
99			}
100			/**
101			* @dataProvider dataTestCheckNumericCharacters
102			*
103			* @param string $password
104			* @param bool $enforceNumericCharacters
105			*/
106			public function testCheckNumericCharacters($password, $enforceNumericCharacters) {
107			$this->config->expects($this->once())->method('getIsNumericCharactersEnforced')->willReturn($enforceNumericCharacters);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\SecurityConfig>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
108			$this->passValidator->checkNumericCharacters($password);
109			}
110			public function dataTestCheckNumericCharacters() {
111			return [
112			['testPass1', true],
113			['testpass', false]
114			];
115			}
116			/**
117			* @dataProvider dataTestCheckNumericCharactersFail
118			* @param string $password
119			* @expectedException \OC\HintException
120			*/
121			public function testCheckNumericCharactersFail($password) {
122			$this->config->expects($this->once())->method('getIsNumericCharactersEnforced')->willReturn(true);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\SecurityConfig>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
123			$this->passValidator->checkNumericCharacters($password);
124			}
125			public function dataTestCheckNumericCharactersFail() {
126			return [
127			['testpass'],
128			['TestPass%'],
129			['TEST*PASS']
130			];
131			}
132			/**
133			* @dataProvider dataTestCheckSpecialCharacters
134			*
135			* @param string $password
136			* @param bool $enforceSpecialCharacters
137			*/
138			public function testCheckSpecialCharacters($password, $enforceSpecialCharacters) {
139			$this->config->expects($this->once())->method('getIsSpecialCharactersEnforced')->willReturn($enforceSpecialCharacters);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\SecurityConfig>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
140			$this->passValidator->checkSpecialCharacters($password);
141			}
142			public function dataTestCheckSpecialCharacters() {
143			return [
144			['testPass%', true],
145			['testpass', false]
146			];
147			}
148			/**
149			* @dataProvider dataTestCheckSpecialCharactersFail
150			* @param string $password
151			* @expectedException \OC\HintException
152			*/
153			public function testCheckSpecialCharactersFail($password) {
154			$this->config->expects($this->once())->method('getIsSpecialCharactersEnforced')->willReturn(true);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\SecurityConfig>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
155			$this->passValidator->checkSpecialCharacters($password);
156			}
157			public function dataTestCheckSpecialCharactersFail() {
158			return [
159			['testpass'],
160			['TestPass1'],
161			['TEST2PASS']
162			];
163			}
164			public function testValidate() {
165			$password = 'password';
166			$instance = $this->getMockInstance(
167			[
168			'checkPasswordLength',
169			'checkUpperLowerCase',
170			'checkNumericCharacters',
171			'checkSpecialCharacters',
172			]
173			);
174			$instance->expects($this->once())->method('checkPasswordLength')->with($password);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\PasswordValidator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
175			$instance->expects($this->once())->method('checkUpperLowerCase')->with($password);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\PasswordValidator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
176			$instance->expects($this->once())->method('checkNumericCharacters')->with($password);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\PasswordValidator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
177			$instance->expects($this->once())->method('checkSpecialCharacters')->with($password);
			0 ignored issues – show Bug introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<OCA\Security\PasswordValidator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
178			$instance->validate($password);
179			}
180			}

owncloud / security

Issues (40)

Security Analysis no request data

tests/PasswordValidatorTest.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like