Issues in DbService.php (master) - Issues in master - owncloud/security - Measure and Improve Code Quality continuously with Scrutinizer

Issues (40)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Db/DbService.php (5 issues)

Labels

Duplication 5

Severity

Informational 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**

 *
 * @author Semih Serhat Karakaya
 * @copyright Copyright (c) 2017, ownCloud GmbH
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\Security\Db;

use OC\AppFramework\Utility\TimeFactory;
use OCA\Security\SecurityConfig;
use OCP\IDBConnection;

/**
 * Class DBService
 * @package OCA\Security\Db
 */
class DbService {

    /**
     * @var IDBConnection
     */
    private $connection;

    /**
     * @var TimeFactory
     */
    private $factory;
    /**
     * @var SecurityConfig
     */
    private $config;

    /**
     * DBService constructor.
     *
     * @param IDBConnection $connection
     * @param TimeFactory $factory
     * @param SecurityConfig $config
     */
    public function __construct(IDBConnection $connection, TimeFactory $factory, SecurityConfig $config) {
        $this->connection = $connection;
        $this->factory = $factory;
        $this->config = $config;
    }

    /**
     * @param string $uid
     */
    public function addFailedLoginAttempt($uid, $ip){

        $builder = $this->connection->getQueryBuilder();
        $builder->insert('failed_login_attempts')
            ->setValue('ip', $builder->createNamedParameter($ip))
            ->setValue('uid', $builder->createNamedParameter($uid))
            ->setValue('attempted_at', $builder->createNamedParameter($this->factory->getTime()))
            ->execute();
    }

    /**
     * @param string $uid
     * @param string $ip
     * @return int
     */
    public function getSuspiciousActivityCountForUidIpCombination($uid, $ip) {
        $builder = $this->connection->getQueryBuilder();
        $thresholdTime = (new \DateTime())->modify("-". $this->config->getBruteForceProtectionTimeThreshold() . "second")->getTimestamp();
        $attempts = $builder->selectAlias($builder->createFunction('COUNT(*)'), 'count')
            ->from('failed_login_attempts')
            ->where($builder->expr()->gt('attempted_at', $builder->createNamedParameter($thresholdTime)))
            ->andWhere($builder->expr()->eq('uid', $builder->createNamedParameter($uid)))
            ->andWhere($builder->expr()->eq('ip', $builder->createNamedParameter($ip)))
            ->execute()
            ->fetch();
        return intval($attempts['count']);
    }

    /**
     * @param string $uid
     * @return int
     */
    public function getSuspiciousActivityCountForUid($uid) {

        $builder = $this->connection->getQueryBuilder();
        $thresholdTime = (new \DateTime())->modify("-". $this->config->getBruteForceProtectionTimeThreshold() . "second")->getTimestamp();
        $attempts = $builder->selectAlias($builder->createFunction('COUNT(*)'), 'count')
            ->from('failed_login_attempts')
            ->where($builder->expr()->gt('attempted_at', $builder->createNamedParameter($thresholdTime)))
            ->andWhere($builder->expr()->eq('uid', $builder->createNamedParameter($uid)))
            ->execute()
            ->fetch();
        return intval($attempts['count']);
    }

    /**
     * @param string $ip
     * @return int
     */
    public function getSuspiciousActivityCountForIp($ip) {

        $builder = $this->connection->getQueryBuilder();
        $thresholdTime = (new \DateTime())->modify("-". $this->config->getBruteForceProtectionTimeThreshold() . "second")->getTimestamp();
        $attempts = $builder->selectAlias($builder->createFunction('COUNT(*)'), 'count')
            ->from('failed_login_attempts')
            ->where($builder->expr()->gt('attempted_at', $builder->createNamedParameter($thresholdTime)))
            ->andWhere($builder->expr()->eq('ip', $builder->createNamedParameter($ip)))
            ->execute()
            ->fetch();
        return intval($attempts['count']);
    }

    /**
     * @param string $ip
     * @return int
     */
    public function getLastFailedLoginAttemptTimeForIp($ip) {

        $builder = $this->connection->getQueryBuilder();
        $thresholdTime = (new \DateTime())->modify("-". $this->config->getBruteForceProtectionTimeThreshold() . "second")->getTimestamp();
        $lastAttempt = $builder->select('attempted_at')
            ->from('failed_login_attempts')
            ->where($builder->expr()->gt('attempted_at', $builder->createNamedParameter($thresholdTime)))
            ->andWhere($builder->expr()->eq('ip', $builder->createNamedParameter($ip)))
            ->orderBy('attempted_at','DESC')
            ->setMaxResults(1)
            ->execute()
            ->fetch();
        return intval($lastAttempt['attempted_at']);
    }

    /**
     * @param string $ip
     */
    public function deleteSuspiciousAttemptsForIp($ip) {
        $builder = $this->connection->getQueryBuilder();
        $builder->delete('failed_login_attempts')
            ->where($builder->expr()->eq('ip',$builder->createNamedParameter($ip)))
            ->execute();
    }

    /**
     * @param string $uid
     * @param string $ip
     */
    public function deleteSuspiciousAttemptsForUidIpCombination($uid, $ip) {

        $builder = $this->connection->getQueryBuilder();
        $builder->delete('failed_login_attempts')
            ->where($builder->expr()->eq('uid',$builder->createNamedParameter($uid)))
            ->andWhere($builder->expr()->eq('ip', $builder->createNamedParameter($ip)))
            ->execute();
    }
}

1		<?php
2		/**
3
4		*
5		* @author Semih Serhat Karakaya
6		* @copyright Copyright (c) 2017, ownCloud GmbH
7		* @license AGPL-3.0
8		*
9		* This code is free software: you can redistribute it and/or modify
10		* it under the terms of the GNU Affero General Public License, version 3,
11		* as published by the Free Software Foundation.
12		*
13		* This program is distributed in the hope that it will be useful,
14		* but WITHOUT ANY WARRANTY; without even the implied warranty of
15		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16		* GNU Affero General Public License for more details.
17		*
18		* You should have received a copy of the GNU Affero General Public License, version 3,
19		* along with this program. If not, see <http://www.gnu.org/licenses/>
20		*
21		*/
22
23		namespace OCA\Security\Db;
24
25		use OC\AppFramework\Utility\TimeFactory;
26		use OCA\Security\SecurityConfig;
27		use OCP\IDBConnection;
28
29		/**
30		* Class DBService
31		* @package OCA\Security\Db
32		*/
33		class DbService {
34
35		/**
36		* @var IDBConnection
37		*/
38		private $connection;
39
40		/**
41		* @var TimeFactory
42		*/
43		private $factory;
44		/**
45		* @var SecurityConfig
46		*/
47		private $config;
48
49		/**
50		* DBService constructor.
51		*
52		* @param IDBConnection $connection
53		* @param TimeFactory $factory
54		* @param SecurityConfig $config
55		*/
56		public function __construct(IDBConnection $connection, TimeFactory $factory, SecurityConfig $config) {
57		$this->connection = $connection;
58		$this->factory = $factory;
59		$this->config = $config;
60		}
61
62		/**
63		* @param string $uid
64		*/
65	View Code Duplication	public function addFailedLoginAttempt($uid, $ip){
		0 ignored issues – show Duplication introduced 2018-05-13 01:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		$builder = $this->connection->getQueryBuilder();
67		$builder->insert('failed_login_attempts')
68		->setValue('ip', $builder->createNamedParameter($ip))
69		->setValue('uid', $builder->createNamedParameter($uid))
70		->setValue('attempted_at', $builder->createNamedParameter($this->factory->getTime()))
71		->execute();
72		}
73
74		/**
75		* @param string $uid
76		* @param string $ip
77		* @return int
78		*/
79		public function getSuspiciousActivityCountForUidIpCombination($uid, $ip) {
80		$builder = $this->connection->getQueryBuilder();
81		$thresholdTime = (new \DateTime())->modify("-". $this->config->getBruteForceProtectionTimeThreshold() . "second")->getTimestamp();
82		$attempts = $builder->selectAlias($builder->createFunction('COUNT(*)'), 'count')
83		->from('failed_login_attempts')
84		->where($builder->expr()->gt('attempted_at', $builder->createNamedParameter($thresholdTime)))
85		->andWhere($builder->expr()->eq('uid', $builder->createNamedParameter($uid)))
86		->andWhere($builder->expr()->eq('ip', $builder->createNamedParameter($ip)))
87		->execute()
88		->fetch();
89		return intval($attempts['count']);
90		}
91
92		/**
93		* @param string $uid
94		* @return int
95		*/
96	View Code Duplication	public function getSuspiciousActivityCountForUid($uid) {
		0 ignored issues – show Duplication introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
97		$builder = $this->connection->getQueryBuilder();
98		$thresholdTime = (new \DateTime())->modify("-". $this->config->getBruteForceProtectionTimeThreshold() . "second")->getTimestamp();
99		$attempts = $builder->selectAlias($builder->createFunction('COUNT(*)'), 'count')
100		->from('failed_login_attempts')
101		->where($builder->expr()->gt('attempted_at', $builder->createNamedParameter($thresholdTime)))
102		->andWhere($builder->expr()->eq('uid', $builder->createNamedParameter($uid)))
103		->execute()
104		->fetch();
105		return intval($attempts['count']);
106		}
107
108		/**
109		* @param string $ip
110		* @return int
111		*/
112	View Code Duplication	public function getSuspiciousActivityCountForIp($ip) {
		0 ignored issues – show Duplication introduced 2017-08-16 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113		$builder = $this->connection->getQueryBuilder();
114		$thresholdTime = (new \DateTime())->modify("-". $this->config->getBruteForceProtectionTimeThreshold() . "second")->getTimestamp();
115		$attempts = $builder->selectAlias($builder->createFunction('COUNT(*)'), 'count')
116		->from('failed_login_attempts')
117		->where($builder->expr()->gt('attempted_at', $builder->createNamedParameter($thresholdTime)))
118		->andWhere($builder->expr()->eq('ip', $builder->createNamedParameter($ip)))
119		->execute()
120		->fetch();
121		return intval($attempts['count']);
122		}
123
124		/**
125		* @param string $ip
126		* @return int
127		*/
128	View Code Duplication	public function getLastFailedLoginAttemptTimeForIp($ip) {
		0 ignored issues – show Duplication introduced 2017-08-21 09:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
129		$builder = $this->connection->getQueryBuilder();
130		$thresholdTime = (new \DateTime())->modify("-". $this->config->getBruteForceProtectionTimeThreshold() . "second")->getTimestamp();
131		$lastAttempt = $builder->select('attempted_at')
132		->from('failed_login_attempts')
133		->where($builder->expr()->gt('attempted_at', $builder->createNamedParameter($thresholdTime)))
134		->andWhere($builder->expr()->eq('ip', $builder->createNamedParameter($ip)))
135		->orderBy('attempted_at','DESC')
136		->setMaxResults(1)
137		->execute()
138		->fetch();
139		return intval($lastAttempt['attempted_at']);
140		}
141
142		/**
143		* @param string $ip
144		*/
145		public function deleteSuspiciousAttemptsForIp($ip) {
146		$builder = $this->connection->getQueryBuilder();
147		$builder->delete('failed_login_attempts')
148		->where($builder->expr()->eq('ip',$builder->createNamedParameter($ip)))
149		->execute();
150		}
151
152		/**
153		* @param string $uid
154		* @param string $ip
155		*/
156	View Code Duplication	public function deleteSuspiciousAttemptsForUidIpCombination($uid, $ip) {
		0 ignored issues – show Duplication introduced 2018-05-13 01:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
157		$builder = $this->connection->getQueryBuilder();
158		$builder->delete('failed_login_attempts')
159		->where($builder->expr()->eq('uid',$builder->createNamedParameter($uid)))
160		->andWhere($builder->expr()->eq('ip', $builder->createNamedParameter($ip)))
161		->execute();
162		}
163		}

owncloud / security

Issues (40)

Security Analysis no request data

lib/Db/DbService.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like