OCA\Security\Hooks

Complexity

Total Complexity

4

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	register()	0	14	1
A	failedLoginCallback()	0	4	1
A	postLoginCallback()	0	3	1

<?php
/**

 *
 * @author Semih Serhat Karakaya
 * @copyright Copyright (c) 2016, ITU IT HEAD OFFICE.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\Security;

use OCP\IUser;
use OCP\IUserManager;
use OCP\IRequest;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\EventDispatcher\GenericEvent;

/**
 * Class Hooks
 * @package OCA\Secuity\Lib
 */
class Hooks {

    /** @var \OC\User\Manager */
    private $userManager;

    /** @var Throttle*/
    private $throttle;

    /** @var IRequest*/
    private $request;

    /** @var PasswordValidator */
    private $passValidator;
	/** @var EventDispatcherInterface */
	private $dispatcher;

    /**
     * @param IUserManager $userManager
     * @param Throttle $throttle
     * @param IRequest $request
	 * @param PasswordValidator $passValidator
	 * @param EventDispatcherInterface $dispatcher
     */
    public function __construct($userManager, $throttle, $request, $passValidator, $dispatcher){
        $this->userManager = $userManager;

It seems like $userManager of type object<OCP\IUserManager> is incompatible with the declared type object<OC\User\Manager> of property $userManager.

        $this->throttle = $throttle;
        $this->request = $request;
        $this->passValidator = $passValidator;
        $this->dispatcher = $dispatcher;

    }

    public function register() {
        $this->userManager->listen('\OC\User', 'failedLogin', function($uid) {
            $this->failedLoginCallback($uid);
        });

        $this->userManager->listen('\OC\User', 'postLogin', function($user) {
            $this->postLoginCallback($user);
        });

		$this->dispatcher->addListener('OCP\User::validatePassword', function(GenericEvent $event) {
			$this->passValidator->validate($event->getArgument('password'));
		});

    }

    /**
     * @param string $uid
     * @param Throttle $throttle

There is no parameter named $throttle. Was it maybe removed?

     */
    public function failedLoginCallback($uid) {
        $this->throttle->addFailedLoginAttempt($uid, $this->request->getRemoteAddress());
        $this->throttle->putDelay($uid, $this->request->getRemoteAddress());
    }

    /**
     * @param IUser $user
     */
    public function postLoginCallback($user) {

The parameter $user is not used and could be removed.

        $this->throttle->clearSuspiciousAttemptsForIp($this->request->getRemoteAddress());
    }
}