OCA\Notes\Controller\NotesApiController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	149
Duplicated Lines	6.04 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

93.02%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	excludeFields()	0	10	4
A	index()	0	8	2
A	get()	5	9	1
A	create()	4	6	1
A	update()	0	5	1
A	updateData()	0	10	3
A	destroy()	0	6	1

<?php
/**
 * ownCloud - Notes
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Bernhard Posselt <dev@bernhard-posselt.com>
 * @copyright Bernhard Posselt 2012, 2014
 */

namespace OCA\Notes\Controller;

use OCP\AppFramework\ApiController;
use OCP\AppFramework\Http\DataResponse;
use OCP\IRequest;

use OCA\Notes\Service\NotesService;
use OCA\Notes\Db\Note;
use OCP\IUserSession;

/**
 * Class NotesApiController
 *
 * @package OCA\Notes\Controller
 */
class NotesApiController extends ApiController {

    use Errors;

    /** @var NotesService */
    private $service;
    /** @var IUserSession */
    private $userSession;

    /**
     * @param string $AppName
     * @param IRequest $request
     * @param NotesService $service
     * @param IUserSession $userSession
     */
    public function __construct($AppName, IRequest $request,
                                NotesService $service,
								IUserSession $userSession){
        parent::__construct($AppName, $request);
        $this->service = $service;
        $this->userSession = $userSession;
    }


    /**
     * @param Note $note
     * @param string[] $exclude the fields that should be removed from the
     * notes
     * @return Note
     */
    private function excludeFields(Note $note, array $exclude) {
        if(count($exclude) > 0) {
            foreach ($exclude as $field) {
                if(property_exists($note, $field)) {
                    unset($note->$field);
                }
            }
        }
        return $note;
    }


    /**
     * @NoAdminRequired
     * @CORS
     * @NoCSRFRequired
     *
     * @param string $exclude
     * @return DataResponse
     */
    public function index($exclude='') {
        $exclude = explode(',', $exclude);
        $notes = $this->service->getAll($this->userSession->getUser()->getUID());
        foreach ($notes as $note) {
            $note = $this->excludeFields($note, $exclude);
        }
        return new DataResponse($notes);
    }


    /**
     * @NoAdminRequired
     * @CORS
     * @NoCSRFRequired
     *
     * @param int $id
     * @param string $exclude
     * @return DataResponse
     */
    public function get($id, $exclude='') {
        $exclude = explode(',', $exclude);

        return $this->respond(function () use ($id, $exclude) {

This code seems to be duplicated across your project.

            $note = $this->service->get($id, $this->userSession->getUser()->getUID());
            $note = $this->excludeFields($note, $exclude);
            return $note;
        });
    }


    /**
     * @NoAdminRequired
     * @CORS
     * @NoCSRFRequired
     *
     * @param string $content
     * @param boolean $favorite
     * @return DataResponse
     */
    public function create($content, $favorite=null) {
        return $this->respond(function () use ($content, $favorite) {

This code seems to be duplicated across your project.

            $note = $this->service->create($this->userSession->getUser()->getUID());
            return $this->updateData($note->getId(), $content, $favorite);
        });
    }


    /**
     * @NoAdminRequired
     * @CORS
     * @NoCSRFRequired
     *
     * @param int $id
     * @param string $content
     * @param boolean $favorite
     * @return DataResponse
     */
    public function update($id, $content=null, $favorite=null) {
        return $this->respond(function () use ($id, $content, $favorite) {
            return $this->updateData($id, $content, $favorite);
        });
    }

    /**
     * Updates a note, used by create and update
     * @param int $id
     * @param string $content
     * @param boolean $favorite
     * @return Note
     */
    private function updateData($id, $content, $favorite) {
        if($favorite!==null) {
            $this->service->favorite($id, $favorite, $this->userSession->getUser()->getUID());
        }
        if($content===null) {
            return $this->service->get($id, $this->userSession->getUser()->getUID());
        } else {
            return $this->service->update($id, $content, $this->userSession->getUser()->getUID());
        }
    }


    /**
     * @NoAdminRequired
     * @CORS
     * @NoCSRFRequired
     *
     * @param int $id
     * @return DataResponse
     */
    public function destroy($id) {
        return $this->respond(function () use ($id) {
            $this->service->delete($id, $this->userSession->getUser()->getUID());
            return [];
        });
    }


}