Issues in folderapicontroller.php (master) - Issues in master - owncloud/news - Measure and Improve Code Quality continuously with Scrutinizer

Issues (6)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controller/folderapicontroller.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * ownCloud - News
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Alessandro Cosentino <[email protected]>
 * @author Bernhard Posselt <[email protected]>
 * @copyright Alessandro Cosentino 2012
 * @copyright Bernhard Posselt 2012, 2014
 */

namespace OCA\News\Controller;

use \OCP\IRequest;
use \OCP\AppFramework\ApiController;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use \OCP\AppFramework\Http;

use \OCA\News\Service\FolderService;
use \OCA\News\Service\ItemService;
use \OCA\News\Service\ServiceNotFoundException;
use \OCA\News\Service\ServiceConflictException;
use \OCA\News\Service\ServiceValidationException;


class FolderApiController extends ApiController {

    use JSONHttpError;

    private $folderService;
    private $itemService;
    private $userId;
    private $serializer;

    public function __construct($AppName,
                                IRequest $request,
                                FolderService $folderService,
                                ItemService $itemService,
                                $UserId){
        parent::__construct($AppName, $request);
        $this->folderService = $folderService;
        $this->itemService = $itemService;
        $this->userId = $UserId;
        $this->serializer = new EntityApiSerializer('folders');
    }


    /**
     * @NoAdminRequired
     * @NoCSRFRequired
     * @CORS
     */
    public function index() {
        return $this->serializer->serialize(
            $this->folderService->findAll($this->userId)
        );
    }


    /**
     * @NoAdminRequired
     * @NoCSRFRequired
     * @CORS
     *
     * @param string $name
     * @return array|mixed|\OCP\AppFramework\Http\JSONResponse
     */
    public function create($name) {
        try {
            $this->folderService->purgeDeleted($this->userId, false);
            return $this->serializer->serialize(
                $this->folderService->create($name, $this->userId)
            );
        } catch(ServiceValidationException $ex) {
            return $this->error($ex, Http::STATUS_UNPROCESSABLE_ENTITY);
        } catch(ServiceConflictException $ex) {
            return $this->error($ex, Http::STATUS_CONFLICT);
        }
    }


    /**
     * @NoAdminRequired
     * @NoCSRFRequired
     * @CORS
     *
     * @param int $folderId
     * @return array|\OCP\AppFramework\Http\JSONResponse
     */
    public function delete($folderId) {
        try {
            $this->folderService->delete($folderId, $this->userId);
        } catch(ServiceNotFoundException $ex) {
            return $this->error($ex, Http::STATUS_NOT_FOUND);
        }

        return [];
    }


    /**
     * @NoAdminRequired
     * @NoCSRFRequired
     * @CORS
     * @param int $folderId
     * @param string $name
     * @return array|\OCP\AppFramework\Http\JSONResponse
     */
    public function update($folderId, $name) {
        try {
            $this->folderService->rename($folderId, $name, $this->userId);

        } catch(ServiceValidationException $ex) {
            return $this->error($ex, Http::STATUS_UNPROCESSABLE_ENTITY);
        } catch(ServiceConflictException $ex) {
            return $this->error($ex, Http::STATUS_CONFLICT);
        } catch(ServiceNotFoundException $ex) {
            return $this->error($ex, Http::STATUS_NOT_FOUND);
        }

        return [];
    }


    /**
     * @NoAdminRequired
     * @NoCSRFRequired
     * @CORS
     *
     * @param int $folderId
     * @param int $newestItemId
     */
    public function read($folderId, $newestItemId) {
        $this->itemService->readFolder($folderId, $newestItemId, $this->userId);
    }


}


1			<?php
2			/**
3			* ownCloud - News
4			*
5			* This file is licensed under the Affero General Public License version 3 or
6			* later. See the COPYING file.
7			*
8			* @author Alessandro Cosentino <[email protected]>
9			* @author Bernhard Posselt <[email protected]>
10			* @copyright Alessandro Cosentino 2012
11			* @copyright Bernhard Posselt 2012, 2014
12			*/
13
14			namespace OCA\News\Controller;
15
16			use \OCP\IRequest;
17			use \OCP\AppFramework\ApiController;
			0 ignored issues – show Bug introduced 2016-05-10 20:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `OCA\News\Controller\ApiController`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
18			use \OCP\AppFramework\Http;
19
20			use \OCA\News\Service\FolderService;
21			use \OCA\News\Service\ItemService;
22			use \OCA\News\Service\ServiceNotFoundException;
23			use \OCA\News\Service\ServiceConflictException;
24			use \OCA\News\Service\ServiceValidationException;
25
26
27			class FolderApiController extends ApiController {
28
29			use JSONHttpError;
30
31			private $folderService;
32			private $itemService;
33			private $userId;
34			private $serializer;
35
36			public function __construct($AppName,
37			IRequest $request,
38			FolderService $folderService,
39			ItemService $itemService,
40			$UserId){
41			parent::__construct($AppName, $request);
42			$this->folderService = $folderService;
43			$this->itemService = $itemService;
44			$this->userId = $UserId;
45			$this->serializer = new EntityApiSerializer('folders');
46			}
47
48
49			/**
50			* @NoAdminRequired
51			* @NoCSRFRequired
52			* @CORS
53			*/
54			public function index() {
55			return $this->serializer->serialize(
56			$this->folderService->findAll($this->userId)
57			);
58			}
59
60
61			/**
62			* @NoAdminRequired
63			* @NoCSRFRequired
64			* @CORS
65			*
66			* @param string $name
67			* @return array\|mixed\|\OCP\AppFramework\Http\JSONResponse
68			*/
69			public function create($name) {
70			try {
71			$this->folderService->purgeDeleted($this->userId, false);
72			return $this->serializer->serialize(
73			$this->folderService->create($name, $this->userId)
74			);
75			} catch(ServiceValidationException $ex) {
76			return $this->error($ex, Http::STATUS_UNPROCESSABLE_ENTITY);
77			} catch(ServiceConflictException $ex) {
78			return $this->error($ex, Http::STATUS_CONFLICT);
79			}
80			}
81
82
83			/**
84			* @NoAdminRequired
85			* @NoCSRFRequired
86			* @CORS
87			*
88			* @param int $folderId
89			* @return array\|\OCP\AppFramework\Http\JSONResponse
90			*/
91			public function delete($folderId) {
92			try {
93			$this->folderService->delete($folderId, $this->userId);
94			} catch(ServiceNotFoundException $ex) {
95			return $this->error($ex, Http::STATUS_NOT_FOUND);
96			}
97
98			return [];
99			}
100
101
102			/**
103			* @NoAdminRequired
104			* @NoCSRFRequired
105			* @CORS
106			* @param int $folderId
107			* @param string $name
108			* @return array\|\OCP\AppFramework\Http\JSONResponse
109			*/
110			public function update($folderId, $name) {
111			try {
112			$this->folderService->rename($folderId, $name, $this->userId);
113
114			} catch(ServiceValidationException $ex) {
115			return $this->error($ex, Http::STATUS_UNPROCESSABLE_ENTITY);
116			} catch(ServiceConflictException $ex) {
117			return $this->error($ex, Http::STATUS_CONFLICT);
118			} catch(ServiceNotFoundException $ex) {
119			return $this->error($ex, Http::STATUS_NOT_FOUND);
120			}
121
122			return [];
123			}
124
125
126			/**
127			* @NoAdminRequired
128			* @NoCSRFRequired
129			* @CORS
130			*
131			* @param int $folderId
132			* @param int $newestItemId
133			*/
134			public function read($folderId, $newestItemId) {
135			$this->itemService->readFolder($folderId, $newestItemId, $this->userId);
136			}
137
138
139			}
140

owncloud / news

Issues (6)

Security Analysis no request data

controller/folderapicontroller.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like