Issues (6)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controller/feedapicontroller.php (1 issue)

Labels
Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * ownCloud - News
4
 *
5
 * This file is licensed under the Affero General Public License version 3 or
6
 * later. See the COPYING file.
7
 *
8
 * @author Alessandro Cosentino <[email protected]>
9
 * @author Bernhard Posselt <[email protected]>
10
 * @copyright Alessandro Cosentino 2012
11
 * @copyright Bernhard Posselt 2012, 2014
12
 */
13
14
namespace OCA\News\Controller;
15
16
use \OCP\IRequest;
17
use \OCP\ILogger;
18
use \OCP\AppFramework\ApiController;
0 ignored issues
show
This use statement conflicts with another class in this namespace, OCA\News\Controller\ApiController.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
19
use \OCP\AppFramework\Http;
20
21
use \OCA\News\Service\FeedService;
22
use \OCA\News\Service\ItemService;
23
use \OCA\News\Service\ServiceNotFoundException;
24
use \OCA\News\Service\ServiceConflictException;
25
26
27
class FeedApiController extends ApiController {
28
29
    use JSONHttpError;
30
31
    private $itemService;
32
    private $feedService;
33
    private $userId;
34
    private $logger;
35
    private $loggerParams;
36
    private $serializer;
37
38
    public function __construct($AppName,
39
                                IRequest $request,
40
                                FeedService $feedService,
41
                                ItemService $itemService,
42
                                ILogger $logger,
43
                                $UserId,
44
                                $LoggerParameters){
45
        parent::__construct($AppName, $request);
46
        $this->feedService = $feedService;
47
        $this->itemService = $itemService;
48
        $this->userId = $UserId;
49
        $this->logger = $logger;
50
        $this->loggerParams = $LoggerParameters;
51
        $this->serializer = new EntityApiSerializer('feeds');
52
    }
53
54
55
    /**
56
     * @NoAdminRequired
57
     * @NoCSRFRequired
58
     * @CORS
59
     */
60
    public function index() {
61
62
        $result = [
63
            'starredCount' => $this->itemService->starredCount($this->userId),
64
            'feeds' => $this->feedService->findAll($this->userId)
65
        ];
66
67
68
        try {
69
            $result['newestItemId'] =
70
                $this->itemService->getNewestItemId($this->userId);
71
72
        // in case there are no items, ignore
73
        } catch(ServiceNotFoundException $ex) {}
74
75
        return $this->serializer->serialize($result);
76
    }
77
78
79
    /**
80
     * @NoAdminRequired
81
     * @NoCSRFRequired
82
     * @CORS
83
     *
84
     * @param string $url
85
     * @param int $folderId
86
     * @return array|mixed|\OCP\AppFramework\Http\JSONResponse
87
     */
88
    public function create($url, $folderId=0) {
89
        try {
90
            $this->feedService->purgeDeleted($this->userId, false);
91
92
            $feed = $this->feedService->create($url, $folderId, $this->userId);
93
            $result = ['feeds' => [$feed]];
94
95
            try {
96
                $result['newestItemId'] =
97
                    $this->itemService->getNewestItemId($this->userId);
98
99
            // in case there are no items, ignore
100
            } catch(ServiceNotFoundException $ex) {}
101
102
            return $this->serializer->serialize($result);
103
104
        } catch(ServiceConflictException $ex) {
105
            return $this->error($ex, Http::STATUS_CONFLICT);
106
        } catch(ServiceNotFoundException $ex) {
107
            return $this->error($ex, Http::STATUS_NOT_FOUND);
108
        }
109
    }
110
111
112
    /**
113
     * @NoAdminRequired
114
     * @NoCSRFRequired
115
     * @CORS
116
     *
117
     * @param int $feedId
118
     * @return array|\OCP\AppFramework\Http\JSONResponse
119
     */
120
    public function delete($feedId) {
121
        try {
122
            $this->feedService->delete($feedId, $this->userId);
123
        } catch(ServiceNotFoundException $ex) {
124
            return $this->error($ex, Http::STATUS_NOT_FOUND);
125
        }
126
127
        return [];
128
    }
129
130
131
    /**
132
     * @NoAdminRequired
133
     * @NoCSRFRequired
134
     * @CORS
135
     *
136
     * @param int $feedId
137
     * @param int $newestItemId
138
     */
139
    public function read($feedId, $newestItemId) {
140
        $this->itemService->readFeed($feedId, $newestItemId, $this->userId);
141
    }
142
143
144
    /**
145
     * @NoAdminRequired
146
     * @NoCSRFRequired
147
     * @CORS
148
     *
149
     * @param int $feedId
150
     * @param int $folderId
151
     * @return array|\OCP\AppFramework\Http\JSONResponse
152
     */
153
    public function move($feedId, $folderId) {
154
        try {
155
            $this->feedService->patch(
156
                $feedId, $this->userId, ['folderId' => $folderId]
157
            );
158
        } catch(ServiceNotFoundException $ex) {
159
            return $this->error($ex, Http::STATUS_NOT_FOUND);
160
        }
161
162
        return [];
163
    }
164
165
166
    /**
167
     * @NoAdminRequired
168
     * @NoCSRFRequired
169
     * @CORS
170
     *
171
     * @param int $feedId
172
     * @param string $feedTitle
173
     * @return array|\OCP\AppFramework\Http\JSONResponse
174
     */
175
    public function rename($feedId, $feedTitle) {
176
        try {
177
            $this->feedService->patch(
178
                $feedId, $this->userId, ['title' => $feedTitle]
179
            );
180
        } catch(ServiceNotFoundException $ex) {
181
            return $this->error($ex, Http::STATUS_NOT_FOUND);
182
        }
183
184
        return [];
185
    }
186
187
188
    /**
189
     * @NoCSRFRequired
190
     * @CORS
191
     */
192
    public function fromAllUsers() {
193
        $feeds = $this->feedService->findAllFromAllUsers();
194
        $result = ['feeds' => []];
195
196
        foreach ($feeds as $feed) {
197
            $result['feeds'][] = [
198
                'id' => $feed->getId(),
199
                'userId' => $feed->getUserId()
200
            ];
201
        }
202
203
        return $result;
204
    }
205
206
207
    /**
208
     * @NoCSRFRequired
209
     *
210
     * @param string $userId
211
     * @param int $feedId
212
     */
213
    public function update($userId, $feedId) {
214
        try {
215
            $this->feedService->update($feedId, $userId);
216
        // ignore update failure
217
        } catch(\Exception $ex) {
218
            $this->logger->debug('Could not update feed ' . $ex->getMessage(),
219
                    $this->loggerParams);
220
        }
221
    }
222
223
224
}
225