FeedMapper::findAllFromUser() - Code Metrics - Inspection of "[tx-robot] updated from transifex" - owncloud/news - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 060b04...657701 )

unknown

created 2016-04-21 05:01 UTC

FeedMapper::findAllFromUser() A

↳ Parent: FeedMapper

Complexity

Conditions	1
Paths	1

Size

Total Lines	23
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Metric	Value
dl	0
loc	23
ccs	0
cts	16
cp	0
rs	9.0856
cc	1
eloc	17
nc	1
nop	1
crap	2

<?php
/**
 * ownCloud - News
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Alessandro Cosentino <[email protected]>
 * @author Bernhard Posselt <[email protected]>
 * @copyright Alessandro Cosentino 2012
 * @copyright Bernhard Posselt 2012, 2014
 */

namespace OCA\News\Db;

use OCP\IDBConnection;
use OCP\AppFramework\Db\Entity;


class FeedMapper extends NewsMapper {


    public function __construct(IDBConnection $db) {
        parent::__construct($db, 'news_feeds', Feed::class);
    }


    public function find($id, $userId){
        $sql = 'SELECT `feeds`.*, COUNT(`items`.`id`) AS `unread_count` ' .
            'FROM `*PREFIX*news_feeds` `feeds` ' .
            'LEFT JOIN `*PREFIX*news_items` `items` ' .
                'ON `feeds`.`id` = `items`.`feed_id` ' .
                // WARNING: this is a desperate attempt at making this query
                // work because prepared statements dont work. This is a
                // POSSIBLE SQL INJECTION RISK WHEN MODIFIED WITHOUT THOUGHT.
                // think twice when changing this
                'AND (`items`.`status` & ' . StatusFlag::UNREAD . ') = ' .
                StatusFlag::UNREAD . ' ' .
            'WHERE `feeds`.`id` = ? ' .
                'AND `feeds`.`user_id` = ? ' .
            'GROUP BY `feeds`.`id`';
        $params = [$id, $userId];

        return $this->findEntity($sql, $params);
    }


    public function findAllFromUser($userId){
        $sql = 'SELECT `feeds`.*, COUNT(`items`.`id`) AS `unread_count` ' .
            'FROM `*PREFIX*news_feeds` `feeds` ' .
            'LEFT OUTER JOIN `*PREFIX*news_folders` `folders` '.
                'ON `feeds`.`folder_id` = `folders`.`id` ' .
            'LEFT JOIN `*PREFIX*news_items` `items` ' .
                'ON `feeds`.`id` = `items`.`feed_id` ' .
                // WARNING: this is a desperate attempt at making this query
                // work because prepared statements dont work. This is a
                // POSSIBLE SQL INJECTION RISK WHEN MODIFIED WITHOUT THOUGHT.
                // think twice when changing this
                'AND (`items`.`status` & ' . StatusFlag::UNREAD . ') = ' .
                StatusFlag::UNREAD . ' ' .
            'WHERE `feeds`.`user_id` = ? ' .
            'AND (`feeds`.`folder_id` = 0 ' .
                'OR `folders`.`deleted_at` = 0' .
            ')' .
            'AND `feeds`.`deleted_at` = 0 ' .
            'GROUP BY `feeds`.`id`';
        $params = [$userId];

        return $this->findEntities($sql, $params);
    }


    public function findAll(){
        $sql = 'SELECT `feeds`.*, COUNT(`items`.`id`) AS `unread_count` ' .
            'FROM `*PREFIX*news_feeds` `feeds` ' .
            'LEFT OUTER JOIN `*PREFIX*news_folders` `folders` '.
                'ON `feeds`.`folder_id` = `folders`.`id` ' .
            'LEFT JOIN `*PREFIX*news_items` `items` ' .
                'ON `feeds`.`id` = `items`.`feed_id` ' .
                // WARNING: this is a desperate attempt at making this query
                // work because prepared statements dont work. This is a
                // POSSIBLE SQL INJECTION RISK WHEN MODIFIED WITHOUT THOUGHT.
                // think twice when changing this
                'AND (`items`.`status` & ' . StatusFlag::UNREAD . ') = ' .
                StatusFlag::UNREAD . ' ' .
            'WHERE (`feeds`.`folder_id` = 0 ' .
                'OR `folders`.`deleted_at` = 0' .
            ')' .
            'AND `feeds`.`deleted_at` = 0 ' .
            'GROUP BY `feeds`.`id`';

        return $this->findEntities($sql);
    }


    public function findByUrlHash($hash, $userId){
        $sql = 'SELECT `feeds`.*, COUNT(`items`.`id`) AS `unread_count` ' .
            'FROM `*PREFIX*news_feeds` `feeds` ' .
            'LEFT JOIN `*PREFIX*news_items` `items` ' .
                'ON `feeds`.`id` = `items`.`feed_id` ' .
                // WARNING: this is a desperate attempt at making this query
                // work because prepared statements dont work. This is a
                // POSSIBLE SQL INJECTION RISK WHEN MODIFIED WITHOUT THOUGHT.
                // think twice when changing this
                'AND (`items`.`status` & ' . StatusFlag::UNREAD . ') = ' .
                StatusFlag::UNREAD . ' ' .
            'WHERE `feeds`.`url_hash` = ? ' .
                'AND `feeds`.`user_id` = ? ' .
            'GROUP BY `feeds`.`id`';
        $params = [$hash, $userId];

        return $this->findEntity($sql, $params);
    }


    public function delete(Entity $entity){
        parent::delete($entity);

        // someone please slap me for doing this manually :P
        // we needz CASCADE + FKs please
        $sql = 'DELETE FROM `*PREFIX*news_items` WHERE `feed_id` = ?';
        $params = [$entity->getId()];
        $this->execute($sql, $params);
    }


    /**
     * @param int $deleteOlderThan if given gets all entries with a delete date
     * older than that timestamp
     * @param string $userId if given returns only entries from the given user
     * @return array with the database rows
     */
    public function getToDelete($deleteOlderThan=null, $userId=null) {
        $sql = 'SELECT * FROM `*PREFIX*news_feeds` ' .
            'WHERE `deleted_at` > 0 ';
        $params = [];

        // sometimes we want to delete all entries
        if ($deleteOlderThan !== null) {
            $sql .= 'AND `deleted_at` < ? ';
            $params[] = $deleteOlderThan;
        }

        // we need to sometimes only delete feeds of a user
        if($userId !== null) {
            $sql .= 'AND `user_id` = ?';
            $params[] = $userId;
        }

        return $this->findEntities($sql, $params);
    }


    /**
     * Deletes all feeds of a user, delete items first since the user_id
     * is not defined in there
     * @param string $userId the name of the user
     */
    public function deleteUser($userId) {
        $sql = 'DELETE FROM `*PREFIX*news_feeds` WHERE `user_id` = ?';
        $this->execute($sql, [$userId]);
    }


}


1		<?php
2		/**
3		* ownCloud - News
4		*
5		* This file is licensed under the Affero General Public License version 3 or
6		* later. See the COPYING file.
7		*
8		* @author Alessandro Cosentino <[email protected]>
9		* @author Bernhard Posselt <[email protected]>
10		* @copyright Alessandro Cosentino 2012
11		* @copyright Bernhard Posselt 2012, 2014
12		*/
13
14		namespace OCA\News\Db;
15
16		use OCP\IDBConnection;
17		use OCP\AppFramework\Db\Entity;
18
19
20		class FeedMapper extends NewsMapper {
21
22
23	16	public function __construct(IDBConnection $db) {
24	16	parent::__construct($db, 'news_feeds', Feed::class);
25	16	}
26
27
28		public function find($id, $userId){
29		$sql = 'SELECT `feeds`.*, COUNT(`items`.`id`) AS `unread_count` ' .
30		'FROM `PREFIXnews_feeds` `feeds` ' .
31		'LEFT JOIN `PREFIXnews_items` `items` ' .
32		'ON `feeds`.`id` = `items`.`feed_id` ' .
33		// WARNING: this is a desperate attempt at making this query
34		// work because prepared statements dont work. This is a
35		// POSSIBLE SQL INJECTION RISK WHEN MODIFIED WITHOUT THOUGHT.
36		// think twice when changing this
37		'AND (`items`.`status` & ' . StatusFlag::UNREAD . ') = ' .
38		StatusFlag::UNREAD . ' ' .
39		'WHERE `feeds`.`id` = ? ' .
40		'AND `feeds`.`user_id` = ? ' .
41		'GROUP BY `feeds`.`id`';
42		$params = [$id, $userId];
43
44		return $this->findEntity($sql, $params);
45		}
46
47
48		public function findAllFromUser($userId){
49		$sql = 'SELECT `feeds`.*, COUNT(`items`.`id`) AS `unread_count` ' .
50		'FROM `PREFIXnews_feeds` `feeds` ' .
51		'LEFT OUTER JOIN `PREFIXnews_folders` `folders` '.
52		'ON `feeds`.`folder_id` = `folders`.`id` ' .
53		'LEFT JOIN `PREFIXnews_items` `items` ' .
54		'ON `feeds`.`id` = `items`.`feed_id` ' .
55		// WARNING: this is a desperate attempt at making this query
56		// work because prepared statements dont work. This is a
57		// POSSIBLE SQL INJECTION RISK WHEN MODIFIED WITHOUT THOUGHT.
58		// think twice when changing this
59		'AND (`items`.`status` & ' . StatusFlag::UNREAD . ') = ' .
60		StatusFlag::UNREAD . ' ' .
61		'WHERE `feeds`.`user_id` = ? ' .
62		'AND (`feeds`.`folder_id` = 0 ' .
63		'OR `folders`.`deleted_at` = 0' .
64		')' .
65		'AND `feeds`.`deleted_at` = 0 ' .
66		'GROUP BY `feeds`.`id`';
67		$params = [$userId];
68
69		return $this->findEntities($sql, $params);
70		}
71
72
73		public function findAll(){
74		$sql = 'SELECT `feeds`.*, COUNT(`items`.`id`) AS `unread_count` ' .
75		'FROM `PREFIXnews_feeds` `feeds` ' .
76		'LEFT OUTER JOIN `PREFIXnews_folders` `folders` '.
77		'ON `feeds`.`folder_id` = `folders`.`id` ' .
78		'LEFT JOIN `PREFIXnews_items` `items` ' .
79		'ON `feeds`.`id` = `items`.`feed_id` ' .
80		// WARNING: this is a desperate attempt at making this query
81		// work because prepared statements dont work. This is a
82		// POSSIBLE SQL INJECTION RISK WHEN MODIFIED WITHOUT THOUGHT.
83		// think twice when changing this
84		'AND (`items`.`status` & ' . StatusFlag::UNREAD . ') = ' .
85		StatusFlag::UNREAD . ' ' .
86		'WHERE (`feeds`.`folder_id` = 0 ' .
87		'OR `folders`.`deleted_at` = 0' .
88		')' .
89		'AND `feeds`.`deleted_at` = 0 ' .
90		'GROUP BY `feeds`.`id`';
91
92		return $this->findEntities($sql);
93		}
94
95
96		public function findByUrlHash($hash, $userId){
97		$sql = 'SELECT `feeds`.*, COUNT(`items`.`id`) AS `unread_count` ' .
98		'FROM `PREFIXnews_feeds` `feeds` ' .
99		'LEFT JOIN `PREFIXnews_items` `items` ' .
100		'ON `feeds`.`id` = `items`.`feed_id` ' .
101		// WARNING: this is a desperate attempt at making this query
102		// work because prepared statements dont work. This is a
103		// POSSIBLE SQL INJECTION RISK WHEN MODIFIED WITHOUT THOUGHT.
104		// think twice when changing this
105		'AND (`items`.`status` & ' . StatusFlag::UNREAD . ') = ' .
106		StatusFlag::UNREAD . ' ' .
107		'WHERE `feeds`.`url_hash` = ? ' .
108		'AND `feeds`.`user_id` = ? ' .
109		'GROUP BY `feeds`.`id`';
110		$params = [$hash, $userId];
111
112		return $this->findEntity($sql, $params);
113		}
114
115
116		public function delete(Entity $entity){
117		parent::delete($entity);
118
119		// someone please slap me for doing this manually :P
120		// we needz CASCADE + FKs please
121		$sql = 'DELETE FROM `PREFIXnews_items` WHERE `feed_id` = ?';
122		$params = [$entity->getId()];
123		$this->execute($sql, $params);
124		}
125
126
127		/**
128		* @param int $deleteOlderThan if given gets all entries with a delete date
129		* older than that timestamp
130		* @param string $userId if given returns only entries from the given user
131		* @return array with the database rows
132		*/
133		public function getToDelete($deleteOlderThan=null, $userId=null) {
134		$sql = 'SELECT * FROM `PREFIXnews_feeds` ' .
135		'WHERE `deleted_at` > 0 ';
136		$params = [];
137
138		// sometimes we want to delete all entries
139		if ($deleteOlderThan !== null) {
140		$sql .= 'AND `deleted_at` < ? ';
141		$params[] = $deleteOlderThan;
142		}
143
144		// we need to sometimes only delete feeds of a user
145		if($userId !== null) {
146		$sql .= 'AND `user_id` = ?';
147		$params[] = $userId;
148		}
149
150		return $this->findEntities($sql, $params);
151		}
152
153
154		/**
155		* Deletes all feeds of a user, delete items first since the user_id
156		* is not defined in there
157		* @param string $userId the name of the user
158		*/
159		public function deleteUser($userId) {
160		$sql = 'DELETE FROM `PREFIXnews_feeds` WHERE `user_id` = ?';
161		$this->execute($sql, [$userId]);
162		}
163
164
165		}
166

owncloud / news

Push — master ( 060b04...657701 )

FeedMapper::findAllFromUser() A

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like