OCA\News\Db\Mysql\ItemMapper

Complexity

Total Complexity

6

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
B	deleteReadOlderThanThreshold()	0	32	3
A	readItem()	0	17	2

<?php
/**
 * ownCloud - News
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Alessandro Cosentino <cosenal@gmail.com>
 * @author Bernhard Posselt <dev@bernhard-posselt.com>
 * @copyright Alessandro Cosentino 2012
 * @copyright Bernhard Posselt 2012, 2014
 */

namespace OCA\News\Db\Mysql;

use OCP\IDBConnection;

use OCA\News\Db\StatusFlag;


class ItemMapper extends \OCA\News\Db\ItemMapper {

    public function __construct(IDBConnection $db){
        parent::__construct($db);
    }


    /**
     * Delete all items for feeds that have over $threshold unread and not
     * starred items
	 * @param int $threshold the number of items that should be deleted
     */
    public function deleteReadOlderThanThreshold($threshold){
        $status = StatusFlag::STARRED | StatusFlag::UNREAD;
        $sql = 'SELECT (COUNT(*) - `feeds`.`articles_per_update`) AS `size`, ' .
        '`feeds`.`id` AS `feed_id`, `feeds`.`articles_per_update` ' .
            'FROM `*PREFIX*news_items` `items` ' .
            'JOIN `*PREFIX*news_feeds` `feeds` ' .
                'ON `feeds`.`id` = `items`.`feed_id` ' .
                'AND NOT ((`items`.`status` & ?) > 0) ' .
            'GROUP BY `feeds`.`id`, `feeds`.`articles_per_update` ' .
            'HAVING COUNT(*) > ?';
        $params = [$status, $threshold];
        $result = $this->execute($sql, $params);

        while($row = $result->fetch()) {

            $size = (int) $row['size'];
            $limit = $size - $threshold;

            if($limit > 0) {
                $params = [$status, $row['feed_id'], $limit];

                $sql = 'DELETE FROM `*PREFIX*news_items` ' .
                    'WHERE NOT ((`status` & ?) > 0) ' .
                    'AND `feed_id` = ? ' .
                    'ORDER BY `id` ASC ' .
                    'LIMIT ?';

                $this->execute($sql, $params);
            }
        }

    }

    public function readItem($itemId, $isRead, $lastModified, $userId) {
        if ($isRead) {
            $sql = 'UPDATE `*PREFIX*news_items` `items`
                JOIN `*PREFIX*news_feeds` `feeds`
                    ON `feeds`.`id` = `items`.`feed_id`
                SET `items`.`status` = `items`.`status` & ?
                    AND `items`.`last_modified` = ?
                WHERE `items`.`fingerprint` = ?
                    AND `feeds`.`user_id` = ?';
            $params = [~StatusFlag::UNREAD, $lastModified,
                       $item->getFingerprint(), $userId];

The variable $item does not exist. Did you forget to declare it?

            $this->execute($sql, $params);
        } else {
            // no other behavior for mysql if should be marked unread
            parent::readItem($itemId, $isRead, $lastModified, $userId);
        }
    }

}