UtilityApiController   A
last analyzed

Complexity

Total Complexity 5

Size/Duplication

Total Lines 59
Duplicated Lines 0 %

Coupling/Cohesion

Components 3
Dependencies 2

Importance

Changes 0
Metric Value
wmc 5
lcom 3
cbo 2
dl 0
loc 59
rs 10
c 0
b 0
f 0

5 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 10 1
A version() 0 5 1
A beforeUpdate() 0 3 1
A afterUpdate() 0 3 1
A status() 0 3 1
1
<?php
2
/**
3
 * ownCloud - News
4
 *
5
 * This file is licensed under the Affero General Public License version 3 or
6
 * later. See the COPYING file.
7
 *
8
 * @author Alessandro Cosentino <[email protected]>
9
 * @author Bernhard Posselt <[email protected]>
10
 * @copyright Alessandro Cosentino 2012
11
 * @copyright Bernhard Posselt 2012, 2014
12
 */
13
14
namespace OCA\News\Controller;
15
16
use \OCP\IRequest;
17
use \OCP\IConfig;
18
use \OCP\AppFramework\ApiController;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, OCA\News\Controller\ApiController.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
19
use \OCP\AppFramework\Http;
20
21
use \OCA\News\Utility\Updater;
22
use \OCA\News\Service\StatusService;
23
24
25
class UtilityApiController extends ApiController {
26
27
    private $updater;
28
    private $settings;
29
    private $statusService;
30
31
    public function __construct($AppName,
32
                                IRequest $request,
33
                                Updater $updater,
34
                                IConfig $settings,
35
                                StatusService $statusService){
36
        parent::__construct($AppName, $request);
37
        $this->updater = $updater;
38
        $this->settings = $settings;
39
        $this->statusService = $statusService;
40
    }
41
42
43
    /**
44
     * @NoAdminRequired
45
     * @NoCSRFRequired
46
     * @CORS
47
     */
48
    public function version() {
49
        $version = $this->settings->getAppValue($this->appName,
50
            'installed_version');
51
        return ['version' => $version];
52
    }
53
54
55
    /**
56
     * @NoCSRFRequired
57
     * @CORS
58
     */
59
    public function beforeUpdate() {
60
        $this->updater->beforeUpdate();
61
    }
62
63
64
    /**
65
     * @NoCSRFRequired
66
     * @CORS
67
     */
68
    public function afterUpdate() {
69
        $this->updater->afterUpdate();
70
    }
71
72
73
    /**
74
     * @CORS
75
     * @NoCSRFRequired
76
     * @NoAdminRequired
77
     */
78
    public function status() {
79
        return $this->statusService->getStatus();
80
    }
81
82
83
}
84