OCA\Music\Db\BookmarkMapper

Complexity

Total Complexity

3

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	2	1
A	findUniqueEntity()	0	2	1
A	findByEntry()	0	3	1

<?php declare(strict_types=1);

/**
 * ownCloud - Music app
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Gavin E <no.emai@address.for.me>
 * @author Pauli Järvinen <pauli.jarvinen@gmail.com>
 * @copyright Gavin E 2020
 * @copyright Pauli Järvinen 2020, 2021
 */

namespace OCA\Music\Db;

use \OCP\AppFramework\Db\Entity;
use \OCP\IDBConnection;

class BookmarkMapper extends BaseMapper {
	public function __construct(IDBConnection $db) {
		parent::__construct($db, 'music_bookmarks', '\OCA\Music\Db\Bookmark', 'comment');
	}

	public function findByEntry(int $type, int $entryId, string $userId) : Bookmark {
		$sql = $this->selectUserEntities("`type` = ? AND `entry_id` = ?");
		return $this->findEntity($sql, [$userId, $type, $entryId]);

The expression return $this->findEntity($sql, array($userId, $type, $entryId)) returns the type OCP\AppFramework\Db\Entity which includes types incompatible with the type-hinted return OCA\Music\Db\Bookmark.

	}

	/**
	 * @see \OCA\Music\Db\BaseMapper::findUniqueEntity()
	 * @param Bookmark $bookmark
	 * @return Bookmark
	 */
	protected function findUniqueEntity(Entity $bookmark) : Entity {
		return $this->findByEntry($bookmark->getType(), $bookmark->getEntryId(), $bookmark->getUserId());

It seems like $bookmark->getType() can also be of type null; however, parameter $type of OCA\Music\Db\BookmarkMapper::findByEntry() does only seem to accept integer, maybe add an additional type check?

It seems like $bookmark->getUserId() can also be of type null; however, parameter $userId of OCA\Music\Db\BookmarkMapper::findByEntry() does only seem to accept string, maybe add an additional type check?

It seems like $bookmark->getEntryId() can also be of type null; however, parameter $entryId of OCA\Music\Db\BookmarkMapper::findByEntry() does only seem to accept integer, maybe add an additional type check?

	}
}