getid3_ivf::Analyze() - Code Metrics - Inspection of "getID3 development version 1.9.19-202004201144" - owncloud/music - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — vendor/getid3 ( 49c253...dfd0b4 )

by Pauli

created 2020-04-20 18:33 UTC

getid3_ivf::Analyze() B

↳ Parent: getid3_ivf

Complexity

Conditions	6
Paths	13

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
nc	13
nop	0
dl	0
loc	54
rs	8.3814
c	0
b	0
f	0

How to fix Long Method

<?php
/////////////////////////////////////////////////////////////////
/// getID3() by James Heinrich <[email protected]>               //
//  available at https://github.com/JamesHeinrich/getID3       //
//            or https://www.getid3.org                        //
//            or http://getid3.sourceforge.net                 //
//  see readme.txt for more details                            //
/////////////////////////////////////////////////////////////////
//                                                             //
// module.audio.ivf.php                                        //
// module for analyzing IVF audio-video files                  //
// dependencies: NONE                                          //
//                                                            ///
/////////////////////////////////////////////////////////////////

if (!defined('GETID3_INCLUDEPATH')) { // prevent path-exposing attacks that access modules directly on public webservers
	exit;
}

class getid3_ivf extends getid3_handler
{
	/**
	 * @return bool
	 */
	public function Analyze() {
		$info = &$this->getid3->info;

		$info['fileformat']          = 'ivf';
		$info['video']['dataformat'] = 'ivf';

		$this->fseek($info['avdataoffset']);
		$IVFheader = $this->fread(32);

		if (substr($IVFheader, 0, 4) == 'DKIF') {

			// https://wiki.multimedia.cx/index.php/IVF
			$info['ivf']['header']['signature']            =                              substr($IVFheader,  0, 4);
			$info['ivf']['header']['version']              = getid3_lib::LittleEndian2Int(substr($IVFheader,  4, 2)); // should be 0
			$info['ivf']['header']['headersize']           = getid3_lib::LittleEndian2Int(substr($IVFheader,  6, 2));
			$info['ivf']['header']['fourcc']               =                              substr($IVFheader,  8, 4);
			$info['ivf']['header']['resolution_x']         = getid3_lib::LittleEndian2Int(substr($IVFheader, 12, 2));
			$info['ivf']['header']['resolution_y']         = getid3_lib::LittleEndian2Int(substr($IVFheader, 14, 2));
			$info['ivf']['header']['timebase_numerator']   = getid3_lib::LittleEndian2Int(substr($IVFheader, 16, 4));
			$info['ivf']['header']['timebase_denominator'] = getid3_lib::LittleEndian2Int(substr($IVFheader, 20, 4));
			$info['ivf']['header']['frame_count']          = getid3_lib::LittleEndian2Int(substr($IVFheader, 24, 4));
			//$info['ivf']['header']['reserved']             =                              substr($IVFheader, 28, 4);

			$info['ivf']['header']['frame_rate'] = (float) $info['ivf']['header']['timebase_numerator'] / $info['ivf']['header']['timebase_denominator'];

			if ($info['ivf']['header']['version'] > 0) {
				$this->warning('Expecting IVF header version 0, found version '.$info['ivf']['header']['version'].', results may not be accurate');
			}

			$info['video']['resolution_x']    =         $info['ivf']['header']['resolution_x'];
			$info['video']['resolution_y']    =         $info['ivf']['header']['resolution_y'];
			$info['video']['codec']           =         $info['ivf']['header']['fourcc'];

			$info['ivf']['frame_count'] = 0;
			while (!$this->feof()) {
				if ($frameheader = $this->fread(12)) {
					$framesize = getid3_lib::LittleEndian2Int(substr($frameheader, 0, 4)); // size of frame in bytes (not including the 12-byte header)
					$timestamp = getid3_lib::LittleEndian2Int(substr($frameheader, 4, 8)); // 64-bit presentation timestamp
					$this->fseek($framesize, SEEK_CUR);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
					$info['ivf']['frame_count']++;
				}
			}
			if ($info['ivf']['frame_count']) {
				$info['playtime_seconds']    = $timestamp / 100000;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
				$info['video']['frame_rate'] = (float) $info['ivf']['frame_count'] / $info['playtime_seconds'];
			}

		} else {
			$this->error('Expecting "DKIF" at offset '.$info['avdataoffset'].', found "'.getid3_lib::PrintHexBytes(substr($IVFheader, 0, 4)).'"');
			return false;
		}

		return true;
	}

}


1			<?php
2			/////////////////////////////////////////////////////////////////
3			/// getID3() by James Heinrich <[email protected]> //
4			// available at https://github.com/JamesHeinrich/getID3 //
5			// or https://www.getid3.org //
6			// or http://getid3.sourceforge.net //
7			// see readme.txt for more details //
8			/////////////////////////////////////////////////////////////////
9			// //
10			// module.audio.ivf.php //
11			// module for analyzing IVF audio-video files //
12			// dependencies: NONE //
13			// ///
14			/////////////////////////////////////////////////////////////////
15
16			if (!defined('GETID3_INCLUDEPATH')) { // prevent path-exposing attacks that access modules directly on public webservers
17			exit;
18			}
19
20			class getid3_ivf extends getid3_handler
21			{
22			/**
23			* @return bool
24			*/
25			public function Analyze() {
26			$info = &$this->getid3->info;
27
28			$info['fileformat'] = 'ivf';
29			$info['video']['dataformat'] = 'ivf';
30
31			$this->fseek($info['avdataoffset']);
32			$IVFheader = $this->fread(32);
33
34			if (substr($IVFheader, 0, 4) == 'DKIF') {
35
36			// https://wiki.multimedia.cx/index.php/IVF
37			$info['ivf']['header']['signature'] = substr($IVFheader, 0, 4);
38			$info['ivf']['header']['version'] = getid3_lib::LittleEndian2Int(substr($IVFheader, 4, 2)); // should be 0
39			$info['ivf']['header']['headersize'] = getid3_lib::LittleEndian2Int(substr($IVFheader, 6, 2));
40			$info['ivf']['header']['fourcc'] = substr($IVFheader, 8, 4);
41			$info['ivf']['header']['resolution_x'] = getid3_lib::LittleEndian2Int(substr($IVFheader, 12, 2));
42			$info['ivf']['header']['resolution_y'] = getid3_lib::LittleEndian2Int(substr($IVFheader, 14, 2));
43			$info['ivf']['header']['timebase_numerator'] = getid3_lib::LittleEndian2Int(substr($IVFheader, 16, 4));
44			$info['ivf']['header']['timebase_denominator'] = getid3_lib::LittleEndian2Int(substr($IVFheader, 20, 4));
45			$info['ivf']['header']['frame_count'] = getid3_lib::LittleEndian2Int(substr($IVFheader, 24, 4));
46			//$info['ivf']['header']['reserved'] = substr($IVFheader, 28, 4);
47
48			$info['ivf']['header']['frame_rate'] = (float) $info['ivf']['header']['timebase_numerator'] / $info['ivf']['header']['timebase_denominator'];
49
50			if ($info['ivf']['header']['version'] > 0) {
51			$this->warning('Expecting IVF header version 0, found version '.$info['ivf']['header']['version'].', results may not be accurate');
52			}
53
54			$info['video']['resolution_x'] = $info['ivf']['header']['resolution_x'];
55			$info['video']['resolution_y'] = $info['ivf']['header']['resolution_y'];
56			$info['video']['codec'] = $info['ivf']['header']['fourcc'];
57
58			$info['ivf']['frame_count'] = 0;
59			while (!$this->feof()) {
60			if ($frameheader = $this->fread(12)) {
61			$framesize = getid3_lib::LittleEndian2Int(substr($frameheader, 0, 4)); // size of frame in bytes (not including the 12-byte header)
62			$timestamp = getid3_lib::LittleEndian2Int(substr($frameheader, 4, 8)); // 64-bit presentation timestamp
63			$this->fseek($framesize, SEEK_CUR);
			0 ignored issues – show Bug introduced 2020-04-20 18:35 UTC by Report Bug Copy Issue Report It seems like `$framesize` defined by `\getid3_lib::LittleEndia...tr($frameheader, 0, 4))` on line `61` can also be of type `double` or `false`; however, `getid3_handler::fseek()` does only seem to accept `integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
64			$info['ivf']['frame_count']++;
65			}
66			}
67			if ($info['ivf']['frame_count']) {
68			$info['playtime_seconds'] = $timestamp / 100000;
			0 ignored issues – show Bug introduced 2020-04-20 18:35 UTC by Report Bug Copy Issue Report The variable `$timestamp` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
69			$info['video']['frame_rate'] = (float) $info['ivf']['frame_count'] / $info['playtime_seconds'];
70			}
71
72			} else {
73			$this->error('Expecting "DKIF" at offset '.$info['avdataoffset'].', found "'.getid3_lib::PrintHexBytes(substr($IVFheader, 0, 4)).'"');
74			return false;
75			}
76
77			return true;
78			}
79
80			}
81

owncloud / music

Push — vendor/getid3 ( 49c253...dfd0b4 )

getid3_ivf::Analyze() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like