getid3_hpk

Complexity

Total Complexity

3

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	Analyze()	0	65	3

<?php

/////////////////////////////////////////////////////////////////
/// getID3() by James Heinrich <info@getid3.org>               //
//  available at https://github.com/JamesHeinrich/getID3       //
//            or https://www.getid3.org                        //
//            or http://getid3.sourceforge.net                 //
//  see readme.txt for more details                            //
/////////////////////////////////////////////////////////////////
//                                                             //
// module.archive.hpk.php                                      //
// module for analyzing HPK files                              //
// dependencies: NONE                                          //
//                                                            ///
/////////////////////////////////////////////////////////////////

if (!defined('GETID3_INCLUDEPATH')) { // prevent path-exposing attacks that access modules directly on public webservers
	exit;
}

class getid3_hpk extends getid3_handler
{
	/**
	 * @return bool
	 */
	public function Analyze() {
		$info = &$this->getid3->info;

		$info['fileformat'] = 'hpk';

		$this->fseek($info['avdataoffset']);
		$HPKheader = $this->fread(36);

		if (substr($HPKheader, 0, 4) == 'BPUL') {

			$info['hpk']['header']['signature']                    =                              substr($HPKheader,  0, 4);
			$info['hpk']['header']['data_offset']                  = getid3_lib::LittleEndian2Int(substr($HPKheader,  4, 4));
			$info['hpk']['header']['fragments_per_file']           = getid3_lib::LittleEndian2Int(substr($HPKheader,  8, 4));
			//$info['hpk']['header']['unknown1']                     = getid3_lib::LittleEndian2Int(substr($HPKheader, 12, 4));
			$info['hpk']['header']['fragments_residual_offset']    = getid3_lib::LittleEndian2Int(substr($HPKheader, 16, 4));
			$info['hpk']['header']['fragments_residual_count']     = getid3_lib::LittleEndian2Int(substr($HPKheader, 20, 4));
			//$info['hpk']['header']['unknown2']                     = getid3_lib::LittleEndian2Int(substr($HPKheader, 24, 4));
			$info['hpk']['header']['fragmented_filesystem_offset'] = getid3_lib::LittleEndian2Int(substr($HPKheader, 28, 4));
			$info['hpk']['header']['fragmented_filesystem_length'] = getid3_lib::LittleEndian2Int(substr($HPKheader, 32, 4));

			$info['hpk']['header']['filesystem_entries'] = $info['hpk']['header']['fragmented_filesystem_length'] / ($info['hpk']['header']['fragments_per_file'] * 8);
			$this->fseek($info['hpk']['header']['fragmented_filesystem_offset']);
			for ($i = 0; $i < $info['hpk']['header']['filesystem_entries']; $i++) {
				$offset = getid3_lib::LittleEndian2Int($this->fread(4));

It seems like $this->fread(4) targeting getid3_handler::fread() can also be of type false; however, getid3_lib::LittleEndian2Int() does only seem to accept string, did you maybe forget to handle an error condition?

				$length = getid3_lib::LittleEndian2Int($this->fread(4));

It seems like $this->fread(4) targeting getid3_handler::fread() can also be of type false; however, getid3_lib::LittleEndian2Int() does only seem to accept string, did you maybe forget to handle an error condition?

				$info['hpk']['filesystem'][$i] = array('offset' => $offset, 'length' => $length);
			}

$this->error('HPK parsing incomplete (and mostly broken) in this version of getID3() ['.$this->getid3->version().']');

/*
			$filename = '';
			$dirs = array();
			foreach ($info['hpk']['filesystem'] as $key => $filesystemdata) {
				$this->fseek($filesystemdata['offset']);
				$first4 = $this->fread(4);
				if (($first4 == 'LZ4 ') || ($first4 == 'ZLIB')) {
					// actual data, ignore
					$info['hpk']['toc'][$key] = array(
						'filename' => ltrim(implode('/', $dirs).'/'.$filename, '/'),
						'offset'   => $filesystemdata['offset'],
						'length'   => $filesystemdata['length'],
					);
					$filename = '';
					$dirs = array();
				} else {
					$fragment_index = getid3_lib::LittleEndian2Int($first4);
					$fragment_type  = getid3_lib::LittleEndian2Int($this->fread(4)); // file = 0, directory = 1
					$name_length    = getid3_lib::LittleEndian2Int($this->fread(2));
					if ($fragment_type == 1) {
						$dirs[]   = $this->fread($name_length);
					} else {
						$filename = $this->fread($name_length);
					}
				}
			}
*/

		} else {
			$this->error('Expecting "BPUL" at offset '.$info['avdataoffset'].', found "'.getid3_lib::PrintHexBytes(substr($HPKheader, 0, 4)).'"');
			return false;
		}

		return true;
	}

}