Total Complexity | 49 |
Total Lines | 392 |
Duplicated Lines | 0 % |
Changes | 2 | ||
Bugs | 0 | Features | 0 |
Complex classes like TrackBusinessLayer often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use TrackBusinessLayer, and based on these observations, apply Extract Interface, too.
1 | <?php declare(strict_types=1); |
||
36 | class TrackBusinessLayer extends BusinessLayer { |
||
37 | protected $mapper; // eclipse the definition from the base class, to help IDE and Scrutinizer to know the actual type |
||
38 | private $logger; |
||
39 | |||
40 | public function __construct(TrackMapper $trackMapper, Logger $logger) { |
||
41 | parent::__construct($trackMapper); |
||
42 | $this->mapper = $trackMapper; |
||
43 | $this->logger = $logger; |
||
44 | } |
||
45 | |||
46 | /** |
||
47 | * Returns all tracks filtered by artist (both album and track artists are considered) |
||
48 | * @return Track[] |
||
49 | */ |
||
50 | public function findAllByArtist(int $artistId, string $userId, ?int $limit=null, ?int $offset=null) : array { |
||
51 | return $this->mapper->findAllByArtist($artistId, $userId, $limit, $offset); |
||
52 | } |
||
53 | |||
54 | /** |
||
55 | * Returns all tracks filtered by album. Optionally, filter also by the performing artist. |
||
56 | * @param int|int[] $albumId |
||
57 | * @return Track[] |
||
58 | */ |
||
59 | public function findAllByAlbum(/*mixed*/ $albumId, string $userId, ?int $artistId=null, ?int $limit=null, ?int $offset=null) : array { |
||
60 | if (empty($albumId)) { |
||
61 | return []; |
||
62 | } else { |
||
63 | if (!\is_array($albumId)) { |
||
64 | $albumId = [$albumId]; |
||
65 | } |
||
66 | return $this->mapper->findAllByAlbum($albumId, $userId, $artistId, $limit, $offset); |
||
67 | } |
||
68 | } |
||
69 | |||
70 | /** |
||
71 | * Returns all tracks filtered by parent folder |
||
72 | * @return Track[] |
||
73 | */ |
||
74 | public function findAllByFolder(int $folderId, string $userId, ?int $limit=null, ?int $offset=null) : array { |
||
75 | return $this->mapper->findAllByFolder($folderId, $userId, $limit, $offset); |
||
76 | } |
||
77 | |||
78 | /** |
||
79 | * Returns all tracks filtered by genre |
||
80 | * @return Track[] |
||
81 | */ |
||
82 | public function findAllByGenre(int $genreId, string $userId, ?int $limit=null, ?int $offset=null) : array { |
||
84 | } |
||
85 | |||
86 | /** |
||
87 | * Returns all tracks filtered by name (of track/album/artist) |
||
88 | * @param string $name the name of the track/album/artist |
||
89 | * @param string $userId the name of the user |
||
90 | * @return Track[] |
||
91 | */ |
||
92 | public function findAllByNameRecursive(string $name, string $userId, ?int $limit=null, ?int $offset=null) : array { |
||
93 | $name = \trim($name); |
||
94 | return $this->mapper->findAllByNameRecursive($name, $userId, $limit, $offset); |
||
95 | } |
||
96 | |||
97 | /** |
||
98 | * Returns all tracks specified by name and/or artist name |
||
99 | * @return Track[] Tracks matching the criteria |
||
100 | */ |
||
101 | public function findAllByNameAndArtistName(?string $name, ?string $artistName, string $userId) : array { |
||
102 | if ($name !== null) { |
||
103 | $name = \trim($name); |
||
104 | } |
||
105 | if ($artistName !== null) { |
||
106 | $artistName = \trim($artistName); |
||
107 | } |
||
108 | |||
109 | return $this->mapper->findAllByNameAndArtistName($name, $artistName, $userId); |
||
110 | } |
||
111 | |||
112 | /** |
||
113 | * Returns all tracks where the 'modified' time in the file system (actually in the cloud's file cache) |
||
114 | * is later than the 'updated' field of the entity in the database. |
||
115 | * @return Track[] |
||
116 | */ |
||
117 | public function findAllDirty(string $userId) : array { |
||
118 | $tracks = $this->findAll($userId); |
||
119 | return \array_filter($tracks, function (Track $track) { |
||
120 | $dbModTime = new \DateTime($track->getUpdated()); |
||
121 | return ($dbModTime->getTimestamp() < $track->getFileModTime()); |
||
122 | }); |
||
123 | } |
||
124 | |||
125 | /** |
||
126 | * Find most frequently played tracks |
||
127 | * @return Track[] |
||
128 | */ |
||
129 | public function findFrequentPlay(string $userId, ?int $limit=null, ?int $offset=null) : array { |
||
130 | return $this->mapper->findFrequentPlay($userId, $limit, $offset); |
||
131 | } |
||
132 | |||
133 | /** |
||
134 | * Find most recently played tracks |
||
135 | * @return Track[] |
||
136 | */ |
||
137 | public function findRecentPlay(string $userId, ?int $limit=null, ?int $offset=null) : array { |
||
138 | return $this->mapper->findRecentPlay($userId, $limit, $offset); |
||
139 | } |
||
140 | |||
141 | /** |
||
142 | * Find least recently played tracks |
||
143 | * @return Track[] |
||
144 | */ |
||
145 | public function findNotRecentPlay(string $userId, ?int $limit=null, ?int $offset=null) : array { |
||
146 | return $this->mapper->findNotRecentPlay($userId, $limit, $offset); |
||
147 | } |
||
148 | |||
149 | /** |
||
150 | * Returns the track for a file id |
||
151 | * @return Track|null |
||
152 | */ |
||
153 | public function findByFileId(int $fileId, string $userId) : ?Track { |
||
154 | try { |
||
155 | return $this->mapper->findByFileId($fileId, $userId); |
||
156 | } catch (DoesNotExistException $e) { |
||
157 | return null; |
||
158 | } |
||
159 | } |
||
160 | |||
161 | /** |
||
162 | * Returns file IDs of all indexed tracks of the user |
||
163 | * @return int[] |
||
164 | */ |
||
165 | public function findAllFileIds(string $userId) : array { |
||
166 | return $this->mapper->findAllFileIds($userId); |
||
167 | } |
||
168 | |||
169 | /** |
||
170 | * Returns all folders of the user containing indexed tracks, along with the contained track IDs |
||
171 | * @return array of entries like {id: int, name: string, path: string, parent: ?int, trackIds: int[]} |
||
172 | */ |
||
173 | public function findAllFolders(string $userId, Folder $musicFolder) : array { |
||
213 | } |
||
214 | |||
215 | private function recursivelyAddMissingParentFolders(array $foldersToProcess, array &$alreadyFoundFolders, Folder $musicFolder) : void { |
||
235 | } |
||
236 | } |
||
237 | |||
238 | private static function getFolderEntry(array $folderNamesAndParents, int $folderId, array $trackIds, Folder $musicFolder) : ?array { |
||
239 | if (isset($folderNamesAndParents[$folderId])) { |
||
240 | // normal folder within the user home storage |
||
241 | $entry = $folderNamesAndParents[$folderId]; |
||
242 | // special handling for the root folder |
||
243 | if ($folderId === $musicFolder->getId()) { |
||
244 | $entry = null; |
||
245 | } |
||
246 | } else { |
||
247 | // shared folder or parent folder of a shared file or an externally mounted folder |
||
248 | $folderNode = $musicFolder->getById($folderId)[0] ?? null; |
||
249 | if ($folderNode === null) { |
||
250 | // other user's folder with files shared with this user (mapped under root) |
||
251 | $entry = null; |
||
252 | } else { |
||
253 | $entry = [ |
||
254 | 'name' => $folderNode->getName(), |
||
255 | 'parent' => $folderNode->getParent()->getId() |
||
256 | ]; |
||
257 | } |
||
258 | } |
||
259 | |||
260 | if ($entry) { |
||
261 | $entry['trackIds'] = $trackIds; |
||
262 | $entry['id'] = $folderId; |
||
263 | |||
264 | if ($entry['id'] == $musicFolder->getId()) { |
||
265 | // the library root should be reported without a parent folder as that parent does not belong to the library |
||
266 | $entry['parent'] = null; |
||
267 | } |
||
268 | } |
||
269 | |||
270 | return $entry; |
||
271 | } |
||
272 | |||
273 | /** |
||
274 | * Returns all genre IDs associated with the given artist |
||
275 | * @return int[] |
||
276 | */ |
||
277 | public function getGenresByArtistId(int $artistId, string $userId) : array { |
||
278 | return $this->mapper->getGenresByArtistId($artistId, $userId); |
||
279 | } |
||
280 | |||
281 | /** |
||
282 | * Returns file IDs of the tracks which do not have genre scanned. This is not the same |
||
283 | * thing as unknown genre, which is stored as empty string and means that the genre has |
||
284 | * been scanned but was not found from the track metadata. |
||
285 | * @return int[] |
||
286 | */ |
||
287 | public function findFilesWithoutScannedGenre(string $userId) : array { |
||
288 | return $this->mapper->findFilesWithoutScannedGenre($userId); |
||
289 | } |
||
290 | |||
291 | public function countByArtist(int $artistId) : int { |
||
292 | return $this->mapper->countByArtist($artistId); |
||
293 | } |
||
294 | |||
295 | public function countByAlbum(int $albumId) : int { |
||
296 | return $this->mapper->countByAlbum($albumId); |
||
297 | } |
||
298 | |||
299 | /** |
||
300 | * @return integer Duration in seconds |
||
301 | */ |
||
302 | public function totalDurationOfAlbum(int $albumId) : int { |
||
303 | return $this->mapper->totalDurationOfAlbum($albumId); |
||
304 | } |
||
305 | |||
306 | /** |
||
307 | * @return integer Duration in seconds |
||
308 | */ |
||
309 | public function totalDurationByArtist(int $artistId) : int { |
||
310 | return $this->mapper->totalDurationByArtist($artistId); |
||
311 | } |
||
312 | |||
313 | /** |
||
314 | * Update "last played" timestamp and increment the total play count of the track. |
||
315 | */ |
||
316 | public function recordTrackPlayed(int $trackId, string $userId, ?\DateTime $timeOfPlay = null) : void { |
||
321 | } |
||
322 | } |
||
323 | |||
324 | /** |
||
325 | * Adds a track if it does not exist already or updates an existing track |
||
326 | * @param string $title the title of the track |
||
327 | * @param int|null $number the number of the track |
||
328 | * @param int|null $discNumber the number of the disc |
||
329 | * @param int|null $year the year of the release |
||
330 | * @param int $genreId the genre id of the track |
||
331 | * @param int $artistId the artist id of the track |
||
332 | * @param int $albumId the album id of the track |
||
333 | * @param int $fileId the file id of the track |
||
334 | * @param string $mimetype the mimetype of the track |
||
335 | * @param string $userId the name of the user |
||
336 | * @param int $length track length in seconds |
||
337 | * @param int $bitrate track bitrate in bits (not kbits) |
||
338 | * @return Track The added/updated track |
||
339 | */ |
||
340 | public function addOrUpdateTrack( |
||
357 | } |
||
358 | |||
359 | /** |
||
360 | * Deletes a track |
||
361 | * @param int[] $fileIds file IDs of the tracks to delete |
||
362 | * @param string[]|null $userIds the target users; if omitted, the tracks matching the |
||
363 | * $fileIds are deleted from all users |
||
364 | * @return array|false False is returned if no such track was found; otherwise array of six arrays |
||
365 | * (named 'deletedTracks', 'remainingAlbums', 'remainingArtists', 'obsoleteAlbums', |
||
366 | * 'obsoleteArtists', and 'affectedUsers'). These contain the track, album, artist, and |
||
367 | * user IDs of the deleted tracks. The 'obsolete' entities are such which no longer |
||
368 | * have any tracks while 'remaining' entities have some left. |
||
369 | */ |
||
370 | public function deleteTracks(array $fileIds, ?array $userIds=null) { |
||
428 | } |
||
429 | } |
||
430 |