OCA\Music\Db\Entity

Complexity

Total Complexity

3

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getNameString()	0	8	3

<?php declare(strict_types=1);

/**
 * ownCloud - Music app
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Pauli Järvinen <pauli.jarvinen@gmail.com>
 * @copyright Pauli Järvinen 2021 - 2023
 */

namespace OCA\Music\Db;

use OCP\IL10N;

/**
 * Base class for all the entities belonging to the data model of the Music app
 * 
 * @method string getUserId()
 * @method void setUserId(string $userId)
 * @method string getCreated()
 * @method setCreated(string $timestamp)
 * @method string getUpdated()
 * @method setUpdated(string $timestamp)
 */
class Entity extends \OCP\AppFramework\Db\Entity {
	public $userId;
	public $created;
	public $updated;

	/**
	 * All entities have a non-empty human-readable name, although the exact name of the
	 * corresponding DB column varies and in some cases, the value may be technically
	 * empty but replaced with some localized place-holder text.
	 *
	 * The derived classes may override this as neeeded.
	 */
	public function getNameString(IL10N $l10n) : string {
		($l10n); // unused in this base implementation
		if (\property_exists($this, 'name')) {
			return $this->getName();

The method getName() does not exist on OCA\Music\Db\Entity. Since you implemented __call, consider adding a @method annotation.

The expression return $this->getName() could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

		} elseif (\property_exists($this, 'title')) {
			return $this->getTitle();

The expression return $this->getTitle() could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

The method getTitle() does not exist on OCA\Music\Db\Entity. Since you implemented __call, consider adding a @method annotation.

		} else {
			return 'UNIMPLEMENTED';
		}
	}
}