Passed
Push — master ( 3145c0...db6a69 )
by Pauli
02:48
created

ampacheSessionChanges()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 5
Code Lines 1

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 1
eloc 1
c 0
b 0
f 0
nc 1
nop 1
dl 0
loc 5
rs 10
1
<?php
2
3
declare(strict_types=1);
4
5
namespace OCA\Music\Migration;
6
7
use Closure;
8
use OCP\DB\ISchemaWrapper;
9
use OCP\Migration\SimpleMigrationStep;
10
use OCP\Migration\IOutput;
11
12
/**
13
 * Migrate the DB schema to Music v1.9.1 level from the v1.4.0 level, part 1
14
 */
15
class Version010901Date20231008194500 extends SimpleMigrationStep {
16
17
	/**
18
	 * @param IOutput $output
19
	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
20
	 * @param array $options
21
	 */
22
	public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
23
	}
24
25
	/**
26
	 * @param IOutput $output
27
	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
28
	 * @param array $options
29
	 * @return null|ISchemaWrapper
30
	 */
31
	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
32
		/** @var ISchemaWrapper $schema */
33
		$schema = $schemaClosure();
34
		$this->fixInconsistentIdTypes($schema);
35
		$this->allowNegativeYear($schema);
36
		$this->ampacheSessionChanges($schema);
37
		$this->addRatingFields($schema);
38
		return $schema;
39
	}
40
41
	/**
42
	 * @param IOutput $output
43
	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
44
	 * @param array $options
45
	 */
46
	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
47
	}
48
49
	/**
50
	 * Some of the foreign keys referring to entity IDs have been previously defined as signed
51
	 * although the referred primary key has always been unsigned.
52
	 */
53
	private function fixInconsistentIdTypes(ISchemaWrapper $schema) {
54
		$schema->getTable('music_albums')->changeColumn('album_artist_id', ['unsigned' => true]);
0 ignored issues
show
Deprecated Code introduced by
The function Doctrine\DBAL\Schema\Table::changeColumn() has been deprecated: Use {@link modifyColumn()} instead. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

54
		/** @scrutinizer ignore-deprecated */ $schema->getTable('music_albums')->changeColumn('album_artist_id', ['unsigned' => true]);

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
55
		$schema->getTable('music_tracks')->changeColumn('artist_id', ['unsigned' => true])
0 ignored issues
show
Deprecated Code introduced by
The function Doctrine\DBAL\Schema\Table::changeColumn() has been deprecated: Use {@link modifyColumn()} instead. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

55
		/** @scrutinizer ignore-deprecated */ $schema->getTable('music_tracks')->changeColumn('artist_id', ['unsigned' => true])

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
56
										->changeColumn('album_id', ['unsigned' => true]);
57
		$schema->getTable('music_bookmarks')->changeColumn('entry_id', ['unsigned' => true]);
0 ignored issues
show
Deprecated Code introduced by
The function Doctrine\DBAL\Schema\Table::changeColumn() has been deprecated: Use {@link modifyColumn()} instead. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

57
		/** @scrutinizer ignore-deprecated */ $schema->getTable('music_bookmarks')->changeColumn('entry_id', ['unsigned' => true]);

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
58
		$schema->getTable('music_ampache_users')->changeColumn('id', ['unsigned' => true]);
0 ignored issues
show
Deprecated Code introduced by
The function Doctrine\DBAL\Schema\Table::changeColumn() has been deprecated: Use {@link modifyColumn()} instead. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

58
		/** @scrutinizer ignore-deprecated */ $schema->getTable('music_ampache_users')->changeColumn('id', ['unsigned' => true]);

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
59
	}
60
61
	/**
62
	 * Although untypical, it's not totally impossible that some historical piece of music would
63
	 * be tagged with a negative year indicating a year BCE.
64
	 */
65
	private function allowNegativeYear(ISchemaWrapper $schema) {
66
		$schema->getTable('music_tracks')->changeColumn('year', ['unsigned' => false]);
0 ignored issues
show
Deprecated Code introduced by
The function Doctrine\DBAL\Schema\Table::changeColumn() has been deprecated: Use {@link modifyColumn()} instead. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

66
		/** @scrutinizer ignore-deprecated */ $schema->getTable('music_tracks')->changeColumn('year', ['unsigned' => false]);

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
67
	}
68
69
	/**
70
	 * Add the new fields to the `music_ampache_sessions` table
71
	 */
72
	private function ampacheSessionChanges(ISchemaWrapper $schema) {
73
		// On SQLite, it's not possible to add notnull columns to an existing table without a default value, see
74
		// https://stackoverflow.com/questions/3170634/cannot-add-a-not-null-column-with-default-value-null-in-sqlite3.
75
		// To work around this, we need to recreate the entire music_ampache_sessions table from scratch.
76
		$schema->dropTable('music_ampache_sessions');
77
78
		// Table is recreated in the next migration script Version010901Date20231008194500
79
	}
80
81
	/**
82
	 * Add the new field 'rating' to applicable tables
83
	 */
84
	private function addRatingFields(ISchemaWrapper $schema) {
85
		$tableNames = [
86
			'music_artists',
87
			'music_albums',
88
			'music_tracks',
89
			'music_playlists',
90
			'music_podcast_channels',
91
			'music_podcast_episodes'
92
		];
93
94
		foreach ($tableNames as $tableName) {
95
			$table = $schema->getTable($tableName);
96
			$this->setColumn($table, 'rating', 'integer', ['notnull' => true, 'default' => 0]);
97
		}
98
99
		// Also, add 'starred' field for playlists
100
		$this->setColumn($schema->getTable('music_playlists'), 'starred', 'datetime', ['notnull' => false]);
101
	}
102
103
	private function setColumn($table, string $name, string $type, array $args) {
104
		if (!$table->hasColumn($name)) {
105
			$table->addColumn($name, $type, $args);
106
		}
107
	}
108
}
109