Issues in favoritecontroller.php (master) - Issues in master - owncloud/maps - Measure and Improve Code Quality continuously with Scrutinizer

Issues (75)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controller/favoritecontroller.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * ownCloud - maps
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Vinzenz Rosenkranz <[email protected]>
 * @copyright Vinzenz Rosenkranz 2015
 */

namespace OCA\Maps\Controller;

use OCA\Maps\Db\Favorite;
use OCA\Maps\Db\FavoriteMapper;
use \OCP\IRequest;
use \OCP\AppFramework\Http\JSONResponse;
use \OCP\AppFramework\ApiController;


class FavoriteController extends ApiController {

	private $userId;
	private $favoriteMapper;

	public function __construct($appName, IRequest $request, FavoriteMapper $favoriteMapper, $userId) {
		parent::__construct($appName, $request);
		$this->favoriteMapper = $favoriteMapper;
		$this->userId = $userId;
	}

	/**
	 * @NoAdminRequired
	 *
	 * @param $name string
	 * @param $id int
	 * @return JSONResponse
	 */
	public function updateFavorite($name, $id) {


		$favorite = new Favorite();
		$favorite->setId($id);
		$favorite->setName($name);
		$favorite->setTimestamp(time());

		/* Only save favorite if it exists in db */
		try {
			$this->favoriteMapper->find($id);
			return new JSONResponse($this->favoriteMapper->update($favorite));
		} catch(\OCP\AppFramework\Db\DoesNotExistException $e) {

			return new JSONResponse([
				'error' => $e->getMessage()
			]);
		}
	}

	/**
	 * @NoAdminRequired
	 *
	 * @param $lat float
	 * @param $lng float
	 * @return JSONResponse
	 */
	public function addFavorite($lat, $lng, $name = null){
		$favorite = new Favorite();
		$favorite->setName($name);
		$favorite->setTimestamp(time());
		$favorite->setUserId($this->userId);
		$favorite->setLat($lat);
		$favorite->setLng($lng);

		/* @var $favorite Favorite */
		$favorite = $this->favoriteMapper->insert($favorite);

		$response = array('id'=> $favorite->getId());
		return new JSONResponse($response);
	}

	/**
	 * @NoAdminRequired
	 *
	 * @return JSONResponse
	 */
	public function getFavorites(){
		$favorites = $this->favoriteMapper->findAll();
		return new JSONResponse($favorites);
	}

	/**
	 * @NoAdminRequired
	 *
	 * @param $name string
	 *
	 * @return JSONResponse
	 */
	public function getFavoritesByName($name){
		$favorites = $this->favoriteMapper->findByName($name);
		return new JSONResponse($favorites);
	}

	/**
	 * @NoAdminRequired
	 *
	 * @param $id int
	 * @return JSONResponse
	 */
	public function removeFavorite($id){
		$favorite = $this->favoriteMapper->find($id);
		if($favorite->userId == $this->userId) {
			$this->favoriteMapper->delete($favorite);
		}
		return new JSONResponse();
	}

}


1		<?php
2		/**
3		* ownCloud - maps
4		*
5		* This file is licensed under the Affero General Public License version 3 or
6		* later. See the COPYING file.
7		*
8		* @author Vinzenz Rosenkranz <[email protected]>
9		* @copyright Vinzenz Rosenkranz 2015
10		*/
11
12		namespace OCA\Maps\Controller;
13
14		use OCA\Maps\Db\Favorite;
15		use OCA\Maps\Db\FavoriteMapper;
16		use \OCP\IRequest;
17		use \OCP\AppFramework\Http\JSONResponse;
18		use \OCP\AppFramework\ApiController;
19
20
21		class FavoriteController extends ApiController {
22
23		private $userId;
24		private $favoriteMapper;
25
26		public function __construct($appName, IRequest $request, FavoriteMapper $favoriteMapper, $userId) {
27		parent::__construct($appName, $request);
28		$this->favoriteMapper = $favoriteMapper;
29		$this->userId = $userId;
30		}
31
32		/**
33		* @NoAdminRequired
34		*
35		* @param $name string
36		* @param $id int
37		* @return JSONResponse
38		*/
39	View Code Duplication	public function updateFavorite($name, $id) {
		0 ignored issues – show Duplication introduced 2017-08-12 00:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40
41		$favorite = new Favorite();
42		$favorite->setId($id);
43		$favorite->setName($name);
44		$favorite->setTimestamp(time());
45
46		/* Only save favorite if it exists in db */
47		try {
48		$this->favoriteMapper->find($id);
49		return new JSONResponse($this->favoriteMapper->update($favorite));
50		} catch(\OCP\AppFramework\Db\DoesNotExistException $e) {
		0 ignored issues – show Bug introduced 2015-11-25 00:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `OCP\AppFramework\Db\DoesNotExistException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
51		return new JSONResponse([
52		'error' => $e->getMessage()
53		]);
54		}
55		}
56
57		/**
58		* @NoAdminRequired
59		*
60		* @param $lat float
61		* @param $lng float
62		* @return JSONResponse
63		*/
64		public function addFavorite($lat, $lng, $name = null){
65		$favorite = new Favorite();
66		$favorite->setName($name);
67		$favorite->setTimestamp(time());
68		$favorite->setUserId($this->userId);
69		$favorite->setLat($lat);
70		$favorite->setLng($lng);
71
72		/* @var $favorite Favorite */
73		$favorite = $this->favoriteMapper->insert($favorite);
74
75		$response = array('id'=> $favorite->getId());
76		return new JSONResponse($response);
77		}
78
79		/**
80		* @NoAdminRequired
81		*
82		* @return JSONResponse
83		*/
84		public function getFavorites(){
85		$favorites = $this->favoriteMapper->findAll();
86		return new JSONResponse($favorites);
87		}
88
89		/**
90		* @NoAdminRequired
91		*
92		* @param $name string
93		*
94		* @return JSONResponse
95		*/
96		public function getFavoritesByName($name){
97		$favorites = $this->favoriteMapper->findByName($name);
98		return new JSONResponse($favorites);
99		}
100
101		/**
102		* @NoAdminRequired
103		*
104		* @param $id int
105		* @return JSONResponse
106		*/
107		public function removeFavorite($id){
108		$favorite = $this->favoriteMapper->find($id);
109		if($favorite->userId == $this->userId) {
110		$this->favoriteMapper->delete($favorite);
111		}
112		return new JSONResponse();
113		}
114
115		}
116

owncloud / maps

Issues (75)

Security Analysis not enabled

controller/favoritecontroller.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like