Application::__construct() - Code Metrics - Inspection of "[WIP] add backbone radio for advanced event and re..." - owncloud/mail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1272)

by Christoph

created 2016-02-06 11:12 UTC

Application::__construct() B

↳ Parent: Application

Complexity

Conditions	2
Paths	1

Size

Total Lines	186
Code Lines	104

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	25
CRAP Score	3.9849

Importance

Changes	5
Bugs	2	Features	3

Metric	Value
c	5
b	2
f	3
dl	0
loc	186
ccs	25
cts	120
cp	0.2083
rs	8.2857
cc	2
eloc	104
nc	1
nop	1
crap	3.9849

How to fix Long Method

<?php
/**
 * ownCloud - mail
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Thomas Müller <[email protected]>
 * @copyright Thomas Müller 2014
 */

namespace OCA\Mail\AppInfo;

use OCA\Mail\Controller\AccountsController;
use OCA\Mail\Controller\FoldersController;
use OCA\Mail\Controller\MessagesController;
use OCA\Mail\Controller\ProxyController;
use OCA\Mail\Db\MailAccountMapper;
use OCA\Mail\Service\AccountService;
use OCA\Mail\Service\AutoConfig\AutoConfig;
use OCA\Mail\Service\AutoConfig\ImapConnectivityTester;
use OCA\Mail\Service\AutoConfig\ImapConnector;
use OCA\Mail\Service\AutoConfig\ImapServerDetector;
use OCA\Mail\Service\AutoConfig\MozillaIspDb;
use OCA\Mail\Service\AutoConfig\MxRecord;
use OCA\Mail\Service\AutoConfig\SmtpConnectivityTester;
use OCA\Mail\Service\AutoConfig\SmtpServerDetector;
use OCA\Mail\Service\ContactsIntegration;
use OCA\Mail\Service\Logger;
use \OCP\AppFramework\App;
use \OCA\Mail\Controller\PageController;
use OCP\AppFramework\IAppContainer;

class Application extends App {

	public function __construct (array $urlParams=array()) {
		parent::__construct('mail', $urlParams);

		$container = $this->getContainer();

		/**
		 * Controllers
		 */
		$container->registerService('PageController', function($c) {
			/** @var IAppContainer $c */
			return new PageController(
				$c->query('AppName'),
				$c->query('Request'),
				$c->query('MailAccountMapper'),
				$c->query('ServerContainer')->getURLGenerator(),
				$c->query('UserId')
			);
		});

		$container->registerService('AccountService', function($c) {
			/** @var IAppContainer $c */
			return new AccountService(
				$c->query('MailAccountMapper'),
				$c->getServer()->getL10N('mail')
			);
		});

		$container->registerService('AccountsController', function($c) {
			/** @var IAppContainer $c */
			return new AccountsController(
				$c->query('AppName'),
				$c->query('Request'),
				$c->query('AccountService'),
				$c->query('UserId'),
				$c->getServer()->getUserFolder(),
				$c->query('ContactsIntegration'),
				$c->query('AutoConfig'),
				$c->query('Logger'),
				$c->getServer()->getL10N('mail'),
				$c->getServer()->getCrypto()
			);
		});

		$container->registerService('FoldersController', function($c) {
			/** @var IAppContainer $c */
			return new FoldersController(
				$c->query('AppName'),
				$c->query('Request'),
				$c->query('AccountService'),
				$c->query('UserId')
			);
		});

		$container->registerService('MessagesController', function($c) {
			/** @var IAppContainer $c */
			return new MessagesController(
				$c->query('AppName'),
				$c->query('Request'),
				$c->query('AccountService'),
				$c->query('UserId'),
				$c->getServer()->getUserFolder(),
				$c->query('ContactsIntegration'),
				$c->query('Logger'),
				$c->getServer()->getL10N('mail')
			);
		});

		$container->registerService('ProxyController', function($c) {
			/** @var IAppContainer $c */
			return new ProxyController(
				$c->query('AppName'),
				$c->query('Request'),
				$c->query('ServerContainer')->getURLGenerator(),
				$c->query('ServerContainer')->getSession(),
				$c->getServer()->getHelper(),
				isset($_SERVER['HTTP_REFERER']) ? : null,
				\OCP\Util::getServerHostName()
			);
		});

		/**
		 * Mappers
		 */
		$container->registerService('MailAccountMapper', function ($c) {
			/** @var IAppContainer $c */
			return new MailAccountMapper($c->getServer()->getDb());
		});

		/**
		 * Services
		 */
		$container->registerService('ContactsIntegration', function ($c) {
			/** @var IAppContainer $c */
			return new ContactsIntegration($c->getServer()->getContactsManager());
		});

		$container->registerService('ImapConnectivityTester', function($c) {
			/** @var IAppContainer $c */
			return new ImapConnectivityTester(
				$c->query('ImapConnector'),
				$c->query('Logger'),
				$c->query('UserId')
			);
		});

		$container->registerService('ImapConnector', function($c) {
			/** @var IAppContainer $c */
			return new ImapConnector(
				$c->getServer()->getCrypto(),
				$c->query('Logger'),
				$c->query('UserId')
			);
		});

		$container->registerService('ImapServerDetector', function($c) {
			/** @var IAppContainer $c */
			return new ImapServerDetector(
				$c->query('MxRecord'),
				$c->query('ImapConnectivityTester')
			);
		});

		$container->registerService('SmtpConnectivityTester', function($c) {
			/** @var IAppContainer $c */
			return new SmtpConnectivityTester(
				$c->getServer()->getCrypto(),
				$c->query('Logger'),
				$c->query('UserId')
			);
		});

		$container->registerService('SmtpServerDetector', function($c) {
			$transport = $c->getServer()->getConfig()->getSystemValue('app.mail.transport', 'smtp');
			/** @var IAppContainer $c */
			return new SmtpServerDetector(
				$c->query('MxRecord'),
				$c->query('SmtpConnectivityTester'),
				$transport === 'smtp'
			);
		});

		$container->registerService('MozillaIspDb', function($c) {
			/** @var IAppContainer $c */
			return new MozillaIspDb(
				$c->query('Logger')
			);
		});

		$container->registerService('MxRecord', function($c) {
			/** @var IAppContainer $c */
			return new MxRecord(
				$c->query('Logger')
			);
		});

		$container->registerService('AutoConfig', function ($c) {
			/** @var IAppContainer $c */
			return new AutoConfig(
				$c->query('Logger'),
				$c->query('UserId'),
				$c->query('MozillaIspDb'),
				$c->query('MxRecord'),
				$c->query('ImapConnectivityTester'),
				$c->query('ImapServerDetector'),
				$c->query('SmtpConnectivityTester'),
				$c->query('SmtpServerDetector'),
				$c->query('ImapConnector'),
				$c->getServer()->getCrypto()
			);
		});

		$container->registerService('Logger', function ($c) {
			/** @var IAppContainer $c */
			return new Logger(
				$c->query('AppName'),
				$c->query('ServerContainer')->getLogger()
			);
		});

		/**
		 * Core
		 */
		$container->registerService('UserId', function() {
			return \OCP\User::getUser();
		});
	}

}


1		<?php
2		/**
3		* ownCloud - mail
4		*
5		* This file is licensed under the Affero General Public License version 3 or
6		* later. See the COPYING file.
7		*
8		* @author Thomas Müller <[email protected]>
9		* @copyright Thomas Müller 2014
10		*/
11
12		namespace OCA\Mail\AppInfo;
13
14		use OCA\Mail\Controller\AccountsController;
15		use OCA\Mail\Controller\FoldersController;
16		use OCA\Mail\Controller\MessagesController;
17		use OCA\Mail\Controller\ProxyController;
18		use OCA\Mail\Db\MailAccountMapper;
19		use OCA\Mail\Service\AccountService;
20		use OCA\Mail\Service\AutoConfig\AutoConfig;
21		use OCA\Mail\Service\AutoConfig\ImapConnectivityTester;
22		use OCA\Mail\Service\AutoConfig\ImapConnector;
23		use OCA\Mail\Service\AutoConfig\ImapServerDetector;
24		use OCA\Mail\Service\AutoConfig\MozillaIspDb;
25		use OCA\Mail\Service\AutoConfig\MxRecord;
26		use OCA\Mail\Service\AutoConfig\SmtpConnectivityTester;
27		use OCA\Mail\Service\AutoConfig\SmtpServerDetector;
28		use OCA\Mail\Service\ContactsIntegration;
29		use OCA\Mail\Service\Logger;
30		use \OCP\AppFramework\App;
31		use \OCA\Mail\Controller\PageController;
32		use OCP\AppFramework\IAppContainer;
33
34		class Application extends App {
35
36	1	public function __construct (array $urlParams=array()) {
37	1	parent::__construct('mail', $urlParams);
38
39	1	$container = $this->getContainer();
40
41		/**
42		* Controllers
43		*/
44		$container->registerService('PageController', function($c) {
45		/** @var IAppContainer $c */
46		return new PageController(
47		$c->query('AppName'),
48		$c->query('Request'),
49		$c->query('MailAccountMapper'),
50		$c->query('ServerContainer')->getURLGenerator(),
51		$c->query('UserId')
52		);
53	1	});
54
55		$container->registerService('AccountService', function($c) {
56		/** @var IAppContainer $c */
57		return new AccountService(
58		$c->query('MailAccountMapper'),
59		$c->getServer()->getL10N('mail')
60		);
61	1	});
62
63		$container->registerService('AccountsController', function($c) {
64		/** @var IAppContainer $c */
65		return new AccountsController(
66		$c->query('AppName'),
67		$c->query('Request'),
68		$c->query('AccountService'),
69		$c->query('UserId'),
70		$c->getServer()->getUserFolder(),
71		$c->query('ContactsIntegration'),
72		$c->query('AutoConfig'),
73		$c->query('Logger'),
74		$c->getServer()->getL10N('mail'),
75		$c->getServer()->getCrypto()
76		);
77	1	});
78
79		$container->registerService('FoldersController', function($c) {
80		/** @var IAppContainer $c */
81		return new FoldersController(
82		$c->query('AppName'),
83		$c->query('Request'),
84		$c->query('AccountService'),
85		$c->query('UserId')
86		);
87	1	});
88
89		$container->registerService('MessagesController', function($c) {
90		/** @var IAppContainer $c */
91		return new MessagesController(
92		$c->query('AppName'),
93		$c->query('Request'),
94		$c->query('AccountService'),
95		$c->query('UserId'),
96		$c->getServer()->getUserFolder(),
97		$c->query('ContactsIntegration'),
98		$c->query('Logger'),
99		$c->getServer()->getL10N('mail')
100		);
101	1	});
102
103		$container->registerService('ProxyController', function($c) {
104		/** @var IAppContainer $c */
105		return new ProxyController(
106		$c->query('AppName'),
107		$c->query('Request'),
108		$c->query('ServerContainer')->getURLGenerator(),
109		$c->query('ServerContainer')->getSession(),
110		$c->getServer()->getHelper(),
111		isset($_SERVER['HTTP_REFERER']) ? : null,
112		\OCP\Util::getServerHostName()
113		);
114	1	});
115
116		/**
117		* Mappers
118		*/
119		$container->registerService('MailAccountMapper', function ($c) {
120		/** @var IAppContainer $c */
121		return new MailAccountMapper($c->getServer()->getDb());
122	1	});
123
124		/**
125		* Services
126		*/
127		$container->registerService('ContactsIntegration', function ($c) {
128		/** @var IAppContainer $c */
129		return new ContactsIntegration($c->getServer()->getContactsManager());
130	1	});
131
132		$container->registerService('ImapConnectivityTester', function($c) {
133		/** @var IAppContainer $c */
134	1	return new ImapConnectivityTester(
135		$c->query('ImapConnector'),
136		$c->query('Logger'),
137	1	$c->query('UserId')
138		);
139	1	});
140
141		$container->registerService('ImapConnector', function($c) {
142		/** @var IAppContainer $c */
143		return new ImapConnector(
144		$c->getServer()->getCrypto(),
145		$c->query('Logger'),
146		$c->query('UserId')
147		);
148	1	});
149
150		$container->registerService('ImapServerDetector', function($c) {
151		/** @var IAppContainer $c */
152		return new ImapServerDetector(
153		$c->query('MxRecord'),
154		$c->query('ImapConnectivityTester')
155		);
156	1	});
157
158		$container->registerService('SmtpConnectivityTester', function($c) {
159		/** @var IAppContainer $c */
160		return new SmtpConnectivityTester(
161		$c->getServer()->getCrypto(),
162		$c->query('Logger'),
163		$c->query('UserId')
164		);
165	1	});
166
167		$container->registerService('SmtpServerDetector', function($c) {
168		$transport = $c->getServer()->getConfig()->getSystemValue('app.mail.transport', 'smtp');
169		/** @var IAppContainer $c */
170		return new SmtpServerDetector(
171		$c->query('MxRecord'),
172		$c->query('SmtpConnectivityTester'),
173		$transport === 'smtp'
174		);
175	1	});
176
177		$container->registerService('MozillaIspDb', function($c) {
178		/** @var IAppContainer $c */
179		return new MozillaIspDb(
180		$c->query('Logger')
181		);
182	1	});
183
184		$container->registerService('MxRecord', function($c) {
185		/** @var IAppContainer $c */
186		return new MxRecord(
187		$c->query('Logger')
188		);
189	1	});
190
191		$container->registerService('AutoConfig', function ($c) {
192		/** @var IAppContainer $c */
193		return new AutoConfig(
194		$c->query('Logger'),
195		$c->query('UserId'),
196		$c->query('MozillaIspDb'),
197		$c->query('MxRecord'),
198		$c->query('ImapConnectivityTester'),
199		$c->query('ImapServerDetector'),
200		$c->query('SmtpConnectivityTester'),
201		$c->query('SmtpServerDetector'),
202		$c->query('ImapConnector'),
203		$c->getServer()->getCrypto()
204		);
205	1	});
206
207		$container->registerService('Logger', function ($c) {
208		/** @var IAppContainer $c */
209		return new Logger(
210		$c->query('AppName'),
211		$c->query('ServerContainer')->getLogger()
212		);
213	1	});
214
215		/**
216		* Core
217		*/
218	1	$container->registerService('UserId', function() {
219		return \OCP\User::getUser();
220	1	});
221	1	}
222
223		}
224

owncloud / mail

Pull Request — master (#1272)

Application::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like