AccountsControllerTest - Code Metrics - Inspection of "Merge pull request #1638 from owncloud/scrutinizer..." - owncloud/mail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 45aa1e...841b62 )

by Thomas

created 2016-09-01 12:11 UTC

AccountsControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	406
Duplicated Lines	15.27 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	20
c	1
b	0
f	1
lcom	1
cbo	2
dl	62
loc	406
rs	10

How to fix Duplicated Code

<?php

/**
 * @author Christoph Wurst <[email protected]>
 * @author Thomas Müller <[email protected]>
 *
 * Mail
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */
use OCA\Mail\Controller\AccountsController;
use OCA\Mail\Model\Message;
use OC\AppFramework\Http;
use OCP\AppFramework\Http\JSONResponse;
use OCA\Mail\Service\AliasesService;

class AccountsControllerTest extends \Test\TestCase {

	private $appName;
	private $request;
	private $accountService;
	private $userId;
	private $userFolder;
	private $autoConfig;
	private $logger;
	private $l10n;
	private $crypto;
	private $collector;
	private $controller;
	private $accountId;
	private $account;
	private $unifiedAccount;
	private $aliasesService;

	protected function setUp() {
		parent::setUp();

		$this->appName = 'mail';
		$this->request = $this->getMockBuilder('\OCP\IRequest')
			->disableOriginalConstructor()
			->getMock();
		$this->accountService = $this->getMockBuilder('\OCA\Mail\Service\AccountService')
			->disableOriginalConstructor()
			->getMock();
		$this->userId = 'manfred';
		$this->userFolder = $this->getMockBuilder('\OCP\Files\Folder')
			->disableOriginalConstructor()
			->getMock();
		$this->autoConfig = $this->getMockBuilder('\OCA\Mail\Service\AutoConfig\AutoConfig')
			->disableOriginalConstructor()
			->getMock();
		$this->logger = $this->getMockBuilder('\OCA\Mail\Service\Logger')
			->disableOriginalConstructor()
			->getMock();
		$this->l10n = $this->getMockBuilder('\OCP\IL10N')
			->disableOriginalConstructor()
			->getMock();
		$this->crypto = $this->getMockBuilder('\OCP\Security\ICrypto')
			->disableOriginalConstructor()
			->getMock();
		$this->collector = $this->getMockBuilder('\OCA\Mail\Service\AutoCompletion\AddressCollector')
			->disableOriginalConstructor()
			->getMock();
		$this->aliasesService = $this->getMockBuilder('\OCA\Mail\Service\AliasesService')
			->disableOriginalConstructor()
			->getMock();

		$this->controller = new AccountsController($this->appName, $this->request,
			$this->accountService, $this->userId, $this->userFolder, $this->autoConfig,
			$this->logger, $this->l10n, $this->crypto, $this->collector, $this->aliasesService);

		$this->account = $this->getMockBuilder('\OCA\Mail\Account')
			->disableOriginalConstructor()
			->getMock();
		$this->unifiedAccount = $this->getMockBuilder('\OCA\Mail\Service\UnifiedAccount')
			->disableOriginalConstructor()
			->getMock();
		$this->accountId = 123;
	}

	public function testIndex() {
		$this->account->expects($this->once())
			->method('getConfiguration')
			->will($this->returnValue([
				'accountId' => 123,
			]));
		$this->accountService->expects($this->once())
			->method('findByUserId')
			->with($this->equalTo($this->userId))
			->will($this->returnValue([$this->account]));
		$this->aliasesService->expects($this->any())
			->method('findAll')
			->with($this->equalTo($this->accountId), $this->equalTo($this->userId))
			->will($this->returnValue('aliases'));

		$response = $this->controller->index();

		$expectedResponse = new JSONResponse([
			[
				'accountId' => 123,
				'aliases' => 'aliases'
			]
		]);
		$this->assertEquals($expectedResponse, $response);
	}

	public function testShow() {
		$this->accountService->expects($this->once())
			->method('find')
			->with($this->equalTo($this->userId), $this->equalTo($this->accountId))
			->will($this->returnValue($this->account));
		$this->account->expects($this->once())
			->method('getConfiguration')
			->will($this->returnValue('conf'));

		$response = $this->controller->show($this->accountId);

		$expectedResponse = new JSONResponse('conf');
		$this->assertEquals($expectedResponse, $response);
	}

	public function testShowDoesNotExist() {
		$this->accountService->expects($this->once())
			->method('find')
			->with($this->equalTo($this->userId), $this->equalTo($this->accountId))
			->will($this->returnValue($this->account));
		$this->account->expects($this->once())
			->method('getConfiguration')
			->will($this->throwException(new OCP\AppFramework\Db\DoesNotExistException('test123')));

		$response = $this->controller->show($this->accountId);

		$expectedResponse = new JSONResponse([]);
		$expectedResponse->setStatus(404);
		$this->assertEquals($expectedResponse, $response);
	}

	public function testDestroy() {
		$this->accountService->expects($this->once())
			->method('delete')
			->with($this->equalTo($this->userId), $this->equalTo($this->accountId));

		$response = $this->controller->destroy($this->accountId);

		$expectedResponse = new JSONResponse();
		$this->assertEquals($expectedResponse, $response);
	}

	public function testDestroyDoesNotExist() {
		$this->accountService->expects($this->once())
			->method('delete')
			->with($this->equalTo($this->userId), $this->equalTo($this->accountId))
			->will($this->throwException(new \OCP\AppFramework\Db\DoesNotExistException('test')));

		$response = $this->controller->destroy($this->accountId);

		$expectedResponse = new JSONResponse();
		$this->assertEquals($expectedResponse, $response);
	}

	public function testCreateAutoDetectSuccess() {
		$email = '[email protected]';
		$password = '123456';
		$accountName = 'John Doe';

		$this->account->expects($this->exactly(2))
			->method('getId')
			->will($this->returnValue(135));
		$this->autoConfig->expects($this->once())
			->method('createAutoDetected')
			->with($this->equalTo($email), $this->equalTo($password),
				$this->equalTo($accountName))
			->will($this->returnValue($this->account));
		$this->accountService->expects($this->once())
			->method('save')
			->with($this->equalTo($this->account));

		$response = $this->controller->create($accountName, $email, $password, null,
			null, null, null, null, null, null, null, null, null, true);

		$expectedResponse = new JSONResponse([
			'data' => [
				'id' => 135,
			],
			], Http::STATUS_CREATED);
		$this->assertEquals($expectedResponse, $response);
	}

	public function testCreateAutoDetectFailure() {
		$email = '[email protected]';
		$password = '123456';
		$accountName = 'John Doe';

		$this->autoConfig->expects($this->once())
			->method('createAutoDetected')
			->with($this->equalTo($email), $this->equalTo($password),
				$this->equalTo($accountName))
			->will($this->returnValue(null));
		$this->l10n->expects($this->once())
			->method('t')
			->will($this->returnValue('fail'));

		$response = $this->controller->create($accountName, $email, $password, null,
			null, null, null, null, null, null, null, null, null, true);

		$expectedResponse = new JSONResponse([
			'message' => 'fail',
			], Http::STATUS_BAD_REQUEST);
		$this->assertEquals($expectedResponse, $response);
	}

	public function newMessageDataProvider() {
		return [
			[false, false, false],
			[true, false, false],
			[false, true, false],
			[true, true, true],
		];
	}

	/**
	 * @dataProvider newMessageDataProvider
	 */
	public function testSend($isUnifiedInbox, $isReply, $addressCollectorError) {
		$account = $isUnifiedInbox ? $this->unifiedAccount : $this->account;
		$folderId = base64_encode('My folder');
		$subject = 'Hello';
		$body = 'Hi!';
		$from = '[email protected]';
		$to = '[email protected]';
		$cc = '"user2" <[email protected]>, [email protected]';
		$bcc = '[email protected]';
		$draftUID = 45;
		$messageId = $isReply ? 123 : null;
		$attachmentName = 'kitten.png';
		$attachments = [
			[
				'fileName' => $attachmentName
			],
		];
		$aliasId = null;

		$this->accountService->expects($this->once())
			->method('find')
			->with($this->userId, $this->accountId)
			->will($this->returnValue($account));
		if ($isUnifiedInbox) {
			$this->unifiedAccount->expects($this->once())
				->method('resolve')
				->with($messageId)
				->will($this->returnValue([$this->account, $folderId, $messageId]));
		}

		if ($isReply) {
			$message = $this->getMockBuilder('OCA\Mail\Model\ReplyMessage')
				->disableOriginalConstructor()
				->getMock();
			$this->account->expects($this->once())
				->method('newReplyMessage')
				->will($this->returnValue($message));
			$mailbox = $this->getMockBuilder('OCA\Mail\Service\IMailBox')
				->disableOriginalConstructor()
				->getMock();
			$this->account->expects($this->once())
				->method('getMailbox')
				->with(base64_decode($folderId))
				->will($this->returnValue($mailbox));
			$reply = new Message();
			$mailbox->expects($this->once())
				->method('getMessage')
				->with($messageId)
				->will($this->returnValue($reply));
			$message->expects($this->once())
				->method('setRepliedMessage')
				->with($reply);
		} else {
			$message = $this->getMockBuilder('OCA\Mail\Model\Message')
				->disableOriginalConstructor()
				->getMock();
			$this->account->expects($this->once())
				->method('newMessage')
				->will($this->returnValue($message));
		}

		$message->expects($this->once())
			->method('setTo')
			->with(Message::parseAddressList($to));
		$message->expects($this->once())
			->method('setSubject')
			->with($subject);
		$message->expects($this->once())
			->method('setFrom')
			->with($from);
		$message->expects($this->once())
			->method('setCC')
			->with(Message::parseAddressList($cc));
		$message->expects($this->once())
			->method('setBcc')
			->with(Message::parseAddressList($bcc));
		$message->expects($this->once())
			->method('setContent')
			->with($body);
		$message->expects($this->once())
			->method('getToList')
			->willReturn([]);
		$message->expects($this->once())
			->method('getCCList')
			->willReturn([]);
		$message->expects($this->once())
			->method('getBCCList')
			->willReturn([]);

		$this->account->expects($this->once())
			->method('getEMailAddress')
			->will($this->returnValue($from));
		$this->account->expects($this->once())
			->method('sendMessage')
			->with($message, $draftUID);
		$this->userFolder->expects($this->at(0))
			->method('nodeExists')
			->with($attachmentName)
			->will($this->returnValue(true));
		$file = $this->getMockBuilder('OCP\Files\File')
			->disableOriginalConstructor()
			->getMock();
		$this->userFolder->expects($this->once())
			->method('get')
			->with($attachmentName)
			->will($this->returnValue($file));
		if ($addressCollectorError) {
			$this->collector->expects($this->once())
				->method('addAddresses')
				->will($this->throwException(new \Exception('some error')));
		} else {
			$this->collector->expects($this->once())
				->method('addAddresses');
		}

		$expected = new JSONResponse();
		$actual = $this->controller->send($this->accountId, $folderId, $subject,
			$body, $to, $cc, $bcc, $draftUID, $messageId, $attachments, $aliasId);

		$this->assertEquals($expected, $actual);
	}

	public function draftDataProvider() {
		return [
			[false, false],
			[true, true],
			[true, false],
			[true, true],
		];
	}

	/**
	 * @dataProvider newMessageDataProvider
	 */
	public function testDraft($isUnifiedInbox, $withPreviousDraft) {
		$account = $isUnifiedInbox ? $this->unifiedAccount : $this->account;
		$subject = 'Hello';
		$body = 'Hi!';
		$from = '[email protected]';
		$to = '[email protected]';
		$cc = '"user2" <[email protected]>, [email protected]';
		$bcc = '[email protected]';
		$messageId = 123;
		$uid = $withPreviousDraft ? 123 : null;
		$newUID = 124;

		$this->accountService->expects($this->once())
			->method('find')
			->with($this->userId, $this->accountId)
			->will($this->returnValue($account));
		if ($isUnifiedInbox) {
			$this->unifiedAccount->expects($this->once())
				->method('resolve')
				->with($messageId)
				->will($this->returnValue([$this->account]));
		}

		$message = $this->getMockBuilder('OCA\Mail\Model\Message')
			->disableOriginalConstructor()
			->getMock();
		$this->account->expects($this->once())
			->method('newMessage')
			->will($this->returnValue($message));
		$message->expects($this->once())
			->method('setTo')
			->with(Message::parseAddressList($to));
		$message->expects($this->once())
			->method('setSubject')
			->with($subject);
		$message->expects($this->once())
			->method('setFrom')
			->with($from);
		$message->expects($this->once())
			->method('setCC')
			->with(Message::parseAddressList($cc));
		$message->expects($this->once())
			->method('setBcc')
			->with(Message::parseAddressList($bcc));
		$message->expects($this->once())
			->method('setContent')
			->with($body);
		$this->account->expects($this->once())
			->method('getEMailAddress')
			->will($this->returnValue($from));
		$this->account->expects($this->once())
			->method('saveDraft')
			->with($message, $uid)
			->will($this->returnValue($newUID));

		$expected = new JSONResponse([
			'uid' => $newUID,
		]);
		$actual = $this->controller->draft($this->accountId, $subject, $body, $to,
			$cc, $bcc, $uid, $messageId);

		$this->assertEquals($expected, $actual);
	}

}


1			<?php
2
3			/**
4			* @author Christoph Wurst <[email protected]>
5			* @author Thomas Müller <[email protected]>
6			*
7			* Mail
8			*
9			* This code is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License, version 3,
11			* as published by the Free Software Foundation.
12			*
13			* This program is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU Affero General Public License for more details.
17			*
18			* You should have received a copy of the GNU Affero General Public License, version 3,
19			* along with this program. If not, see <http://www.gnu.org/licenses/>
20			*
21			*/
22			use OCA\Mail\Controller\AccountsController;
23			use OCA\Mail\Model\Message;
24			use OC\AppFramework\Http;
25			use OCP\AppFramework\Http\JSONResponse;
26			use OCA\Mail\Service\AliasesService;
27
28			class AccountsControllerTest extends \Test\TestCase {
29
30			private $appName;
31			private $request;
32			private $accountService;
33			private $userId;
34			private $userFolder;
35			private $autoConfig;
36			private $logger;
37			private $l10n;
38			private $crypto;
39			private $collector;
40			private $controller;
41			private $accountId;
42			private $account;
43			private $unifiedAccount;
44			private $aliasesService;
45
46			protected function setUp() {
47			parent::setUp();
48
49			$this->appName = 'mail';
50			$this->request = $this->getMockBuilder('\OCP\IRequest')
51			->disableOriginalConstructor()
52			->getMock();
53			$this->accountService = $this->getMockBuilder('\OCA\Mail\Service\AccountService')
54			->disableOriginalConstructor()
55			->getMock();
56			$this->userId = 'manfred';
57			$this->userFolder = $this->getMockBuilder('\OCP\Files\Folder')
58			->disableOriginalConstructor()
59			->getMock();
60			$this->autoConfig = $this->getMockBuilder('\OCA\Mail\Service\AutoConfig\AutoConfig')
61			->disableOriginalConstructor()
62			->getMock();
63			$this->logger = $this->getMockBuilder('\OCA\Mail\Service\Logger')
64			->disableOriginalConstructor()
65			->getMock();
66			$this->l10n = $this->getMockBuilder('\OCP\IL10N')
67			->disableOriginalConstructor()
68			->getMock();
69			$this->crypto = $this->getMockBuilder('\OCP\Security\ICrypto')
70			->disableOriginalConstructor()
71			->getMock();
72			$this->collector = $this->getMockBuilder('\OCA\Mail\Service\AutoCompletion\AddressCollector')
73			->disableOriginalConstructor()
74			->getMock();
75			$this->aliasesService = $this->getMockBuilder('\OCA\Mail\Service\AliasesService')
76			->disableOriginalConstructor()
77			->getMock();
78
79			$this->controller = new AccountsController($this->appName, $this->request,
80			$this->accountService, $this->userId, $this->userFolder, $this->autoConfig,
81			$this->logger, $this->l10n, $this->crypto, $this->collector, $this->aliasesService);
82
83			$this->account = $this->getMockBuilder('\OCA\Mail\Account')
84			->disableOriginalConstructor()
85			->getMock();
86			$this->unifiedAccount = $this->getMockBuilder('\OCA\Mail\Service\UnifiedAccount')
87			->disableOriginalConstructor()
88			->getMock();
89			$this->accountId = 123;
90			}
91
92			public function testIndex() {
93			$this->account->expects($this->once())
94			->method('getConfiguration')
95			->will($this->returnValue([
96			'accountId' => 123,
97			]));
98			$this->accountService->expects($this->once())
99			->method('findByUserId')
100			->with($this->equalTo($this->userId))
101			->will($this->returnValue([$this->account]));
102			$this->aliasesService->expects($this->any())
103			->method('findAll')
104			->with($this->equalTo($this->accountId), $this->equalTo($this->userId))
105			->will($this->returnValue('aliases'));
106
107			$response = $this->controller->index();
108
109			$expectedResponse = new JSONResponse([
110			[
111			'accountId' => 123,
112			'aliases' => 'aliases'
113			]
114			]);
115			$this->assertEquals($expectedResponse, $response);
116			}
117
118			public function testShow() {
119			$this->accountService->expects($this->once())
120			->method('find')
121			->with($this->equalTo($this->userId), $this->equalTo($this->accountId))
122			->will($this->returnValue($this->account));
123			$this->account->expects($this->once())
124			->method('getConfiguration')
125			->will($this->returnValue('conf'));
126
127			$response = $this->controller->show($this->accountId);
128
129			$expectedResponse = new JSONResponse('conf');
130			$this->assertEquals($expectedResponse, $response);
131			}
132
133			public function testShowDoesNotExist() {
134			$this->accountService->expects($this->once())
135			->method('find')
136			->with($this->equalTo($this->userId), $this->equalTo($this->accountId))
137			->will($this->returnValue($this->account));
138			$this->account->expects($this->once())
139			->method('getConfiguration')
140			->will($this->throwException(new OCP\AppFramework\Db\DoesNotExistException('test123')));
141
142			$response = $this->controller->show($this->accountId);
143
144			$expectedResponse = new JSONResponse([]);
145			$expectedResponse->setStatus(404);
146			$this->assertEquals($expectedResponse, $response);
147			}
148
149			public function testDestroy() {
150			$this->accountService->expects($this->once())
151			->method('delete')
152			->with($this->equalTo($this->userId), $this->equalTo($this->accountId));
153
154			$response = $this->controller->destroy($this->accountId);
155
156			$expectedResponse = new JSONResponse();
157			$this->assertEquals($expectedResponse, $response);
158			}
159
160			public function testDestroyDoesNotExist() {
161			$this->accountService->expects($this->once())
162			->method('delete')
163			->with($this->equalTo($this->userId), $this->equalTo($this->accountId))
164			->will($this->throwException(new \OCP\AppFramework\Db\DoesNotExistException('test')));
165
166			$response = $this->controller->destroy($this->accountId);
167
168			$expectedResponse = new JSONResponse();
169			$this->assertEquals($expectedResponse, $response);
170			}
171
172			public function testCreateAutoDetectSuccess() {
173			$email = '[email protected]';
174			$password = '123456';
175			$accountName = 'John Doe';
176
177			$this->account->expects($this->exactly(2))
178			->method('getId')
179			->will($this->returnValue(135));
180			$this->autoConfig->expects($this->once())
181			->method('createAutoDetected')
182			->with($this->equalTo($email), $this->equalTo($password),
183			$this->equalTo($accountName))
184			->will($this->returnValue($this->account));
185			$this->accountService->expects($this->once())
186			->method('save')
187			->with($this->equalTo($this->account));
188
189			$response = $this->controller->create($accountName, $email, $password, null,
190			null, null, null, null, null, null, null, null, null, true);
191
192			$expectedResponse = new JSONResponse([
193			'data' => [
194			'id' => 135,
195			],
196			], Http::STATUS_CREATED);
197			$this->assertEquals($expectedResponse, $response);
198			}
199
200			public function testCreateAutoDetectFailure() {
201			$email = '[email protected]';
202			$password = '123456';
203			$accountName = 'John Doe';
204
205			$this->autoConfig->expects($this->once())
206			->method('createAutoDetected')
207			->with($this->equalTo($email), $this->equalTo($password),
208			$this->equalTo($accountName))
209			->will($this->returnValue(null));
210			$this->l10n->expects($this->once())
211			->method('t')
212			->will($this->returnValue('fail'));
213
214			$response = $this->controller->create($accountName, $email, $password, null,
215			null, null, null, null, null, null, null, null, null, true);
216
217			$expectedResponse = new JSONResponse([
218			'message' => 'fail',
219			], Http::STATUS_BAD_REQUEST);
220			$this->assertEquals($expectedResponse, $response);
221			}
222
223			public function newMessageDataProvider() {
224			return [
225			[false, false, false],
226			[true, false, false],
227			[false, true, false],
228			[true, true, true],
229			];
230			}
231
232			/**
233			* @dataProvider newMessageDataProvider
234			*/
235			public function testSend($isUnifiedInbox, $isReply, $addressCollectorError) {
236			$account = $isUnifiedInbox ? $this->unifiedAccount : $this->account;
237			$folderId = base64_encode('My folder');
238			$subject = 'Hello';
239			$body = 'Hi!';
240			$from = '[email protected]';
241			$to = '[email protected]';
242			$cc = '"user2" <[email protected]>, [email protected]';
243			$bcc = '[email protected]';
244			$draftUID = 45;
245			$messageId = $isReply ? 123 : null;
246			$attachmentName = 'kitten.png';
247			$attachments = [
248			[
249			'fileName' => $attachmentName
250			],
251			];
252			$aliasId = null;
253
254			$this->accountService->expects($this->once())
255			->method('find')
256			->with($this->userId, $this->accountId)
257			->will($this->returnValue($account));
258			if ($isUnifiedInbox) {
259			$this->unifiedAccount->expects($this->once())
260			->method('resolve')
261			->with($messageId)
262			->will($this->returnValue([$this->account, $folderId, $messageId]));
263			}
264
265			if ($isReply) {
266			$message = $this->getMockBuilder('OCA\Mail\Model\ReplyMessage')
267			->disableOriginalConstructor()
268			->getMock();
269			$this->account->expects($this->once())
270			->method('newReplyMessage')
271			->will($this->returnValue($message));
272			$mailbox = $this->getMockBuilder('OCA\Mail\Service\IMailBox')
273			->disableOriginalConstructor()
274			->getMock();
275			$this->account->expects($this->once())
276			->method('getMailbox')
277			->with(base64_decode($folderId))
278			->will($this->returnValue($mailbox));
279			$reply = new Message();
280			$mailbox->expects($this->once())
281			->method('getMessage')
282			->with($messageId)
283			->will($this->returnValue($reply));
284			$message->expects($this->once())
285			->method('setRepliedMessage')
286			->with($reply);
287			} else {
288			$message = $this->getMockBuilder('OCA\Mail\Model\Message')
289			->disableOriginalConstructor()
290			->getMock();
291			$this->account->expects($this->once())
292			->method('newMessage')
293			->will($this->returnValue($message));
294			}
295
296			$message->expects($this->once())
297			->method('setTo')
298			->with(Message::parseAddressList($to));
299			$message->expects($this->once())
300			->method('setSubject')
301			->with($subject);
302			$message->expects($this->once())
303			->method('setFrom')
304			->with($from);
305			$message->expects($this->once())
306			->method('setCC')
307			->with(Message::parseAddressList($cc));
308			$message->expects($this->once())
309			->method('setBcc')
310			->with(Message::parseAddressList($bcc));
311			$message->expects($this->once())
312			->method('setContent')
313			->with($body);
314			$message->expects($this->once())
315			->method('getToList')
316			->willReturn([]);
317			$message->expects($this->once())
318			->method('getCCList')
319			->willReturn([]);
320			$message->expects($this->once())
321			->method('getBCCList')
322			->willReturn([]);
323
324			$this->account->expects($this->once())
325			->method('getEMailAddress')
326			->will($this->returnValue($from));
327			$this->account->expects($this->once())
328			->method('sendMessage')
329			->with($message, $draftUID);
330			$this->userFolder->expects($this->at(0))
331			->method('nodeExists')
332			->with($attachmentName)
333			->will($this->returnValue(true));
334			$file = $this->getMockBuilder('OCP\Files\File')
335			->disableOriginalConstructor()
336			->getMock();
337			$this->userFolder->expects($this->once())
338			->method('get')
339			->with($attachmentName)
340			->will($this->returnValue($file));
341			if ($addressCollectorError) {
342			$this->collector->expects($this->once())
343			->method('addAddresses')
344			->will($this->throwException(new \Exception('some error')));
345			} else {
346			$this->collector->expects($this->once())
347			->method('addAddresses');
348			}
349
350			$expected = new JSONResponse();
351			$actual = $this->controller->send($this->accountId, $folderId, $subject,
352			$body, $to, $cc, $bcc, $draftUID, $messageId, $attachments, $aliasId);
353
354			$this->assertEquals($expected, $actual);
355			}
356
357			public function draftDataProvider() {
358			return [
359			[false, false],
360			[true, true],
361			[true, false],
362			[true, true],
363			];
364			}
365
366			/**
367			* @dataProvider newMessageDataProvider
368			*/
369			public function testDraft($isUnifiedInbox, $withPreviousDraft) {
370			$account = $isUnifiedInbox ? $this->unifiedAccount : $this->account;
371			$subject = 'Hello';
372			$body = 'Hi!';
373			$from = '[email protected]';
374			$to = '[email protected]';
375			$cc = '"user2" <[email protected]>, [email protected]';
376			$bcc = '[email protected]';
377			$messageId = 123;
378			$uid = $withPreviousDraft ? 123 : null;
379			$newUID = 124;
380
381			$this->accountService->expects($this->once())
382			->method('find')
383			->with($this->userId, $this->accountId)
384			->will($this->returnValue($account));
385			if ($isUnifiedInbox) {
386			$this->unifiedAccount->expects($this->once())
387			->method('resolve')
388			->with($messageId)
389			->will($this->returnValue([$this->account]));
390			}
391
392			$message = $this->getMockBuilder('OCA\Mail\Model\Message')
393			->disableOriginalConstructor()
394			->getMock();
395			$this->account->expects($this->once())
396			->method('newMessage')
397			->will($this->returnValue($message));
398			$message->expects($this->once())
399			->method('setTo')
400			->with(Message::parseAddressList($to));
401			$message->expects($this->once())
402			->method('setSubject')
403			->with($subject);
404			$message->expects($this->once())
405			->method('setFrom')
406			->with($from);
407			$message->expects($this->once())
408			->method('setCC')
409			->with(Message::parseAddressList($cc));
410			$message->expects($this->once())
411			->method('setBcc')
412			->with(Message::parseAddressList($bcc));
413			$message->expects($this->once())
414			->method('setContent')
415			->with($body);
416			$this->account->expects($this->once())
417			->method('getEMailAddress')
418			->will($this->returnValue($from));
419			$this->account->expects($this->once())
420			->method('saveDraft')
421			->with($message, $uid)
422			->will($this->returnValue($newUID));
423
424			$expected = new JSONResponse([
425			'uid' => $newUID,
426			]);
427			$actual = $this->controller->draft($this->accountId, $subject, $body, $to,
428			$cc, $bcc, $uid, $messageId);
429
430			$this->assertEquals($expected, $actual);
431			}
432
433			}
434

owncloud / mail

Push — master ( 45aa1e...841b62 )

AccountsControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like