OCA\Mail\Service\AccountService

Complexity

Total Complexity

15

Size/Duplication

Total Lines	103
Duplicated Lines	8.74 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

70.45%

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	findByUserId()	0	15	3
B	find()	0	15	5
A	delete()	0	7	2
A	save()	0	3	1
A	buildUnifiedAccount()	0	3	1
A	updateSignature()	9	9	2

<?php

/**
 * @author Christoph Wurst <christoph@winzerhof-wurst.at>
 * @author Thomas Müller <thomas.mueller@tmit.eu>
 *
 * Mail
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */
namespace OCA\Mail\Service;

use Exception;
use OCA\Mail\Account;
use OCA\Mail\Db\MailAccountMapper;
use OCP\IL10N;

class AccountService {

	/** @var \OCA\Mail\Db\MailAccountMapper */
	private $mapper;

	/**
	 * Cache accounts for multiple calls to 'findByUserId'
	 *
	 * @var IAccount[]
	 */
	private $accounts;

	/** @var IL10N */
	private $l10n;

	/**
	 * @param MailAccountMapper $mapper
	 */
	public function __construct(MailAccountMapper $mapper, IL10N $l10n) {
		$this->mapper = $mapper;
		$this->l10n = $l10n;
	}

	/**
	 * @param string $currentUserId
	 * @return IAccount[]
	 */
	public function findByUserId($currentUserId) {
		if ($this->accounts === null) {
			$accounts = $this->mapper->findByUserId($currentUserId);
			$accounts = array_map(function($a) {
				return new Account($a);
			}, $accounts);
			if (count($accounts) > 1) {
				$unifiedAccount = $this->buildUnifiedAccount($currentUserId);
				$accounts = array_merge([$unifiedAccount], $accounts);
			}
			$this->accounts = $accounts;
		}

		return $this->accounts;
	}

	/**
	 * @param $currentUserId
	 * @param $accountId
	 * @return IAccount
	 */
	public function find($currentUserId, $accountId) {
		if ($this->accounts !== null) {
			foreach ($this->accounts as $account) {
				if ($account->getId() === $accountId) {
					return $account;
				}
			}
			throw new Exception("Invalid account id <$accountId>");
		}

		if ((int)$accountId === UnifiedAccount::ID) {
			return $this->buildUnifiedAccount($currentUserId);
		}
		return new Account($this->mapper->find($currentUserId, $accountId));
	}

	/**
	 * @param int $accountId
	 */
	public function delete($currentUserId, $accountId) {
		if ((int)$accountId === UnifiedAccount::ID) {
			return;
		}
		$mailAccount = $this->mapper->find($currentUserId, $accountId);
		$this->mapper->delete($mailAccount);
	}

	/**
	 * @param $newAccount
	 * @return \OCA\Mail\Db\MailAccount
	 */
	public function save($newAccount) {
		return $this->mapper->save($newAccount);
	}

	private function buildUnifiedAccount($userId) {
		return new UnifiedAccount($this, $userId, $this->l10n);
	}

	/**
	 * @param int $accountId
	 * @param String $currentUserId
	 * @param String $signature
	 * @return \OCA\Mail\Db\Alias
	 */
	public function updateSignature($accountId, $currentUserId, $signature) {

This method seems to be duplicated in your project.

		try {
			$account = $this->mapper->find($currentUserId, $accountId);
			$account->setSignature($signature);
			return $this->mapper->update($account);
		} catch(Exception $e) {
			$this->handleException($e);

The method handleException() does not seem to exist on object<OCA\Mail\Service\AccountService>.

		}
	}
}