ScannerFactory - Code Metrics - Inspection of "Move Absract scanner to scanners. Refactor socket..." - owncloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#195)

by Victor

created 2017-10-23 22:28 UTC

ScannerFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

51.72%

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	2
dl	0
loc	64
ccs	15
cts	29
cp	0.5172
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	38	6
A	getScanner()	0	3	1

<?php
/**
 * Copyright (c) 2014 Viktar Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */

namespace OCA\Files_Antivirus;

use OCA\Files_Antivirus\Scanner\InitException;
use \OCP\ILogger;

class ScannerFactory{
	
	/**
	 * @var \OCA\Files_Antivirus\AppConfig
	 */
	protected $appConfig;
	
	/**
	 * @var ILogger;
	 */
	protected $logger;
	
	/**
	 * @var string
	 */
	protected $scannerClass;
	
	public function __construct(AppConfig $appConfig, ILogger $logger){
		$this->appConfig = $appConfig;
		$this->logger = $logger;
		try {
			$avMode = $appConfig->getAvMode();
			switch ($avMode) {
				case 'daemon':
					$this->scannerClass = 'OCA\Files_Antivirus\Scanner\Daemon';
					break;
				case 'socket':
					$this->scannerClass = 'OCA\Files_Antivirus\Scanner\Socket';
					break;
				case 'executable':
					$this->scannerClass = 'OCA\Files_Antivirus\Scanner\Local';
					break;
				default:
					throw new InitException(
						sprintf(
							'Please check the settings at the admin page. Invalid mode: "%s"',
							$avMode
						)
					);
					break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
			}
		} catch (InitException $e) {
			// TODO: add a new config option to prevent upload on misconfiguration
			//  and check it here
			$this->logger->warning(
				sprintf(
					'Application is misconfigured. %s',
					$e->getMessage()
				)
			);
		} catch (\Exception $e) {
			$message = 	implode(' ', [ __CLASS__, __METHOD__, $e->getMessage()]);
			$this->logger->warning($message);
		}
	}
	
	/**
	 * Produce a scanner instance 
	 * @return \OCA\Files_Antivirus\Scanner\AbstractScanner
	 */
	public function getScanner(){
		return new $this->scannerClass($this->appConfig, $this->logger);
	}
}


1		<?php
2		/**
3		* Copyright (c) 2014 Viktar Dubiniuk <[email protected]>
4		* This file is licensed under the Affero General Public License version 3 or
5		* later.
6		* See the COPYING-README file.
7		*/
8
9		namespace OCA\Files_Antivirus;
10
11		use OCA\Files_Antivirus\Scanner\InitException;
12		use \OCP\ILogger;
13
14		class ScannerFactory{
15
16		/**
17		* @var \OCA\Files_Antivirus\AppConfig
18		*/
19		protected $appConfig;
20
21		/**
22		* @var ILogger;
23		*/
24		protected $logger;
25
26		/**
27		* @var string
28		*/
29		protected $scannerClass;
30
31	8	public function __construct(AppConfig $appConfig, ILogger $logger){
32	8	$this->appConfig = $appConfig;
33	8	$this->logger = $logger;
34		try {
35	8	$avMode = $appConfig->getAvMode();
36		switch ($avMode) {
37	8	case 'daemon':
38	4	$this->scannerClass = 'OCA\Files_Antivirus\Scanner\Daemon';
39	4	break;
40	5	case 'socket':
41		$this->scannerClass = 'OCA\Files_Antivirus\Scanner\Socket';
42		break;
43	5	case 'executable':
44	5	$this->scannerClass = 'OCA\Files_Antivirus\Scanner\Local';
45	5	break;
46		default:
47		throw new InitException(
48		sprintf(
49		'Please check the settings at the admin page. Invalid mode: "%s"',
50		$avMode
51		)
52		);
53	8	break;
		0 ignored issues – show Unused Code introduced 2017-10-23 22:38 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
54		}
55		} catch (InitException $e) {
56		// TODO: add a new config option to prevent upload on misconfiguration
57		// and check it here
58		$this->logger->warning(
59		sprintf(
60		'Application is misconfigured. %s',
61		$e->getMessage()
62		)
63		);
64		} catch (\Exception $e) {
65		$message = implode(' ', [ __CLASS__, __METHOD__, $e->getMessage()]);
66		$this->logger->warning($message);
67		}
68	8	}
69
70		/**
71		* Produce a scanner instance
72		* @return \OCA\Files_Antivirus\Scanner\AbstractScanner
73		*/
74	4	public function getScanner(){
75	4	return new $this->scannerClass($this->appConfig, $this->logger);
76		}
77		}
78

owncloud / files_antivirus

Pull Request — master (#195)

ScannerFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like